Update PHP extension requirements & deprecate Common::mb_* methods (#16754)

* Require polyfill for mbstring and iconv

* remove mbstring methods from upgrade.php

* remove checks for some php extensions

* deprecate Common::mb_* methods, as we can directly use mb_* functions instead

* updates expected test files

* Directly use mb_* methods in favor of Common::mb_*

* Update expected screenshot

Co-authored-by: diosmosis <diosmosis@users.noreply.github.com>

1 files changed, 0 insertions, 26 deletions

diff --git a/libs/upgradephp/upgrade.php b/libs/upgradephp/upgrade.php
index 3ac2b8ae8c..8dcddf6351 100644
--- a/libs/upgradephp/upgrade.php
+++ b/libs/upgradephp/upgrade.php
@@ -674,32 +674,6 @@ if (!function_exists('utf8_decode')) {
 }
 
 /**
- * Use strtolower if mb_strtolower doesn't exist (i.e., php not compiled with --enable-mbstring)
- * This is not a functional replacement for mb_strtolower.
- *
- * @param string $input
- * @param string $charset
- */
-if(!function_exists('mb_strtolower')) {
-    function mb_strtolower($input, $charset = '') {
-        return strtolower($input);
-    }
-}
-
-/**
- * Use strlen if mb_strlen doesn't exist (i.e., php not compiled with --enable-mbstring)
- * This is not a functional replacement for mb_strlen.
- *
- * @param string $input
- * @param string $charset
- */
-if(!function_exists('mb_strlen')) {
-    function mb_strlen($input, $charset = '') {
-        return strlen($input);
-    }
-}
-
-/**
  * On ubuntu in some cases, there is a bug that gzopen does not exist and one must use gzopen64 instead
  */
 if (!function_exists('gzopen')