diff options
author | Matthieu Aubry <mattab@users.noreply.github.com> | 2016-09-26 03:03:59 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-09-26 03:03:59 +0300 |
commit | cdc50dc38924f396dff8d50ef019c24f2a7b7bfd (patch) | |
tree | bf81c250be06b2c390029f668509f30cf622d89d /plugins/Actions/Columns | |
parent | 04d0c74e08bb4d9575f50f79dbb38c403b327570 (diff) |
On very high traffic Piwik servers, prevent integer overflow by making auto_increment fields BIGINT UNSIGNED (#10548)
* Change Latitude and Longitude data types to DECIMAL instead of FLOAT
* Add system test that forces an integer overflow, currently failing as expected
* Make all overflow-able fields BIGINT UNSIGNED
* Make overflow-able fields BIGINT UNSIGNED
* These fields were not covered by the new SimulateAutoIncrementIntegerOverflow test
* fix comment
* Make it clear that id* fields are UNSIGNED when installing Piwik
* BIGINT(10) for consistency
* Update core fields to BIGINT
* UI tests: New fields to be updated to bigint
Diffstat (limited to 'plugins/Actions/Columns')
-rw-r--r-- | plugins/Actions/Columns/EntryPageTitle.php | 2 | ||||
-rw-r--r-- | plugins/Actions/Columns/EntryPageUrl.php | 2 | ||||
-rw-r--r-- | plugins/Actions/Columns/ExitPageTitle.php | 2 | ||||
-rw-r--r-- | plugins/Actions/Columns/ExitPageUrl.php | 2 | ||||
-rw-r--r-- | plugins/Actions/Columns/PageTitle.php | 2 | ||||
-rw-r--r-- | plugins/Actions/Columns/PageUrl.php | 2 |
6 files changed, 6 insertions, 6 deletions
diff --git a/plugins/Actions/Columns/EntryPageTitle.php b/plugins/Actions/Columns/EntryPageTitle.php index 72e80f8783..c23568cc0a 100644 --- a/plugins/Actions/Columns/EntryPageTitle.php +++ b/plugins/Actions/Columns/EntryPageTitle.php @@ -18,7 +18,7 @@ use Piwik\Tracker\Visitor; class EntryPageTitle extends VisitDimension { protected $columnName = 'visit_entry_idaction_name'; - protected $columnType = 'INTEGER(11) UNSIGNED NULL'; + protected $columnType = 'BIGINT(10) UNSIGNED NULL'; protected function configureSegments() { diff --git a/plugins/Actions/Columns/EntryPageUrl.php b/plugins/Actions/Columns/EntryPageUrl.php index 8adf0ab2f6..5ff80f43f5 100644 --- a/plugins/Actions/Columns/EntryPageUrl.php +++ b/plugins/Actions/Columns/EntryPageUrl.php @@ -18,7 +18,7 @@ use Piwik\Tracker\Visitor; class EntryPageUrl extends VisitDimension { protected $columnName = 'visit_entry_idaction_url'; - protected $columnType = 'INTEGER(11) UNSIGNED NULL'; + protected $columnType = 'BIGINT(10) UNSIGNED NULL'; protected function configureSegments() { diff --git a/plugins/Actions/Columns/ExitPageTitle.php b/plugins/Actions/Columns/ExitPageTitle.php index 766897bd32..4d238b51bb 100644 --- a/plugins/Actions/Columns/ExitPageTitle.php +++ b/plugins/Actions/Columns/ExitPageTitle.php @@ -18,7 +18,7 @@ use Piwik\Tracker\Visitor; class ExitPageTitle extends VisitDimension { protected $columnName = 'visit_exit_idaction_name'; - protected $columnType = 'INTEGER(11) UNSIGNED NULL'; + protected $columnType = 'BIGINT(10) UNSIGNED NULL'; protected function configureSegments() { diff --git a/plugins/Actions/Columns/ExitPageUrl.php b/plugins/Actions/Columns/ExitPageUrl.php index 1ef487f06b..36c8a31458 100644 --- a/plugins/Actions/Columns/ExitPageUrl.php +++ b/plugins/Actions/Columns/ExitPageUrl.php @@ -18,7 +18,7 @@ use Piwik\Tracker\Visitor; class ExitPageUrl extends VisitDimension { protected $columnName = 'visit_exit_idaction_url'; - protected $columnType = 'INTEGER(11) UNSIGNED NULL DEFAULT 0'; + protected $columnType = 'BIGINT(10) UNSIGNED NULL DEFAULT 0'; protected function configureSegments() { diff --git a/plugins/Actions/Columns/PageTitle.php b/plugins/Actions/Columns/PageTitle.php index 6517bede92..7590a456c9 100644 --- a/plugins/Actions/Columns/PageTitle.php +++ b/plugins/Actions/Columns/PageTitle.php @@ -15,7 +15,7 @@ use Piwik\Plugins\Actions\Segment; class PageTitle extends ActionDimension { protected $columnName = 'idaction_name'; - protected $columnType = 'INTEGER(10) UNSIGNED'; + protected $columnType = 'BIGINT(10) UNSIGNED'; protected function configureSegments() { diff --git a/plugins/Actions/Columns/PageUrl.php b/plugins/Actions/Columns/PageUrl.php index 1f9a7035e5..b33d0cfae8 100644 --- a/plugins/Actions/Columns/PageUrl.php +++ b/plugins/Actions/Columns/PageUrl.php @@ -15,7 +15,7 @@ use Piwik\Plugins\Actions\Segment; class PageUrl extends ActionDimension { protected $columnName = 'idaction_url'; - protected $columnType = 'INTEGER(10) UNSIGNED DEFAULT NULL'; + protected $columnType = 'BIGINT(10) UNSIGNED DEFAULT NULL'; protected function configureSegments() { |