diff options
| author | Stefan Giehl <stefan@matomo.org> | 2019-03-05 00:10:06 +0300 |
|---|---|---|
| committer | diosmosis <diosmosis@users.noreply.github.com> | 2019-03-05 00:10:06 +0300 |
| commit | 3ba0e38ffe5d45561d5dff541652a95c25a88dec (patch) | |
| tree | 8f73353c1c82e49506e195b15e3baf43fb07ef98 /plugins/Contents | |
| parent | 283ec8d650d25d6f7577c13108a69d98367fc486 (diff) | |
Improve total report values calculation (#14158)
* Ensure summed up values are numeric
to prevent a `A non well formed numeric value encountered` on PHP 7.x
* Do not calculate total values for average, rate or nested metrics
* Fix calculation for minimal or maximal metrics
* updates expected test files
* Also skip evolution metrics
* skip all non numeric values
* update test file
* calculate totals for nested metrics recursivly
* update test files
Diffstat (limited to 'plugins/Contents')
2 files changed, 0 insertions, 2 deletions
diff --git a/plugins/Contents/tests/System/expected/test_Contents_Contents.getContentNames_lastN__API.getProcessedReport_day.xml b/plugins/Contents/tests/System/expected/test_Contents_Contents.getContentNames_lastN__API.getProcessedReport_day.xml index 3626338034..79bb37bba2 100644 --- a/plugins/Contents/tests/System/expected/test_Contents_Contents.getContentNames_lastN__API.getProcessedReport_day.xml +++ b/plugins/Contents/tests/System/expected/test_Contents_Contents.getContentNames_lastN__API.getProcessedReport_day.xml @@ -90,6 +90,5 @@ <nb_visits>16</nb_visits> <nb_impressions>18</nb_impressions> <nb_interactions>6</nb_interactions> - <interaction_rate>33.33%</interaction_rate> </reportTotal> </result>
\ No newline at end of file diff --git a/plugins/Contents/tests/System/expected/test_Contents_Contents.getContentPieces_lastN__API.getProcessedReport_day.xml b/plugins/Contents/tests/System/expected/test_Contents_Contents.getContentPieces_lastN__API.getProcessedReport_day.xml index 06ba5b5797..891b4c4c4e 100644 --- a/plugins/Contents/tests/System/expected/test_Contents_Contents.getContentPieces_lastN__API.getProcessedReport_day.xml +++ b/plugins/Contents/tests/System/expected/test_Contents_Contents.getContentPieces_lastN__API.getProcessedReport_day.xml @@ -133,6 +133,5 @@ <nb_visits>16</nb_visits> <nb_impressions>18</nb_impressions> <nb_interactions>6</nb_interactions> - <interaction_rate>33.33%</interaction_rate> </reportTotal> </result>
\ No newline at end of file |