diff options
author | dizzy <diosmosis@users.noreply.github.com> | 2022-10-10 15:55:38 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-10-10 15:55:38 +0300 |
commit | ff812d1faeab4d7f712289b53883b14a4e6910cb (patch) | |
tree | 4df007d5f4b79c07de9644445635ca04f4a3ffa5 /plugins/CoreAdminHome | |
parent | 3611b1fc8c890dc2428eecf896180a2547e15466 (diff) |
[Vue] remove angularjs from CoreHome and CorePluginsAdmin (#19496)
* get propagation of property to child vue-entry components to work, if strangely
* add missing translations
* remove import added by phpstorm
* try to fix timing error in test
* try removing prefix/suffix entirely from vue entry properties
* fix issues from UI tests
* remove leading hash characters from hash value
* do not attempt to print if puppeteer context is destroyed
* update screenshot
* do not abort ajax requests when loading the sidebar
* revert back to suffixing an underscore
* avoid random failure
* built vue files
* add missing vue-entry property + add missing translations
* fixing UI tests locally
* update screenshots
* update CustomAlerts submodule
* add missing translations
* fix spacing
* couple fixes
* more ui test fixes
* make sure installation umd is loaded during installation (as well as translations)
* couple small UI test fixes
* Fix component name case.
* built vue files
* do not use html_attr to escape and in UI tests replace path with escaped slashes so json data gets replaced
* move UploadPluginDialog to CorePluginsAdmin so it will be available when internet access is not available and the Marketplace plugin is deactivated
* correct typing for feedback question input
* update screenshots
* revert last tweak
* styling tweak
* update screenshots and styling tweak
* fix attribute
* Allow composer plugins for dev dependency codesniffer to fix travis builds.
* keep dependent class and rename
* styling tweaks
* update expected screenshot
* update screenshots
* comma spacing tweak
* update screenshots + fix v-show condition
* some small fixes
* fix styling and formatting issues
* fix spacing issue
* fix property name
* update expected screenshots
* get to load in UI
* getting dashboard settings control to work
* styling tweaks
* fix html attribute output for singlemetricview
* fix vue-entry elements
* update expected screenshot
* fixing UI test issues, reintroduce compileAngularComponents (will remove calls in CoreHome PR)
* move function to correct class
* fix order of array elements
* fixing some more issues
* hide the dashboard manager on initial display as before
* styling fixes
* fix styles for widgetized glossary
* update expected screenshots
* fixing DashboardManager UI test that previously used the uiControlObject property
* update device detection demo to be accurate
* update expected screenshots
* fix race condition in dashboard ajax requests/aborts
* start removing angularjs from CoreHome
* remove more angularjs code
* remove angularjs from CustomDimensions plugin
* removing some angularjs files
* remove use of history service, the use of $location from MatomoUrl and the piwikApi service
* remove angularjs service module and filters
* removing more angularjs references
* remove more angular related code, including getAngularDependency()
* update submodules to vue-remove-angularjs branches
* try replacing angularjs expression parsing w/ mathjs/number
* logical operator fixes
* only import what is needed for math.js
* remove some functionality
* optimize math.js use
* convert zen mode code, add --bail option and some output to vue:build
* remove ng-app directive in twig layouts
* ajaxhelper.adapter.ts still required for vanilla ajaxHelper() object
* remove ng-cloak use
* fix datatableactions.vue errors
* do not propagate id param in vue-entry uses
* remove pointless defer
* get zen mode to work, fix couple issues in headermessage vue-entry usage
* move more data table action icon code to vue component from dataTable.js + fix use of angular in ui test JS override code
* couple more data table actions fixes
* UI test fixes + ng-non-bindable no longer needed
* fix more test issues + update some screenshots
* remove another use of isAngularRenderingThePage
* revert screenshot change
* fixing more issues
* move inline script to vue directive + fix a couple vue warnings
* built vue files
* remove inline script in system check widget
* fix some more datatableactions issues
* use VueEntryContainer in _singleWidget.twig
* remove unused inline script from _donate.twig
* update expected screenshots
* fix hide flat icon code
* updating screenshots and try to fix random failure
* fix numeric conversion
* update expected screenshots
* update screenshots
* use common method to load umd file
* get languages dropdown to work
* only add menu translations if installed
* make sure datatableactions vue entry is completely rendered before initing datatable
* correct enriched-headline selector
* update VisitorGenerator submodule
* do not load menu translations during updater as well
* update expected screenshots
* update screenshot
* update submodule
* update expected screenshot
* update submodule
* remove duplicate translations
* built vue files
* Fix various stuff that came in again through merge
* fix submodule ref
* built vue files
* remove unexpected else in twig template
* fix menu translation check
* readd ajaxhelper
* update some screenshots and fix a merge error
* fix another merge error
* update screenshots and remove ng-cloak from tagmanager page
* fix omnifixture sql
* tests/UI/expected-screenshots/UIIntegrationTest_api_listing.png
* add description column to tagmanager tables missing it in omnifixture dump
* update expected screenshots
* add delta to assert
* update submodule
* update LoginLdap submodule
* update expected screenshot
* update submodule
* reflect reversion made in 4.x-dev for this file
* remove reference to removed file in unit test
* update expected URLs in test
Co-authored-by: sgiehl <stefan@matomo.org>
Co-authored-by: sgiehl <sgiehl@users.noreply.github.com>
Diffstat (limited to 'plugins/CoreAdminHome')
-rw-r--r-- | plugins/CoreAdminHome/CoreAdminHome.php | 2 | ||||
-rw-r--r-- | plugins/CoreAdminHome/Menu.php | 2 |
2 files changed, 1 insertions, 3 deletions
diff --git a/plugins/CoreAdminHome/CoreAdminHome.php b/plugins/CoreAdminHome/CoreAdminHome.php index a80ca1f6a9..e64746eaaf 100644 --- a/plugins/CoreAdminHome/CoreAdminHome.php +++ b/plugins/CoreAdminHome/CoreAdminHome.php @@ -120,7 +120,6 @@ class CoreAdminHome extends \Piwik\Plugin $translationKeys[] = 'CoreAdminHome_ArchivingSettings'; $translationKeys[] = 'General_AllowPiwikArchivingToTriggerBrowser'; $translationKeys[] = 'General_ReportsContainingTodayWillBeProcessedAtMostEvery'; - $translationKeys[] = 'General_SmallTrafficYouCanLeaveDefault'; $translationKeys[] = 'General_ArchivingTriggerDescription'; $translationKeys[] = 'General_ArchivingTriggerSegment'; $translationKeys[] = 'General_SeeTheOfficialDocumentationForMoreInformation'; @@ -196,7 +195,6 @@ class CoreAdminHome extends \Piwik\Plugin $translationKeys[] = 'CoreAdminHome_JSTracking_CampaignKwdParam'; $translationKeys[] = 'SitesManager_EmailInstructionsSubject'; $translationKeys[] = 'SitesManager_JsTrackingTagHelp'; - $translationKeys[] = 'CoreAdminHome_JSTracking_CodeNoteBeforeClosingHeadEmail'; $translationKeys[] = 'CoreAdminHome_JSTrackingIntro3a'; $translationKeys[] = 'CoreAdminHome_JSTrackingIntro4'; $translationKeys[] = 'CoreAdminHome_JSTrackingIntro5'; diff --git a/plugins/CoreAdminHome/Menu.php b/plugins/CoreAdminHome/Menu.php index 36ef25914d..56733632ce 100644 --- a/plugins/CoreAdminHome/Menu.php +++ b/plugins/CoreAdminHome/Menu.php @@ -63,7 +63,7 @@ class Menu extends \Piwik\Plugin\Menu $icon = ($newChangesStatus === ChangesModel::NEW_CHANGES_EXIST ? 'icon-notifications_on' : 'icon-reporting-actions'); $menu->registerMenuIcon('CoreAdminHome_WhatIsNew', $icon); - $menu->addItem('CoreAdminHome_WhatIsNew', null, null, 990, + $menu->addItem('CoreAdminHome_WhatIsNew', null, 'javascript:', 990, Piwik::translate('CoreAdminHome_WhatIsNewTooltip'), $icon, "Piwik_Popover.createPopupAndLoadUrl('module=CoreAdminHome&action=whatIsNew', '". addslashes(Piwik::translate('CoreAdminHome_WhatIsNewTooltip'))."','what-is-new-popup')"); |