diff options
| author | diosmosis <diosmosis@users.noreply.github.com> | 2018-08-09 14:24:16 +0300 |
|---|---|---|
| committer | Matthieu Aubry <mattab@users.noreply.github.com> | 2018-08-09 14:24:16 +0300 |
| commit | 2b77bb4d609dd0ec377a9edc32536f22dd4dabb2 (patch) | |
| tree | 14e38fd0b07b26dbcf50dd2e25793b556d45baa7 /plugins/CoreHome/javascripts | |
| parent | 6112cc2ddf955b9c7183ba767e0a8acce93111ef (diff) | |
Add notification when report w/ segment has no data, but segment is unprocessed (#12823)3.6.0-b4
* When a report has no data, check if it is for an unprocessed segment and display an explanatory notification.
* Remove transient notifications on reporting page change, allow datatable views to add notifications, use to display unprocessed segment message.
* Update changelog.
* Internationalize unprocessed segment message.
* Parse notification divs in dashboardWidget.js when setting widget content.
* Tweak message.
* Change PR to use different approach: throw exception when no archives found and segment is used, then detect exception in new event.
* Update changelog + document new event.
* Unfinished review changes
* more review fixes
* Do not show notification w/ custom segments.
* apply pr review
* Apply review.
* undo escaping since it was not needed & get test to pass
* Different strategy + new test.
* Fix tests.
* Update two expected screenshots.
Diffstat (limited to 'plugins/CoreHome/javascripts')
| -rw-r--r-- | plugins/CoreHome/javascripts/notification_parser.js | 31 |
1 files changed, 0 insertions, 31 deletions
diff --git a/plugins/CoreHome/javascripts/notification_parser.js b/plugins/CoreHome/javascripts/notification_parser.js deleted file mode 100644 index 0747d02373..0000000000 --- a/plugins/CoreHome/javascripts/notification_parser.js +++ /dev/null @@ -1,31 +0,0 @@ -/** - * Piwik - free/libre analytics platform - * - * @link http://piwik.org - * @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later - */ - -$(document).ready((function ($, require) { - return function () { - - var UI = require('piwik/UI'); - - var $notificationNodes = $('[data-role="notification"]'); - - $notificationNodes.each(function (index, notificationNode) { - $notificationNode = $(notificationNode); - var attributes = $notificationNode.data(); - var message = $notificationNode.html(); - - if (message) { - var notification = new UI.Notification(); - attributes.animate = false; - notification.show(message, attributes); - } - - $notificationNodes.remove(); - }); - - } - -})(jQuery, require));
\ No newline at end of file |