Deprecates the `historyService` along with `broadcast.init`, `broadcast.propagateAjax`, `broadcast.pageLoad` (#12363)

* deprecates broadcast.propagateAjax()

* make overlay js independed from history service and some broadcast methods

* deprecates historyService alogn with some broadcast methods

* make popovers work in widgetized dashboard without history service

* do not update overlay page/sidebar when iframe url didn't change

prevents reloading data when opening a popover

1 files changed, 7 insertions, 7 deletions

diff --git a/plugins/CoreHome/javascripts/broadcast.js b/plugins/CoreHome/javascripts/broadcast.js
index db9ff54732..5e392b50dd 100644
--- a/plugins/CoreHome/javascripts/broadcast.js
+++ b/plugins/CoreHome/javascripts/broadcast.js
@@ -52,6 +52,9 @@ var broadcast = {
 
     /**
      * Initializes broadcast object
+     *
+     * @deprecated in 3.2.2, will be removed in Piwik 4
+     *
      * @return {void}
      */
     init: function (noLoadingMessage) {
@@ -78,6 +81,8 @@ var broadcast = {
      *
      * * Note: the method is manipulated in Overlay/javascripts/Piwik_Overlay.js - keep this in mind when making changes.
      *
+     * @deprecated since 3.2.2, will be removed in Piwik 4
+     *
      * @param {string}  hash to load page with
      * @return {void}
      */
@@ -185,7 +190,6 @@ var broadcast = {
     },
 
     /**
-     * ONLY USED BY OVERLAY
      * propagateAjax -- update hash values then make ajax calls.
      *    example :
      *       1) <a href="javascript:broadcast.propagateAjax('module=Referrers&action=getKeywords')">View keywords report</a>
@@ -195,6 +199,8 @@ var broadcast = {
      *
      * NOTE: this method will only make ajax call and replacing main content.
      *
+     * @deprecated in 3.2.2, will be removed in Piwik 4.
+     *
      * @param {string} ajaxUrl  querystring with parameters to be updated
      * @param {boolean} [disableHistory]  the hash change won't be available in the browser history
      * @return {void}
@@ -292,8 +298,6 @@ var broadcast = {
      *         1) We want to update idSite to both search query and hash then reload the page,
      *         2) update period to both search query and hash then reload page.
      *
-     * ** If you'd like to make ajax call with new values then use propagateAjax ** *
-     *
      * Expecting:
      *         str = "param1=newVal1&param2=newVal2";
      *
@@ -442,10 +446,6 @@ var broadcast = {
      *                       handler.
      */
     propagateNewPopoverParameter: function (handlerName, value) {
-        // init broadcast if not already done (it is required to make popovers work in widgetize mode)
-        if (broadcast.isWidgetizedDashboard()) {
-            broadcast.init(true);
-        }
 
         var $location = angular.element(document).injector().get('$location');