Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/matomo-org/matomo.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authordizzy <diosmosis@users.noreply.github.com>2022-05-16 00:24:42 +0300
committerGitHub <noreply@github.com>2022-05-16 00:24:42 +0300
commitd574ba7090b2e3444c1a631d6e14279854961439 (patch)
tree491ca190633c3e7bbe2be04bd152e2e98906be12 /plugins/CoreHome/vue/src
parent0bd72e797bd418dfcf207f76aa00ffb1278bd5ec (diff)
correctly destroy vue entry components in widgetloader (#19216)
Diffstat (limited to 'plugins/CoreHome/vue/src')
-rw-r--r--plugins/CoreHome/vue/src/WidgetLoader/WidgetLoader.vue9
1 files changed, 5 insertions, 4 deletions
diff --git a/plugins/CoreHome/vue/src/WidgetLoader/WidgetLoader.vue b/plugins/CoreHome/vue/src/WidgetLoader/WidgetLoader.vue
index 2d1eeea6a7..7b42c8ab1c 100644
--- a/plugins/CoreHome/vue/src/WidgetLoader/WidgetLoader.vue
+++ b/plugins/CoreHome/vue/src/WidgetLoader/WidgetLoader.vue
@@ -105,7 +105,7 @@ export default defineComponent({
this.loadWidgetUrl(this.widgetParams as QueryParameters, this.changeCounter += 1);
}
},
- unmounted() {
+ beforeUnmount() {
this.cleanupLastWidgetContent();
},
methods: {
@@ -117,12 +117,13 @@ export default defineComponent({
},
cleanupLastWidgetContent() {
const widgetContent = this.$refs.widgetContent as HTMLElement;
- if (widgetContent) {
- widgetContent.innerHTML = '';
- }
+ Matomo.helper.destroyVueComponent(widgetContent);
if (this.currentScope) {
this.currentScope.$destroy();
}
+ if (widgetContent) {
+ widgetContent.innerHTML = '';
+ }
},
getWidgetUrl(parameters?: QueryParameters): QueryParameters {
const urlParams = MatomoUrl.parsed.value;