Use newer version of Puppeteer for UI tests (#17880)

* Use latest version of Puppeteer for UI tests

* use newer node on travis

* test

* use waitForTimeout / waitForSelector instead of waitFor

* Handle BC for removed waitFor method

* Updates expected UI test files

* update submodules

* improve/fix some UI tests

* Updates expected UI test files

* improve/fix some UI tests

* update url-parse dependency

* simplify some UI tests

* update screenshot

* avoid using merged assets that are broken

* fix expected compare exit code

* don't use merged assets for TwoFactorAuth UI tests

it seems due to too many requests to login, logout and other pages merging the CoreJS assets somehow fails, and results in returning an empty file. Even the reload fails to serve the correct content, so maybe the file, the content should be written to, is somehow locked. Disabling the merged assets seems to fix this issue for this tests. Locally the tests are also running correctly with merged assets.

* improve handling of automatic css / js reloading in UI tests

* increase timeouts of TwoFactorAuth UI tests

* fix 2fa ui test

* revert change

* update new screenshot

* updates UI screenshots

* submodule updates

9 files changed, 22 insertions, 22 deletions

diff --git a/plugins/CoreHome/tests/UI/SingleMetricView_spec.js b/plugins/CoreHome/tests/UI/SingleMetricView_spec.js
index 7884bf087e..93b1959894 100644
--- a/plugins/CoreHome/tests/UI/SingleMetricView_spec.js
+++ b/plugins/CoreHome/tests/UI/SingleMetricView_spec.js
@@ -28,7 +28,7 @@ describe('SingleMetricView', function () {
 
         var elem = await page.waitForSelector('#widgetCoreVisualizationssingleMetricViewcolumn');
         await page.waitForNetworkIdle();
-        await page.waitFor(250);
+        await page.waitForTimeout(250);
 
         expect(await elem.screenshot()).to.matchImage('loaded');
     });
@@ -41,7 +41,7 @@ describe('SingleMetricView', function () {
             $('#dashboardWidgetsArea .jqplot-seriespicker-popover label:contains(Revenue)').click();
         });
         await page.waitForNetworkIdle();
-        await page.waitFor(250);
+        await page.waitForTimeout(250);
 
         var elem = await page.waitForSelector('#dashboardWidgetsArea #widgetCoreVisualizationssingleMetricViewcolumn');
         expect(await elem.screenshot()).to.matchImage('formatted_metric');
@@ -51,12 +51,12 @@ describe('SingleMetricView', function () {
         await page.evaluate(function(){
             $('#dashboardWidgetsArea #widgetCoreVisualizationssingleMetricViewcolumn .jqplot-seriespicker').last().trigger('mouseenter');
         });
-        await page.waitFor(250);
+        await page.waitForTimeout(250);
         await page.evaluate(function(){
             $('#dashboardWidgetsArea .jqplot-seriespicker-popover label:contains(_x)').click()
         });
         await page.waitForNetworkIdle();
-        await page.waitFor(250);
+        await page.waitForTimeout(250);
 
         var elem = await page.$('#dashboardWidgetsArea #widgetCoreVisualizationssingleMetricViewcolumn');
         expect(await elem.screenshot()).to.matchImage('goal_metric');
@@ -67,12 +67,12 @@ describe('SingleMetricView', function () {
         await page.evaluate(function(){
             $('#dashboardWidgetsArea #widgetCoreVisualizationssingleMetricViewcolumn .jqplot-seriespicker').trigger('mouseenter');
         });
-        await page.waitFor(250);
+        await page.waitForTimeout(250);
         await page.evaluate(function(){
             $('#dashboardWidgetsArea #widgetCoreVisualizationssingleMetricViewcolumn .jqplot-seriespicker-popover label:contains(Revenue)').click()
         });
         await page.waitForNetworkIdle();
-        await page.waitFor(250);
+        await page.waitForTimeout(250);
 
         var elem = await page.$('#dashboardWidgetsArea #widgetCoreVisualizationssingleMetricViewcolumn');
         expect(await elem.screenshot()).to.matchImage('range');
diff --git a/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_close.png b/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_close.png
index 3d32433f03..1dbdb3ed8f 100644
--- a/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_close.png
+++ b/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_close.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:3ab00ad8715daf05847c359e48ab19e7e82b26f40edd79e1445c0167a59e12a6
-size 5887
+oid sha256:f166fb1cc0d58fc6d8edaacffbb70310d85328353921a8820ab023af6c1875e3
+size 5884
diff --git a/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_close_reload.png b/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_close_reload.png
index 3d32433f03..1dbdb3ed8f 100644
--- a/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_close_reload.png
+++ b/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_close_reload.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:3ab00ad8715daf05847c359e48ab19e7e82b26f40edd79e1445c0167a59e12a6
-size 5887
+oid sha256:f166fb1cc0d58fc6d8edaacffbb70310d85328353921a8820ab023af6c1875e3
+size 5884
diff --git a/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_loaded.png b/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_loaded.png
index fefd4863d1..d955c28822 100644
--- a/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_loaded.png
+++ b/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_loaded.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:003ae9a97b33f35347d699eb03700e0a38bd153b5d58e32e8991a18b590bede0
-size 17049
+oid sha256:79240e5a37b12a4f6f296cac0d2e3c4e7785bb30e14f90c04bbf999797e87e70
+size 17041
diff --git a/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_reloaded.png b/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_reloaded.png
index f063ecc752..667c716495 100644
--- a/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_reloaded.png
+++ b/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_reloaded.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:30518830c1a132dbe2978eae8e5022a9c61f7705121bb1048f37e5283d50c8f4
-size 11767
+oid sha256:eeedebf0a2a1a06debf6d0610db9666999d82e3a90af851fded7016a5b944300
+size 11760
diff --git a/plugins/CoreHome/tests/UI/expected-screenshots/SingleMetricView_formatted_metric.png b/plugins/CoreHome/tests/UI/expected-screenshots/SingleMetricView_formatted_metric.png
index 965c8818ef..26ce8b42b5 100644
--- a/plugins/CoreHome/tests/UI/expected-screenshots/SingleMetricView_formatted_metric.png
+++ b/plugins/CoreHome/tests/UI/expected-screenshots/SingleMetricView_formatted_metric.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:0d1c17811b2347ffac0c2609378c3ccef2bae94b34d638e63db45a228a190caf
-size 6494
+oid sha256:fb9305159cdcbf107a6747b315cba146214a1f73f404c200aa37d6734706ccc2
+size 6485
diff --git a/plugins/CoreHome/tests/UI/expected-screenshots/SingleMetricView_goal_metric.png b/plugins/CoreHome/tests/UI/expected-screenshots/SingleMetricView_goal_metric.png
index 947165fc2e..e6cdfa9a26 100644
--- a/plugins/CoreHome/tests/UI/expected-screenshots/SingleMetricView_goal_metric.png
+++ b/plugins/CoreHome/tests/UI/expected-screenshots/SingleMetricView_goal_metric.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:285156337a075fc6523c05e7b4617472b55be269797a74bfe2c2183a67dc93ef
-size 8956
+oid sha256:33bbb2c1fe617afaf7dc2216e981057698abe7679814ca3d4a729517b7859b33
+size 8952
diff --git a/plugins/CoreHome/tests/UI/expected-screenshots/SingleMetricView_loaded.png b/plugins/CoreHome/tests/UI/expected-screenshots/SingleMetricView_loaded.png
index c3a8d28729..9dcc86fc15 100644
--- a/plugins/CoreHome/tests/UI/expected-screenshots/SingleMetricView_loaded.png
+++ b/plugins/CoreHome/tests/UI/expected-screenshots/SingleMetricView_loaded.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:37d9eb86e57ebdcdaf5a0ab5faeb7ee6a71de6b2d7a7576d451b0fb823325155
-size 4753
+oid sha256:da10b7861b5b8208164116aebb716bb8d6028701544c7430bf172d9b328fbe74
+size 4741
diff --git a/plugins/CoreHome/tests/UI/expected-screenshots/SingleMetricView_range.png b/plugins/CoreHome/tests/UI/expected-screenshots/SingleMetricView_range.png
index 08ec15bc4f..5cb9e50b39 100644
--- a/plugins/CoreHome/tests/UI/expected-screenshots/SingleMetricView_range.png
+++ b/plugins/CoreHome/tests/UI/expected-screenshots/SingleMetricView_range.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:3aa84abbc6d84620b272ed3db58367463ed27f7f2e6cda1ef10f19bad2e5833d
-size 5016
+oid sha256:b4bc0c7c4e99fd8d622f86462379886fb124959392c19487c36829525f51944d
+size 5019