diff options
| author | Thomas Steur <tsteur@users.noreply.github.com> | 2018-12-26 02:32:05 +0300 |
|---|---|---|
| committer | diosmosis <diosmosis@users.noreply.github.com> | 2018-12-26 02:32:05 +0300 |
| commit | 5f28571535178851fc42f7f9c07655875b7e994f (patch) | |
| tree | 5e1754745d4a3e21bac3940f2a0f22966f5699f6 /plugins/CoreVisualizations | |
| parent | 08d623c7ee5b67d779454f179bfacc71a295ab73 (diff) | |
Do not fetch totals for insights (#13891)
* Do not fetch totals for insights
Got this error warning
> WARNING: Trying to add two strings in DataTable\Row::sumRowArray: 35.8% + 48.6% for row # ['label' => -2, 'nb_visits' => 379, 'growth_percent' => '35.8%', 'growth_percent_numeric' => '35.8', 'grown' => 1, 'value_old' => 162, 'value_new' => 220, 'difference' => 58, 'importance' => 58, 'isDisappeared' => , 'isNew' => , 'isMover' => 1] [] [idsubtable = ]<br />
* also do not fetch totals for movers and shakers
* Update Model.php
* by default fetch totals only when html tables are requested
* ensure to not fetch totals for any other visualisation but htmltable
* update doc
Diffstat (limited to 'plugins/CoreVisualizations')
| -rw-r--r-- | plugins/CoreVisualizations/Visualizations/HtmlTable/Config.php | 2 | ||||
| -rw-r--r-- | plugins/CoreVisualizations/Visualizations/HtmlTable/RequestConfig.php | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/plugins/CoreVisualizations/Visualizations/HtmlTable/Config.php b/plugins/CoreVisualizations/Visualizations/HtmlTable/Config.php index 266a71e1b4..ba39a66c0f 100644 --- a/plugins/CoreVisualizations/Visualizations/HtmlTable/Config.php +++ b/plugins/CoreVisualizations/Visualizations/HtmlTable/Config.php @@ -88,7 +88,7 @@ class Config extends VisualizationConfig public $highlight_summary_row = false; /** - * If true, the totals row will be hidden + * If true, the totals row will be shown * * Default value: false */ diff --git a/plugins/CoreVisualizations/Visualizations/HtmlTable/RequestConfig.php b/plugins/CoreVisualizations/Visualizations/HtmlTable/RequestConfig.php index 696569c618..dde538219c 100644 --- a/plugins/CoreVisualizations/Visualizations/HtmlTable/RequestConfig.php +++ b/plugins/CoreVisualizations/Visualizations/HtmlTable/RequestConfig.php @@ -38,6 +38,7 @@ class RequestConfig extends VisualizationRequestConfig public function __construct() { + $this->totals = true; $this->filter_limit = PiwikConfig::getInstance()->General['datatable_default_limit']; if (Common::getRequestVar('enable_filter_excludelowpop', false) == '1') { |