Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/matomo-org/matomo.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authordiosmosis <diosmosis@users.noreply.github.com>2019-09-30 21:53:43 +0300
committerGitHub <noreply@github.com>2019-09-30 21:53:43 +0300
commit779d992038a912f8d1fd9c0eba042f58c8056bc9 (patch)
treeaeab46f7ec661003993ab225c90edab3eb3d6dfc /plugins/CoreVisualizations
parent3f26e785f015d30d0aeea66aaf7484111b0dbfa9 (diff)
Comparison tweaks (#14923)
* Do not display limit control when comparing. * Only show separate dimensions if supposed to in comparison view.
Diffstat (limited to 'plugins/CoreVisualizations')
-rw-r--r--plugins/CoreVisualizations/Visualizations/JqplotGraph/Evolution.php2
-rw-r--r--plugins/CoreVisualizations/templates/_dataTableViz_htmlTable_comparisons.twig2
2 files changed, 3 insertions, 1 deletions
diff --git a/plugins/CoreVisualizations/Visualizations/JqplotGraph/Evolution.php b/plugins/CoreVisualizations/Visualizations/JqplotGraph/Evolution.php
index 337bb233b2..2082700c88 100644
--- a/plugins/CoreVisualizations/Visualizations/JqplotGraph/Evolution.php
+++ b/plugins/CoreVisualizations/Visualizations/JqplotGraph/Evolution.php
@@ -62,6 +62,8 @@ class Evolution extends JqplotGraph
$this->config->custom_parameters['columns'] = $this->config->columns_to_display;
if ($this->isComparing()) {
+ $this->config->show_limit_control = false; // since we always show the days over the period, there's no point in changing the limit
+
$requestArray = $this->request->getRequestArray();
$requestArray = ApiRequest::getRequestArrayFromString($requestArray);
diff --git a/plugins/CoreVisualizations/templates/_dataTableViz_htmlTable_comparisons.twig b/plugins/CoreVisualizations/templates/_dataTableViz_htmlTable_comparisons.twig
index fec4652ed4..2a5852b21f 100644
--- a/plugins/CoreVisualizations/templates/_dataTableViz_htmlTable_comparisons.twig
+++ b/plugins/CoreVisualizations/templates/_dataTableViz_htmlTable_comparisons.twig
@@ -42,7 +42,7 @@
<span class="label">{{ comparisonLabel }}</span>
</td>
{% for dimension in dimensions %}
- {% if loop.index0 != 0 %}
+ {% if loop.index0 != 0 and dimension in properties.columns_to_display %}
<td class="label">
&nbsp;
</td>