Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/matomo-org/matomo.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Steur <tsteur@users.noreply.github.com>2021-06-30 08:07:26 +0300
committerGitHub <noreply@github.com>2021-06-30 08:07:26 +0300
commit264407f37b47e8517d4129c89bc0e86ecd41217c (patch)
treeaca08d645ecdd4e6800e1af0c38ddb3472b65b35 /plugins/CoreVisualizations
parent75568c7ba6b624f983e3362184d33a01339aa001 (diff)
Fix few bugs in sparklines visualisation when there is no row (#17728)
* Fix few bugs in sparklines visualisation when there is no row * add UI test * fix test * fix test
Diffstat (limited to 'plugins/CoreVisualizations')
-rw-r--r--plugins/CoreVisualizations/Visualizations/Sparklines.php13
1 files changed, 10 insertions, 3 deletions
diff --git a/plugins/CoreVisualizations/Visualizations/Sparklines.php b/plugins/CoreVisualizations/Visualizations/Sparklines.php
index 93ce45aa1a..d4f471a6ae 100644
--- a/plugins/CoreVisualizations/Visualizations/Sparklines.php
+++ b/plugins/CoreVisualizations/Visualizations/Sparklines.php
@@ -122,7 +122,11 @@ class Sparklines extends ViewDataTable
}
$firstRow = $data->getFirstRow();
- $comparisons = $firstRow->getComparisons();
+ if ($firstRow) {
+ $comparisons = $firstRow->getComparisons();
+ } else {
+ $comparisons = null;
+ }
$originalDate = Common::getRequestVar('date');
$originalPeriod = Common::getRequestVar('period');
@@ -257,7 +261,7 @@ class Sparklines extends ViewDataTable
$table->applyQueuedFilters();
}
- private function getValuesAndDescriptions(DataTable\Row $firstRow, $columns, $evolutionColumnNameSuffix = null)
+ private function getValuesAndDescriptions($firstRow, $columns, $evolutionColumnNameSuffix = null)
{
if (!is_array($columns)) {
$columns = array($columns);
@@ -270,7 +274,10 @@ class Sparklines extends ViewDataTable
$evolutions = [];
foreach ($columns as $col) {
- $value = $firstRow->getColumn($col);
+ $value = 0;
+ if ($firstRow) {
+ $value = $firstRow->getColumn($col);
+ }
if ($value === false) {
$value = 0;