diff options
| author | Stefan Giehl <stefan@matomo.org> | 2022-07-25 12:07:06 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-07-25 12:07:06 +0300 |
| commit | eeb20ec4eb3ad3d0ac5c4ec952852cdde3ffad38 (patch) | |
| tree | 495b1f1dfe5c6e84f1ab4e2a84a54bb2000836ea /plugins/CustomDimensions | |
| parent | 6cc723685d3c1c9b399b09e9b691b9f2dba80bce (diff) | |
Fix sizing of subtables with different column count (#19540)
* Don't try to align column width of subtables where column count differs from base table
* Improve fix and avoid table resizes when not needed
* fix tests
* updates expected test files
* [TEMP] submodule update
* add some comments
Diffstat (limited to 'plugins/CustomDimensions')
| -rw-r--r-- | plugins/CustomDimensions/tests/UI/CustomDimensions_spec.js | 3 | ||||
| -rw-r--r-- | plugins/CustomDimensions/tests/UI/expected-screenshots/CustomDimensions_report_action_subtable.png | 4 |
2 files changed, 2 insertions, 5 deletions
diff --git a/plugins/CustomDimensions/tests/UI/CustomDimensions_spec.js b/plugins/CustomDimensions/tests/UI/CustomDimensions_spec.js index 8aacff253d..cc62dc4df5 100644 --- a/plugins/CustomDimensions/tests/UI/CustomDimensions_spec.js +++ b/plugins/CustomDimensions/tests/UI/CustomDimensions_spec.js @@ -148,9 +148,6 @@ describe("CustomDimensions", function () { await (await page.jQuery('.dataTable .subDataTable .value:contains(en):first')).click(); await page.waitForNetworkIdle(); await page.waitForTimeout(500); - await page.evaluate(() => { // give table headers constant width so the screenshot stays the same - $('.dataTableScroller').css('overflow-x', 'scroll'); - }); await (await page.jQuery('td.label:contains(en_US)')).hover(); await page.waitForTimeout(100); }); diff --git a/plugins/CustomDimensions/tests/UI/expected-screenshots/CustomDimensions_report_action_subtable.png b/plugins/CustomDimensions/tests/UI/expected-screenshots/CustomDimensions_report_action_subtable.png index 7f45f7585f..a4dd470c6b 100644 --- a/plugins/CustomDimensions/tests/UI/expected-screenshots/CustomDimensions_report_action_subtable.png +++ b/plugins/CustomDimensions/tests/UI/expected-screenshots/CustomDimensions_report_action_subtable.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:3199444d356aa049d3c351d03d43d94fc3146095a353f37faf1c2266a07e9254 -size 55690 +oid sha256:42d192b4ea98d5a6c6e5cb3291bf2eea2bd886a74b9214c6aa534971b1a3f103 +size 54885 |
