diff options
| author | mattpiwik <matthieu.aubry@gmail.com> | 2011-09-27 11:20:45 +0400 |
|---|---|---|
| committer | mattpiwik <matthieu.aubry@gmail.com> | 2011-09-27 11:20:45 +0400 |
| commit | c91c513e983e051648b69d9b545ade0ba60fd9f7 (patch) | |
| tree | cfc3456035075694078b4e9a388079b9f3392124 /plugins/CustomVariables/Controller.php | |
| parent | 88b0320bd73aa6afb86bc6f55a837306ca467556 (diff) | |
Fixes #2667
* Stop aggregating visits for Custom variables of scope "page"
* still OK for scope "visit" since there is supposed to be one custom var value per custom variable name for a given visit
* Now we always display the Actions columns so that these rows with no visit still show the number of Actions
* cleaned up from custom var output report, removed some "price_viewed" column left out
UI Change (future FAQ maybe...)
* When there is a "Visits" column for the Custom Variable report with a value of "-" (hyphen) then it means this custom variable was used with scope=page.
Fixes #2662
* Added integration tests testing getPageUrl with multiple periods and websites
* fixed a bug when idSite=all or 1,2,3
git-svn-id: http://dev.piwik.org/svn/trunk@5235 59fd770c-687e-43c8-a1e3-f5a4ff64c105
Diffstat (limited to 'plugins/CustomVariables/Controller.php')
| -rw-r--r-- | plugins/CustomVariables/Controller.php | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/plugins/CustomVariables/Controller.php b/plugins/CustomVariables/Controller.php index c12b7df640..83f206ae02 100644 --- a/plugins/CustomVariables/Controller.php +++ b/plugins/CustomVariables/Controller.php @@ -32,7 +32,7 @@ class Piwik_CustomVariables_Controller extends Piwik_Controller $this->setPeriodVariablesView($view); $view->enableShowGoals(); - $view->setColumnsToDisplay( array('label','nb_visits') ); + $view->setColumnsToDisplay( array('label','nb_visits', 'nb_actions') ); $view->setColumnTranslation('label', Piwik_Translate('CustomVariables_ColumnCustomVariableName')); $view->setSortedColumn( 'nb_visits' ); $view->setLimit( 10 ); @@ -46,8 +46,9 @@ class Piwik_CustomVariables_Controller extends Piwik_Controller $view->init( $this->pluginName, __FUNCTION__, 'CustomVariables.getCustomVariablesValuesFromNameId' ); $view->disableSearchBox(); + $view->enableShowGoals(); $view->disableExcludeLowPopulation(); - $view->setColumnsToDisplay( array('label','nb_visits') ); + $view->setColumnsToDisplay( array('label','nb_visits', 'nb_actions') ); $view->setColumnTranslation('label', Piwik_Translate('CustomVariables_ColumnCustomVariableValue')); return $this->renderView($view, $fetch); |