All icons in own repo and included as a submodule (#11548)

* add icons submodule

* replace path

* change submodule url

* fix JSONTest

* fix integration tests

* update icon submodules

* fix preg_match

* fix remaining system tests

* better match for non dist icon files

* fix .gitmodules

* update icon submodule

* Fixed custom dimension test

* Do not completely fail when GD not enabled

* Fix http test + refactor checklist

* Refactored the code into a method

* Changed icon path refs https://github.com/piwik/piwik/pull/11383

* System tests

* Update valid UI tests

* Fix integration test

11 files changed, 1 insertions, 1 deletions

diff --git a/plugins/DevicePlugins/functions.php b/plugins/DevicePlugins/functions.php
index ad27e67b72..30a6cf504b 100644
--- a/plugins/DevicePlugins/functions.php
+++ b/plugins/DevicePlugins/functions.php
@@ -16,5 +16,5 @@ function getPluginsLogo($label)
     if ($label == Piwik::translate('General_Others')) {
         return false;
     }
-    return 'plugins/DevicePlugins/images/plugins/' . $label . '.png';
+    return 'plugins/Morpheus/icons/dist/plugins/' . $label . '.png';
 }
diff --git a/plugins/DevicePlugins/images/plugins/cookie.png b/plugins/DevicePlugins/images/plugins/cookie.png
deleted file mode 100644
index 6a2c66726b..0000000000
--- a/plugins/DevicePlugins/images/plugins/cookie.png
+++ /dev/null
diff --git a/plugins/DevicePlugins/images/plugins/director.png b/plugins/DevicePlugins/images/plugins/director.png
deleted file mode 100644
index 529b54402c..0000000000
--- a/plugins/DevicePlugins/images/plugins/director.png
+++ /dev/null
diff --git a/plugins/DevicePlugins/images/plugins/flash.png b/plugins/DevicePlugins/images/plugins/flash.png
deleted file mode 100644
index 3c10ce920c..0000000000
--- a/plugins/DevicePlugins/images/plugins/flash.png
+++ /dev/null
diff --git a/plugins/DevicePlugins/images/plugins/gears.png b/plugins/DevicePlugins/images/plugins/gears.png
deleted file mode 100644
index bcd3a408c0..0000000000
--- a/plugins/DevicePlugins/images/plugins/gears.png
+++ /dev/null
diff --git a/plugins/DevicePlugins/images/plugins/java.png b/plugins/DevicePlugins/images/plugins/java.png
deleted file mode 100644
index ab07c395ed..0000000000
--- a/plugins/DevicePlugins/images/plugins/java.png
+++ /dev/null
diff --git a/plugins/DevicePlugins/images/plugins/pdf.png b/plugins/DevicePlugins/images/plugins/pdf.png
deleted file mode 100644
index b3e5f6a5b0..0000000000
--- a/plugins/DevicePlugins/images/plugins/pdf.png
+++ /dev/null
diff --git a/plugins/DevicePlugins/images/plugins/quicktime.png b/plugins/DevicePlugins/images/plugins/quicktime.png
deleted file mode 100644
index 2b2b1f5a2b..0000000000
--- a/plugins/DevicePlugins/images/plugins/quicktime.png
+++ /dev/null
diff --git a/plugins/DevicePlugins/images/plugins/realplayer.png b/plugins/DevicePlugins/images/plugins/realplayer.png
deleted file mode 100644
index 26b2695e35..0000000000
--- a/plugins/DevicePlugins/images/plugins/realplayer.png
+++ /dev/null
diff --git a/plugins/DevicePlugins/images/plugins/silverlight.png b/plugins/DevicePlugins/images/plugins/silverlight.png
deleted file mode 100644
index 148279faf4..0000000000
--- a/plugins/DevicePlugins/images/plugins/silverlight.png
+++ /dev/null
diff --git a/plugins/DevicePlugins/images/plugins/windowsmedia.png b/plugins/DevicePlugins/images/plugins/windowsmedia.png
deleted file mode 100644
index b066b614a2..0000000000
--- a/plugins/DevicePlugins/images/plugins/windowsmedia.png
+++ /dev/null