diff options
| author | Stefan Giehl <stefan@matomo.org> | 2021-05-27 04:58:30 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-27 04:58:30 +0300 |
| commit | c973567705a0065fdd7d7c7b11b80f1f0f1be350 (patch) | |
| tree | 89947dbce864ac48389c742fce31d30106eebada /plugins/DevicesDetection | |
| parent | 70b05de003487a31495bb9927017606a2faab7dd (diff) | |
Update PHP extension requirements & deprecate Common::mb_* methods (#16754)
* Require polyfill for mbstring and iconv
* remove mbstring methods from upgrade.php
* remove checks for some php extensions
* deprecate Common::mb_* methods, as we can directly use mb_* functions instead
* updates expected test files
* Directly use mb_* methods in favor of Common::mb_*
* Update expected screenshot
Co-authored-by: diosmosis <diosmosis@users.noreply.github.com>
Diffstat (limited to 'plugins/DevicesDetection')
| -rw-r--r-- | plugins/DevicesDetection/Columns/BrowserName.php | 4 | ||||
| -rw-r--r-- | plugins/DevicesDetection/Columns/Os.php | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/plugins/DevicesDetection/Columns/BrowserName.php b/plugins/DevicesDetection/Columns/BrowserName.php index 74ded90e01..fa997d6f84 100644 --- a/plugins/DevicesDetection/Columns/BrowserName.php +++ b/plugins/DevicesDetection/Columns/BrowserName.php @@ -41,9 +41,9 @@ class BrowserName extends Base $segment->setSqlFilterValue(function ($val) { $browsers = Browser::getAvailableBrowsers(); $browsers = array_map(function($val) { - return Common::mb_strtolower($val); + return mb_strtolower($val); }, $browsers); - $result = array_search(Common::mb_strtolower($val), $browsers); + $result = array_search(mb_strtolower($val), $browsers); if ($result === false) { $result = 'UNK'; diff --git a/plugins/DevicesDetection/Columns/Os.php b/plugins/DevicesDetection/Columns/Os.php index f5ba2bf36d..80ef344194 100644 --- a/plugins/DevicesDetection/Columns/Os.php +++ b/plugins/DevicesDetection/Columns/Os.php @@ -43,9 +43,9 @@ class Os extends Base $segment->setSqlFilterValue(function ($val) { $oss = OperatingSystem::getAvailableOperatingSystems(); $oss = array_map(function($val) { - return Common::mb_strtolower($val); + return mb_strtolower($val); }, $oss); - $result = array_search(Common::mb_strtolower($val), $oss); + $result = array_search(mb_strtolower($val), $oss); if ($result === false) { $result = 'UNK'; |