diff options
| author | Christian Schmidt <github@chsc.dk> | 2018-07-25 22:47:29 +0300 |
|---|---|---|
| committer | diosmosis <diosmosis@users.noreply.github.com> | 2018-07-25 22:47:29 +0300 |
| commit | e09383ebeedd6b6f8dee8b57373027b00e6203b5 (patch) | |
| tree | 3d0faed73ba8629a52a000147b99396239cdd0ba /plugins/Diagnostics | |
| parent | ef9c48cc48587776107b1500dc14eef3ffa19154 (diff) | |
Replace proxy redirect with rel=noreferrer (#12780)
* Replace proxy redirect with rel=noreferrer
* Add noopener
* Restore action=redirect for non-Matomo links
* Wrap referring URLs
* NO target on download link
* Fix Github links
* Fix whitespace
* Fix tests
* Revert change
* Revert changes
* Fix tests
* Add noreferrer shim for MSIE 10
* Remove all action=redirect links
* Restore noreferrer
* Restore test
* Fix one more occurrence
* Update changelog
* Combine if's
* Fix changelog wording
* Fix stray whitespace
Diffstat (limited to 'plugins/Diagnostics')
| -rw-r--r-- | plugins/Diagnostics/Diagnostic/DbOverSSLCheck.php | 2 | ||||
| -rw-r--r-- | plugins/Diagnostics/Diagnostic/LoadDataInfileCheck.php | 2 | ||||
| -rw-r--r-- | plugins/Diagnostics/Diagnostic/TimezoneCheck.php | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/plugins/Diagnostics/Diagnostic/DbOverSSLCheck.php b/plugins/Diagnostics/Diagnostic/DbOverSSLCheck.php index 07b8942da5..2a63437d76 100644 --- a/plugins/Diagnostics/Diagnostic/DbOverSSLCheck.php +++ b/plugins/Diagnostics/Diagnostic/DbOverSSLCheck.php @@ -55,7 +55,7 @@ class DbOverSSLCheck implements Diagnostic } } - $comment .= '<br />' . '<a target="_blank" href="?module=Proxy&action=redirect&url=http://piwik.org/faq/"> FAQ on piwik.org</a>'; + $comment .= '<br />' . '<a target="_blank" rel="noreferrer noopener" href="https://matomo.org/faq/"> FAQ on matomo.org</a>'; return array(DiagnosticResult::singleResult($label, DiagnosticResult::STATUS_WARNING, $comment)); } diff --git a/plugins/Diagnostics/Diagnostic/LoadDataInfileCheck.php b/plugins/Diagnostics/Diagnostic/LoadDataInfileCheck.php index 1064cf9d3d..b8725b35a2 100644 --- a/plugins/Diagnostics/Diagnostic/LoadDataInfileCheck.php +++ b/plugins/Diagnostics/Diagnostic/LoadDataInfileCheck.php @@ -78,7 +78,7 @@ class LoadDataInfileCheck implements Diagnostic '<br/><strong>%s:</strong> %s<br/>%s', $this->translator->translate('General_Error'), $errorMessage, - 'Troubleshooting: <a target="_blank" href="?module=Proxy&action=redirect&url=https://matomo.org/faq/troubleshooting/%23faq_194">FAQ on matomo.org</a>' + 'Troubleshooting: <a target="_blank" rel="noreferrer noopener" href="https://matomo.org/faq/troubleshooting/#faq_194">FAQ on matomo.org</a>' ); } diff --git a/plugins/Diagnostics/Diagnostic/TimezoneCheck.php b/plugins/Diagnostics/Diagnostic/TimezoneCheck.php index 60ca8b44d8..5fcf6204bc 100644 --- a/plugins/Diagnostics/Diagnostic/TimezoneCheck.php +++ b/plugins/Diagnostics/Diagnostic/TimezoneCheck.php @@ -37,7 +37,7 @@ class TimezoneCheck implements Diagnostic $comment = sprintf( '%s<br />%s.', $this->translator->translate('SitesManager_AdvancedTimezoneSupportNotFound'), - '<a href="http://php.net/manual/en/datetime.installation.php" rel="noreferrer" target="_blank">Timezone PHP documentation</a>' + '<a href="http://php.net/manual/en/datetime.installation.php" rel="noreferrer noopener" target="_blank">Timezone PHP documentation</a>' ); return array(DiagnosticResult::singleResult($label, DiagnosticResult::STATUS_WARNING, $comment)); |