diff options
| author | Stefan Giehl <stefan@matomo.org> | 2019-03-05 00:10:06 +0300 |
|---|---|---|
| committer | diosmosis <diosmosis@users.noreply.github.com> | 2019-03-05 00:10:06 +0300 |
| commit | 3ba0e38ffe5d45561d5dff541652a95c25a88dec (patch) | |
| tree | 8f73353c1c82e49506e195b15e3baf43fb07ef98 /plugins/Ecommerce | |
| parent | 283ec8d650d25d6f7577c13108a69d98367fc486 (diff) | |
Improve total report values calculation (#14158)
* Ensure summed up values are numeric
to prevent a `A non well formed numeric value encountered` on PHP 7.x
* Do not calculate total values for average, rate or nested metrics
* Fix calculation for minimal or maximal metrics
* updates expected test files
* Also skip evolution metrics
* skip all non numeric values
* update test file
* calculate totals for nested metrics recursivly
* update test files
Diffstat (limited to 'plugins/Ecommerce')
4 files changed, 0 insertions, 12 deletions
diff --git a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems_Metadata_ItemsCategory__API.getProcessedReport_day.xml b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems_Metadata_ItemsCategory__API.getProcessedReport_day.xml index 4937b4866b..9aa49fb80e 100644 --- a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems_Metadata_ItemsCategory__API.getProcessedReport_day.xml +++ b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems_Metadata_ItemsCategory__API.getProcessedReport_day.xml @@ -115,8 +115,5 @@ <nb_uniq_visitors>8</nb_uniq_visitors> <nb_visits>12</nb_visits> <nb_actions>17</nb_actions> - <avg_price>513.9</avg_price> - <avg_quantity>2.3</avg_quantity> - <conversion_rate>66.67%</conversion_rate> </reportTotal> </result>
\ No newline at end of file diff --git a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems_Metadata_ItemsSku__API.getProcessedReport_day.xml b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems_Metadata_ItemsSku__API.getProcessedReport_day.xml index 25b5f5768c..95cb97cc08 100644 --- a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems_Metadata_ItemsSku__API.getProcessedReport_day.xml +++ b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems_Metadata_ItemsSku__API.getProcessedReport_day.xml @@ -85,8 +85,5 @@ <nb_uniq_visitors>3</nb_uniq_visitors> <nb_visits>6</nb_visits> <nb_actions>11</nb_actions> - <avg_price>527.81</avg_price> - <avg_quantity>2.5</avg_quantity> - <conversion_rate>66.67%</conversion_rate> </reportTotal> </result>
\ No newline at end of file diff --git a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems_Metadata_VisitTime.getVisitInformationPerServerTime__API.getProcessedReport_day.xml b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems_Metadata_VisitTime.getVisitInformationPerServerTime__API.getProcessedReport_day.xml index 80b7001673..d7200c572d 100644 --- a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems_Metadata_VisitTime.getVisitInformationPerServerTime__API.getProcessedReport_day.xml +++ b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems_Metadata_VisitTime.getVisitInformationPerServerTime__API.getProcessedReport_day.xml @@ -427,9 +427,6 @@ <nb_conversions>3</nb_conversions> <revenue>3121.11</revenue> <nb_visits_converted>1</nb_visits_converted> - <conversion_rate>33.33%</conversion_rate> <nb_actions_per_visit>4.3</nb_actions_per_visit> - <avg_time_on_site>1801</avg_time_on_site> - <bounce_rate>0%</bounce_rate> </reportTotal> </result>
\ No newline at end of file diff --git a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__API.getProcessedReport_day.xml b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__API.getProcessedReport_day.xml index 5cdd1dbbc3..fed58709d5 100644 --- a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__API.getProcessedReport_day.xml +++ b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__API.getProcessedReport_day.xml @@ -119,9 +119,6 @@ </goals> <nb_conversions>3</nb_conversions> <revenue>3121.11</revenue> - <conversion_rate>0%</conversion_rate> <nb_actions_per_visit>4.3</nb_actions_per_visit> - <avg_time_on_site>1801</avg_time_on_site> - <bounce_rate>0%</bounce_rate> </reportTotal> </result>
\ No newline at end of file |