diff options
| author | diosmosis <diosmosis@users.noreply.github.com> | 2019-07-16 07:33:25 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-07-16 07:33:25 +0300 |
| commit | e4c1f1f92114ca03947e9932935e4b4195ae1604 (patch) | |
| tree | 86d3f38165ee87eb4c7f8a36dc8bdb779c04fb22 /plugins/Ecommerce | |
| parent | 75c4c9d3a8be5b9d035f086c3b2edb45afaed61a (diff) | |
Keep top level nb_visits_converted metric (#14253)
* Do not remove nb_visits_converted when archiving goal reports since it should differ from sum of conversions.
* If metric is not available, compute dynamically by using max nb_visits_converted.
* Ignore abandoned cart conversions when calculating visit converted.
* In case goals column is empty.
* remove processed metric code since it is not correct
* do not remove visits converted metric for overview
* fix tests
* Fixing test
* fix test
* update test files
* update submodules
* Update expected screenshots & try to fix some random failures.
* Update expected UI test export results.
* two ui test fixes
* Fix couple UI test failures.
* fix random php test failure
Diffstat (limited to 'plugins/Ecommerce')
8 files changed, 15 insertions, 1 deletions
diff --git a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems_Metadata_VisitTime.getVisitInformationPerServerTime__API.getProcessedReport_day.xml b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems_Metadata_VisitTime.getVisitInformationPerServerTime__API.getProcessedReport_day.xml index d57b0e817b..3dfafacaae 100644 --- a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems_Metadata_VisitTime.getVisitInformationPerServerTime__API.getProcessedReport_day.xml +++ b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems_Metadata_VisitTime.getVisitInformationPerServerTime__API.getProcessedReport_day.xml @@ -401,6 +401,7 @@ <max_actions>6</max_actions> <sum_visit_length>5403</sum_visit_length> <bounce_count>0</bounce_count> + <nb_visits_converted>2</nb_visits_converted> <goals> <row idgoal="1"> <nb_conversions>1</nb_conversions> @@ -426,7 +427,6 @@ </goals> <nb_conversions>3</nb_conversions> <revenue>3121.11</revenue> - <nb_visits_converted>1</nb_visits_converted> <nb_actions_per_visit>4.3</nb_actions_per_visit> </reportTotal> </result>
\ No newline at end of file diff --git a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__API.getProcessedReport_day.xml b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__API.getProcessedReport_day.xml index 143bd8df41..31f3f57891 100644 --- a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__API.getProcessedReport_day.xml +++ b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__API.getProcessedReport_day.xml @@ -94,6 +94,7 @@ <max_actions>6</max_actions> <sum_visit_length>5403</sum_visit_length> <bounce_count>0</bounce_count> + <nb_visits_converted>2</nb_visits_converted> <goals> <row idgoal="1"> <nb_conversions>1</nb_conversions> diff --git a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__CustomVariables.getCustomVariables_day.xml b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__CustomVariables.getCustomVariables_day.xml index f4c932cd2c..f12f1fc15e 100644 --- a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__CustomVariables.getCustomVariables_day.xml +++ b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__CustomVariables.getCustomVariables_day.xml @@ -8,6 +8,7 @@ <max_actions>6</max_actions> <sum_visit_length>5403</sum_visit_length> <bounce_count>0</bounce_count> + <nb_visits_converted>2</nb_visits_converted> <goals> <row idgoal='ecommerceAbandonedCart'> <nb_conversions>2</nb_conversions> @@ -49,6 +50,7 @@ <max_actions>6</max_actions> <sum_visit_length>5403</sum_visit_length> <bounce_count>0</bounce_count> + <nb_visits_converted>2</nb_visits_converted> <goals> <row idgoal='ecommerceAbandonedCart'> <nb_conversions>2</nb_conversions> @@ -85,6 +87,7 @@ <max_actions>6</max_actions> <sum_visit_length>5403</sum_visit_length> <bounce_count>0</bounce_count> + <nb_visits_converted>2</nb_visits_converted> <goals> <row idgoal='ecommerceAbandonedCart'> <nb_conversions>2</nb_conversions> @@ -126,6 +129,7 @@ <max_actions>6</max_actions> <sum_visit_length>5403</sum_visit_length> <bounce_count>0</bounce_count> + <nb_visits_converted>2</nb_visits_converted> <goals> <row idgoal='ecommerceAbandonedCart'> <nb_conversions>2</nb_conversions> @@ -280,6 +284,7 @@ <max_actions>6</max_actions> <sum_visit_length>4682</sum_visit_length> <bounce_count>0</bounce_count> + <nb_visits_converted>1</nb_visits_converted> <goals> <row idgoal='ecommerceAbandonedCart'> <nb_conversions>2</nb_conversions> @@ -316,6 +321,7 @@ <max_actions>6</max_actions> <sum_visit_length>4682</sum_visit_length> <bounce_count>0</bounce_count> + <nb_visits_converted>1</nb_visits_converted> <goals> <row idgoal='ecommerceAbandonedCart'> <nb_conversions>2</nb_conversions> diff --git a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__UserCountry.getCity_day.xml b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__UserCountry.getCity_day.xml index 1fbd1b3ea7..32f87f8b98 100644 --- a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__UserCountry.getCity_day.xml +++ b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__UserCountry.getCity_day.xml @@ -9,6 +9,7 @@ <max_actions>6</max_actions> <sum_visit_length>5403</sum_visit_length> <bounce_count>0</bounce_count> + <nb_visits_converted>2</nb_visits_converted> <goals> <row idgoal='ecommerceAbandonedCart'> <nb_conversions>2</nb_conversions> diff --git a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__UserCountry.getContinent_day.xml b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__UserCountry.getContinent_day.xml index a05ce1df11..9133dc0229 100644 --- a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__UserCountry.getContinent_day.xml +++ b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__UserCountry.getContinent_day.xml @@ -9,6 +9,7 @@ <max_actions>6</max_actions> <sum_visit_length>5403</sum_visit_length> <bounce_count>0</bounce_count> + <nb_visits_converted>2</nb_visits_converted> <goals> <row idgoal='1'> <nb_conversions>1</nb_conversions> diff --git a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__UserCountry.getCountry_day.xml b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__UserCountry.getCountry_day.xml index c30519b3db..f645a7e3c8 100644 --- a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__UserCountry.getCountry_day.xml +++ b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__UserCountry.getCountry_day.xml @@ -9,6 +9,7 @@ <max_actions>6</max_actions> <sum_visit_length>4682</sum_visit_length> <bounce_count>0</bounce_count> + <nb_visits_converted>1</nb_visits_converted> <goals> <row idgoal='ecommerceAbandonedCart'> <nb_conversions>2</nb_conversions> @@ -43,6 +44,7 @@ <max_actions>4</max_actions> <sum_visit_length>721</sum_visit_length> <bounce_count>0</bounce_count> + <nb_visits_converted>1</nb_visits_converted> <goals> <row idgoal='1'> <nb_conversions>1</nb_conversions> diff --git a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__UserCountry.getRegion_day.xml b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__UserCountry.getRegion_day.xml index 3d891a7b3e..ed6707d63a 100644 --- a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__UserCountry.getRegion_day.xml +++ b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__UserCountry.getRegion_day.xml @@ -9,6 +9,7 @@ <max_actions>6</max_actions> <sum_visit_length>5403</sum_visit_length> <bounce_count>0</bounce_count> + <nb_visits_converted>2</nb_visits_converted> <goals> <row idgoal='ecommerceAbandonedCart'> <nb_conversions>2</nb_conversions> diff --git a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__VisitTime.getVisitInformationPerServerTime_day.xml b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__VisitTime.getVisitInformationPerServerTime_day.xml index d1f4094adf..b2c3bf5c52 100644 --- a/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__VisitTime.getVisitInformationPerServerTime_day.xml +++ b/plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems__VisitTime.getVisitInformationPerServerTime_day.xml @@ -9,6 +9,7 @@ <max_actions>4</max_actions> <sum_visit_length>721</sum_visit_length> <bounce_count>0</bounce_count> + <nb_visits_converted>1</nb_visits_converted> <goals> <row idgoal='1'> <nb_conversions>1</nb_conversions> @@ -114,6 +115,7 @@ <max_actions>3</max_actions> <sum_visit_length>721</sum_visit_length> <bounce_count>0</bounce_count> + <nb_visits_converted>0</nb_visits_converted> <goals> <row idgoal='ecommerceAbandonedCart'> <nb_conversions>1</nb_conversions> |