diff options
author | diosmosis <diosmosis@users.noreply.github.com> | 2018-10-03 03:02:10 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-10-03 03:02:10 +0300 |
commit | 5eaee0c90cf0124eac1eb4ed63f6ad95b1c4dfa9 (patch) | |
tree | cfad3b70d3e51488092334623a1817c1bdca1917 /plugins/Events | |
parent | 89403849f37e08ab1819973550a96f479133b9eb (diff) |
New feature: allow setting goal revenue to event value for event matching goals. (#13483)
* New feature: allow setting goal revenue to event value for event matching goals.
* Forgot to add update file.
* Add check that event_value_as_revenue is used only if this is an event matching goal.
* Remove console.log.
* Move new goal option to goal revenue section.
* Add another event value as revenue note.
* Move goal conversion to after deprecated event + only override event value if event value is not empty + add tests for this.
* fixing tests
Diffstat (limited to 'plugins/Events')
-rw-r--r-- | plugins/Events/Actions/ActionEvent.php | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/plugins/Events/Actions/ActionEvent.php b/plugins/Events/Actions/ActionEvent.php index 83af0d7ad1..e2acdf478e 100644 --- a/plugins/Events/Actions/ActionEvent.php +++ b/plugins/Events/Actions/ActionEvent.php @@ -27,7 +27,7 @@ class ActionEvent extends Action $url = $request->getParam('url'); $this->setActionUrl($url); - $this->eventValue = trim($request->getParam('e_v')); + $this->eventValue = self::getEventValue($request); } public static function shouldHandle(Request $request) @@ -38,6 +38,11 @@ class ActionEvent extends Action return (strlen($eventCategory) > 0 && strlen($eventAction) > 0); } + public static function getEventValue(Request $request) + { + return trim($request->getParam('e_v')); + } + public function getEventAction() { return $this->request->getParam('e_a'); |