Use newer version of Puppeteer for UI tests (#17880)

* Use latest version of Puppeteer for UI tests

* use newer node on travis

* test

* use waitForTimeout / waitForSelector instead of waitFor

* Handle BC for removed waitFor method

* Updates expected UI test files

* update submodules

* improve/fix some UI tests

* Updates expected UI test files

* improve/fix some UI tests

* update url-parse dependency

* simplify some UI tests

* update screenshot

* avoid using merged assets that are broken

* fix expected compare exit code

* don't use merged assets for TwoFactorAuth UI tests

it seems due to too many requests to login, logout and other pages merging the CoreJS assets somehow fails, and results in returning an empty file. Even the reload fails to serve the correct content, so maybe the file, the content should be written to, is somehow locked. Disabling the merged assets seems to fix this issue for this tests. Locally the tests are also running correctly with merged assets.

* improve handling of automatic css / js reloading in UI tests

* increase timeouts of TwoFactorAuth UI tests

* fix 2fa ui test

* revert change

* update new screenshot

* updates UI screenshots

* submodule updates

4 files changed, 6 insertions, 6 deletions

diff --git a/plugins/Feedback/tests/UI/FeedbackPopup_spec.js b/plugins/Feedback/tests/UI/FeedbackPopup_spec.js
index 5073ff9594..cdfbbeb36e 100644
--- a/plugins/Feedback/tests/UI/FeedbackPopup_spec.js
+++ b/plugins/Feedback/tests/UI/FeedbackPopup_spec.js
@@ -24,7 +24,7 @@ describe("FeedbackPopup", function () {
         await page.goto(url);
         await page.waitForNetworkIdle();
 
-        var modal = await page.waitFor('.modal.open', { visible: true });
+        var modal = await page.waitForSelector('.modal.open', { visible: true });
         expect(await modal.screenshot()).to.matchImage('feedback_popup');
 
         // Click on the "Remind me in 90 days" button = the popup shouldn't appear for the next test
diff --git a/plugins/Feedback/tests/UI/ReferBanner_spec.js b/plugins/Feedback/tests/UI/ReferBanner_spec.js
index 7b0364f111..84b8c1bb33 100644
--- a/plugins/Feedback/tests/UI/ReferBanner_spec.js
+++ b/plugins/Feedback/tests/UI/ReferBanner_spec.js
@@ -24,7 +24,7 @@ describe("ReferBannerTest", function () {
         await page.goto(url);
         await page.waitForNetworkIdle();
 
-        var banner = await page.waitFor('.refer-banner', { visible: true });
+        var banner = await page.waitForSelector('.refer-banner', { visible: true });
         expect(await banner.screenshot()).to.matchImage('feedback_popup');
     });
 });
diff --git a/plugins/Feedback/tests/UI/expected-screenshots/FeedbackForm_show.png b/plugins/Feedback/tests/UI/expected-screenshots/FeedbackForm_show.png
index 6cc0baaa47..7ca34edd9d 100644
--- a/plugins/Feedback/tests/UI/expected-screenshots/FeedbackForm_show.png
+++ b/plugins/Feedback/tests/UI/expected-screenshots/FeedbackForm_show.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:bdae452443e888644ea410706b751f8931d93f1760db6fed533059caef0d742c
-size 269138
+oid sha256:37bddab33dbd00a473c45f015a96bf420c6b3d9f21e0b4e668e0d569fb9d471f
+size 269098
diff --git a/plugins/Feedback/tests/UI/expected-screenshots/FeedbackPopup_feedback_popup.png b/plugins/Feedback/tests/UI/expected-screenshots/FeedbackPopup_feedback_popup.png
index 47b7b15d4e..a6c7a12fe9 100644
--- a/plugins/Feedback/tests/UI/expected-screenshots/FeedbackPopup_feedback_popup.png
+++ b/plugins/Feedback/tests/UI/expected-screenshots/FeedbackPopup_feedback_popup.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:569affdd2877633a19212a4d409a2254f76593e1f1d5629a2caf6703586495be
-size 27962
+oid sha256:d5e4c0571a535a90244639b4d6f68c9679f53300dd0f1eedd3ac6024d3e0571a
+size 27936