Removes CustomVariables plugin from core (#16090)

* Removes CustomVariables plugin

* removes CustomVariables plugin from core list

* Move methods to get custom variables from request to the plugin

* define visit fields to persist in plugin

* do not use custom variables plugin if not available

* adjust test requirements for CustomVariables plugin

* Only execute update if plugin is installed

* do not consider custom variables widget as api in tests

* move autosuggest tests for custom variables to plugin

* do not use custom variable segments in core tests

* move multi column segment test to custom variables plugin

* do not use custom variable segment in archive cron test

* update access log to use new product view parameters instead of custom variables

* move some custom variables based tests to plugin

* Use Contents API instead of CustomVariables for CSV export tests

* skip some tests if CustomVariables plugin is not available

* Adjust tracker code generator tests to work without custom variables plugin

* [TEMP] remove custom variables from system test output

* adjust some tests to run without custom variables plugin

* apply some review feedback

* Readds Custom Variables as submodule (#16104)

* Adds CustomVariables as submodule

* Revert "[TEMP] remove custom variables from system test output"

This reverts commit 30b56dc135b6c130c841306f739dbcd7d9f4a366.

* use submodule branch

* test changes due to loading CustomVariables as submodule (plugin order)

* updates some expected screenshots

* improve test fixture

* submodule update

1 files changed, 0 insertions, 4 deletions

diff --git a/plugins/Goals/Archiver.php b/plugins/Goals/Archiver.php
index 71dfad88bf..d49d6aed68 100644
--- a/plugins/Goals/Archiver.php
+++ b/plugins/Goals/Archiver.php
@@ -378,10 +378,6 @@ class Archiver extends \Piwik\Plugin\Archiver
                 return false;
             }
             $label = "Value not defined";
-            // Product Name/Category not defined"
-            if (\Piwik\Plugin\Manager::getInstance()->isPluginActivated('CustomVariables')) {
-                $label = \Piwik\Plugins\CustomVariables\Archiver::LABEL_CUSTOM_VALUE_NOT_DEFINED;
-            }
         }
         return $label;
     }