Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/matomo-org/matomo.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBen Burgess <88810029+bx80@users.noreply.github.com>2022-08-16 10:21:59 +0300
committerGitHub <noreply@github.com>2022-08-16 10:21:59 +0300
commit4911a83c32548f9eed592606a24fa842458e4a1c (patch)
tree835cd66d8393f14bf92536694bc18a810c726ef9 /plugins/Goals/Visualizations/Goals.php
parent6ff01e74bab76ef7396c51fe5bcdbf31a599c2cc (diff)
Fix for page goals visualization showing hits instead of visits (#19618)
* Fix for page goals visualization showing hits instead of visits * Update UI test screenshots
Diffstat (limited to 'plugins/Goals/Visualizations/Goals.php')
-rw-r--r--plugins/Goals/Visualizations/Goals.php10
1 files changed, 5 insertions, 5 deletions
diff --git a/plugins/Goals/Visualizations/Goals.php b/plugins/Goals/Visualizations/Goals.php
index dbccd776a1..873f05c67d 100644
--- a/plugins/Goals/Visualizations/Goals.php
+++ b/plugins/Goals/Visualizations/Goals.php
@@ -92,8 +92,8 @@ class Goals extends HtmlTable
}
if ($this->displayType == self::GOALS_DISPLAY_PAGES) {
- $this->config->addTranslation('nb_hits', Piwik::translate('General_ColumnUniquePageviews'));
- $this->config->metrics_documentation['nb_hits'] = Piwik::translate('General_ColumnUniquePageviewsDocumentation');
+ $this->config->addTranslation('nb_visits', Piwik::translate('General_ColumnUniquePageviews'));
+ $this->config->metrics_documentation['nb_visits'] = Piwik::translate('General_ColumnUniquePageviewsDocumentation');
$this->removeUnusedRevenueColumns();
}
@@ -193,7 +193,7 @@ class Goals extends HtmlTable
}
if ($this->displayType == self::GOALS_DISPLAY_PAGES) {
- $this->config->columns_to_display = ['label', 'nb_hits'];
+ $this->config->columns_to_display = ['label', 'nb_visits']; // Should be uniques
$goalColumnTemplates = [
'goal_%s_nb_conversions_attrib',
'goal_%s_revenue_attrib',
@@ -265,14 +265,14 @@ class Goals extends HtmlTable
if ($this->displayType == self::GOALS_DISPLAY_PAGES) {
if ('all' === $idGoals) {
$idGoals = array_keys($allGoals);
- $this->requestConfig->filter_sort_column = 'nb_hits';
+ $this->requestConfig->filter_sort_column = 'nb_visits';
} else {
// only sort by a goal's conversions if not showing all goals (for FULL_REPORT)
$this->requestConfig->filter_sort_column = 'goal_' . reset($idGoals) . '_nb_conversions_attrib';
}
$this->requestConfig->filter_sort_order = 'desc';
- $this->config->columns_to_display = ['label', 'nb_hits'];
+ $this->config->columns_to_display = ['label', 'nb_visits'];
$goalColumnTemplates = [
'goal_%s_nb_conversions_attrib',
'goal_%s_revenue_attrib',