Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/matomo-org/matomo.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Giehl <stefan@matomo.org>2021-08-17 10:58:59 +0300
committerGitHub <noreply@github.com>2021-08-17 10:58:59 +0300
commit0829d6e6ac487bf47e4197123d6683b271db8266 (patch)
tree77f8edd0c326b29c50d9fefd174cd45d5ebcbc92 /plugins/Goals/tests/Integration/APITest.php
parent8c7fa7d8d414b5201c36661fb4828d14e4c33c53 (diff)
Run AllTests on PHP8 (#16897)
* Run AllTests on PHP8 * use newer phpunit for tests on PHP8 * fix notices/errors * handle trace of phpunit 9 * ensure to compare same types for range check * adjust expected result for php8 * try handling hasDependencies does not exist in PHPUnit 9 * fix: ArgumentCountError: mysqli_stmt::bind_param() does not accept unknown named parameters * Fix usercountry tests * remove incorrect date check * fix expected exception message * fix referrers api test for php8 * add test hint * try to fix session related tests * debug test failure * try to fix mail tests * fix filterUser method * exlucde phpunit from build size calculation * fix scheduled reports test * update release checklist test * unset climode * improves some tests
Diffstat (limited to 'plugins/Goals/tests/Integration/APITest.php')
-rw-r--r--plugins/Goals/tests/Integration/APITest.php16
1 files changed, 6 insertions, 10 deletions
diff --git a/plugins/Goals/tests/Integration/APITest.php b/plugins/Goals/tests/Integration/APITest.php
index 12ce5cb09f..478dadaad6 100644
--- a/plugins/Goals/tests/Integration/APITest.php
+++ b/plugins/Goals/tests/Integration/APITest.php
@@ -43,17 +43,13 @@ class APITest extends IntegrationTestCase
*/
public function test_addGoal_handlesAppropriatePatternTypesForNumericAttributes($matchAttribute, $patternType, $pattern, $expectException)
{
- try {
- $this->api->addGoal($this->idSite, 'test goal', $matchAttribute, $pattern, $patternType);
-
- if ($expectException) {
- $this->fail('addGoal should have failed');
- }
- } catch (\Exception $ex) {
- if (!$expectException) {
- throw $ex;
- }
+ if ($expectException) {
+ $this->expectException(\Exception::class);
+ } else {
+ $this->expectNotToPerformAssertions();
}
+
+ $this->api->addGoal($this->idSite, 'test goal', $matchAttribute, $pattern, $patternType);
}
public function getTestDataForNumericMatchAttribute()