Replace proxy redirect with rel=noreferrer (#12780)

* Replace proxy redirect with rel=noreferrer

* Add noopener

* Restore action=redirect for non-Matomo links

* Wrap referring URLs

* NO target on download link

* Fix Github links

* Fix whitespace

* Fix tests

* Revert change

* Revert changes

* Fix tests

* Add noreferrer shim for MSIE 10

* Remove all action=redirect links

* Restore noreferrer

* Restore test

* Fix one more occurrence

* Update changelog

* Combine if's

* Fix changelog wording

* Fix stray whitespace

5 files changed, 8 insertions, 8 deletions

diff --git a/plugins/Installation/FormSuperUser.php b/plugins/Installation/FormSuperUser.php
index 7c24bddcaa..6cbe91e4cc 100644
--- a/plugins/Installation/FormSuperUser.php
+++ b/plugins/Installation/FormSuperUser.php
@@ -59,7 +59,7 @@ class FormSuperUser extends QuickForm2
             ));
 
         $professionalServicesNewsletter = Piwik::translate('Installation_ProfessionalServicesNewsletter',
-            array("<a href='https://matomo.org/support/?pk_medium=App_Newsletter_link&pk_source=Piwik_App&pk_campaign=App_Installation' style='color:#444;' rel='noreferrer' target='_blank'>", "</a>")
+            array("<a href='https://matomo.org/support/?pk_medium=App_Newsletter_link&pk_source=Piwik_App&pk_campaign=App_Installation' style='color:#444;' rel='noreferrer noopener' target='_blank'>", "</a>")
         );
 
         $privacyNoticeLink = '<a href="https://matomo.org/privacy-policy/" target="_blank" rel="noreferrer noopener">';
diff --git a/plugins/Installation/templates/finished.twig b/plugins/Installation/templates/finished.twig
index 1be63b10b1..8cfa70ab23 100644
--- a/plugins/Installation/templates/finished.twig
+++ b/plugins/Installation/templates/finished.twig
@@ -11,8 +11,8 @@
         {{ 'Installation_CollaborativeProject'|translate }}
     </p>
     <p>
-        {{ 'Installation_GetInvolved'|translate('<a  rel="noreferrer"  target="_blank" href="https://matomo.org/get-involved/">','</a>')|raw }}
-        {{ 'General_HelpTranslatePiwik'|translate("<a rel='noreferrer' target='_blank' href=\'https://matomo.org/translations/\'>","<\/a>")|raw }}
+        {{ 'Installation_GetInvolved'|translate('<a rel="noreferrer noopener" target="_blank" href="https://matomo.org/get-involved/">','</a>')|raw }}
+        {{ 'General_HelpTranslatePiwik'|translate("<a rel='noreferrer noopener' target='_blank' href=\'https://matomo.org/translations/\'>","<\/a>")|raw }}
     </p>
     <p>{{ 'Installation_WeHopeYouWillEnjoyPiwik'|translate }}</p>
     <p><i>{{ 'Installation_HappyAnalysing'|translate }}</i></p>
@@ -23,7 +23,7 @@
             {{ 'Installation_ProfessionalServicesfessionalServicesAdText'|translate }}
         </p>
         <p>
-            {{ 'Installation_ProfessionalServicesfessionalDiscoverHow'|translate('<a rel="noreferrer" target="_blank" href="' ~ linkToProfessionalServices ~ '">','</a>')|raw }}
+            {{ 'Installation_ProfessionalServicesfessionalDiscoverHow'|translate('<a rel="noreferrer noopener" target="_blank" href="' ~ linkToProfessionalServices ~ '">','</a>')|raw }}
         </p>
     {% endif %}
 
diff --git a/plugins/Installation/templates/reuseTables.twig b/plugins/Installation/templates/reuseTables.twig
index 28ac5d0e11..e390309d38 100644
--- a/plugins/Installation/templates/reuseTables.twig
+++ b/plugins/Installation/templates/reuseTables.twig
@@ -25,7 +25,7 @@
             <ul>
                 <li>{{ 'CoreUpdater_ErrorDIYHelp_1'|translate }}</li>
                 <li>{{ 'CoreUpdater_ErrorDIYHelp_2'|translate }}</li>
-                <li>{{ 'CoreUpdater_ErrorDIYHelp_3'|translate }} <a href='https://matomo.org/faq/how-to-update/#faq_179' rel='noreferrer' target='_blank'>(see FAQ)</a></li>
+                <li>{{ 'CoreUpdater_ErrorDIYHelp_3'|translate }} <a href='https://matomo.org/faq/how-to-update/#faq_179' rel='noreferrer noopener' target='_blank'>(see FAQ)</a></li>
                 <li>{{ 'CoreUpdater_ErrorDIYHelp_4'|translate }}</li>
                 <li>{{ 'CoreUpdater_ErrorDIYHelp_5'|translate }}</li>
             </ul>
diff --git a/plugins/Installation/templates/systemCheck.twig b/plugins/Installation/templates/systemCheck.twig
index d7b5c4b9a9..248d0ba622 100644
--- a/plugins/Installation/templates/systemCheck.twig
+++ b/plugins/Installation/templates/systemCheck.twig
@@ -23,7 +23,7 @@
     {% if not showNextStep %}
         <p>
             <span class="icon-export"></span>
-            <a href="?module=Proxy&action=redirect&url=https://matomo.org/docs/requirements/" target="_blank">{{ 'Installation_Requirements'|translate }}</a>
+            <a target="_blank" rel="noreferrer noopener" href="https://matomo.org/docs/requirements/">{{ 'Installation_Requirements'|translate }}</a>
         </p>
         {% include "@Installation/_systemCheckLegend.twig" %}
     {% endif %}
diff --git a/plugins/Installation/templates/trackingCode.twig b/plugins/Installation/templates/trackingCode.twig
index e3ecf9db16..cb9455fe70 100644
--- a/plugins/Installation/templates/trackingCode.twig
+++ b/plugins/Installation/templates/trackingCode.twig
@@ -12,10 +12,10 @@
 
     <h3>{{ 'Installation_LargePiwikInstances'|translate }}</h3>
     <p>
-        {{ 'Installation_JsTagArchivingHelp1'|translate('<a rel="noreferrer" target="_blank" href="https://matomo.org/docs/setup-auto-archiving/">','</a>')|raw }}
+        {{ 'Installation_JsTagArchivingHelp1'|translate('<a rel="noreferrer noopener" target="_blank" href="https://matomo.org/docs/setup-auto-archiving/">','</a>')|raw }}
     </p>
     <p>
-        {{ 'General_ReadThisToLearnMore'|translate('<a rel="noreferrer" target="_blank" href="https://matomo.org/docs/optimize/">','</a>')|raw }}
+        {{ 'General_ReadThisToLearnMore'|translate('<a rel="noreferrer noopener" target="_blank" href="https://matomo.org/docs/optimize/">','</a>')|raw }}
     </p>
 
 {% endblock %}