Improved plugins update API (#10028)

* refs #7983 let plugins add or remove fields to websites and better settings api

* * Hide CorePluginsAdmin API methods
* More documentation
* Added some more tests

* improved updates API for plugins

* better error code as duplicate column cannot really happen when not actually renaming a colum

1 files changed, 15 insertions, 8 deletions

diff --git a/plugins/LanguagesManager/Updates/2.15.1-b1.php b/plugins/LanguagesManager/Updates/2.15.1-b1.php
index 3465ad7b57..631843d5b4 100644
--- a/plugins/LanguagesManager/Updates/2.15.1-b1.php
+++ b/plugins/LanguagesManager/Updates/2.15.1-b1.php
@@ -9,24 +9,31 @@
 
 namespace Piwik\Plugins\LanguagesManager;
 
-use Piwik\Common;
 use Piwik\Updater;
 use Piwik\Updates;
-
+use Piwik\Updater\Migration\Factory as MigrationFactory;
 
 class Updates_2_15_1_b1 extends Updates
 {
-    public function getMigrationQueries(Updater $updater)
+    /**
+     * @var MigrationFactory
+     */
+    private $migration;
+
+    public function __construct(MigrationFactory $factory)
+    {
+        $this->migration = $factory;
+    }
+
+    public function getMigrations(Updater $updater)
     {
-        $updateSql = array(
-            'ALTER TABLE `' . Common::prefixTable('user_language')
-                . '` ADD COLUMN `use_12_hour_clock` TINYINT(1) NOT NULL DEFAULT 0 AFTER `language`' => array(1060)
+        return array(
+            $this->migration->db->addColumn('user_language', 'use_12_hour_clock', 'TINYINT(1) NOT NULL DEFAULT 0', 'language')
         );
-        return $updateSql;
     }
 
     public function doUpdate(Updater $updater)
     {
-        $updater->executeMigrationQueries(__FILE__, $this->getMigrationQueries($updater));
+        $updater->executeMigrations(__FILE__, $this->getMigrations($updater));
     }
 }