diff options
author | sgiehl <stefan@piwik.org> | 2016-02-08 00:14:02 +0300 |
---|---|---|
committer | sgiehl <stefan@piwik.org> | 2016-02-08 00:14:02 +0300 |
commit | 5a3f72406dc02676527b45aafb244f4e1d0ab685 (patch) | |
tree | 24c9a44c43c1d8e4e8a58c1ef8fd1cf7a3d03243 /plugins/LanguagesManager | |
parent | 35547ee95f23d864b09aeafeb26b2d2b01fbde02 (diff) |
fixes #9546 - Adds test for numbered placeholder usage
Diffstat (limited to 'plugins/LanguagesManager')
-rwxr-xr-x | plugins/LanguagesManager/Test/Integration/LanguagesManagerTest.php | 23 |
1 files changed, 23 insertions, 0 deletions
diff --git a/plugins/LanguagesManager/Test/Integration/LanguagesManagerTest.php b/plugins/LanguagesManager/Test/Integration/LanguagesManagerTest.php index cf85b79bcf..0017cb3729 100755 --- a/plugins/LanguagesManager/Test/Integration/LanguagesManagerTest.php +++ b/plugins/LanguagesManager/Test/Integration/LanguagesManagerTest.php @@ -8,6 +8,7 @@ namespace Piwik\Plugins\LanguagesManager\Test\Integration; +use Piwik\Cache; use Piwik\Container\StaticContainer; use Piwik\Intl\Data\Provider\LanguageDataProvider; use Piwik\Plugins\LanguagesManager\API; @@ -19,6 +20,7 @@ use Piwik\Plugins\LanguagesManager\TranslationWriter\Filter\UnnecassaryWhitespac use Piwik\Plugins\LanguagesManager\TranslationWriter\Validate\CoreTranslations; use Piwik\Plugins\LanguagesManager\TranslationWriter\Validate\NoScripts; use Piwik\Plugins\LanguagesManager\TranslationWriter\Writer; +use Piwik\Translate; /** * @group LanguagesManager @@ -126,6 +128,27 @@ class LanguagesManagerTest extends \PHPUnit_Framework_TestCase } /** + * check all english translations do not contain more than one + * + * @group Plugins + * @group numbered + */ + function testTranslationsUseNumberedPlaceholders() + { + Cache::flushAll(); + $translator = StaticContainer::get('Piwik\Translation\Translator'); + $translator->reset(); + Translate::loadAllTranslations(); + $translations = $translator->getAllTranslations(); + foreach ($translations AS $plugin => $pluginTranslations) { + foreach ($pluginTranslations as $key => $pluginTranslation) { + $this->assertLessThanOrEqual(1, substr_count($pluginTranslation, '%s'), + sprintf('%s.%s must use numbered placeholders instead of multiple %%s', $plugin, $key)); + } + } + } + + /** * test English short name for language * * @group Plugins |