diff options
| author | Christian Schmidt <github@chsc.dk> | 2018-07-25 22:47:29 +0300 |
|---|---|---|
| committer | diosmosis <diosmosis@users.noreply.github.com> | 2018-07-25 22:47:29 +0300 |
| commit | e09383ebeedd6b6f8dee8b57373027b00e6203b5 (patch) | |
| tree | 3d0faed73ba8629a52a000147b99396239cdd0ba /plugins/Login | |
| parent | ef9c48cc48587776107b1500dc14eef3ffa19154 (diff) | |
Replace proxy redirect with rel=noreferrer (#12780)
* Replace proxy redirect with rel=noreferrer
* Add noopener
* Restore action=redirect for non-Matomo links
* Wrap referring URLs
* NO target on download link
* Fix Github links
* Fix whitespace
* Fix tests
* Revert change
* Revert changes
* Fix tests
* Add noreferrer shim for MSIE 10
* Remove all action=redirect links
* Restore noreferrer
* Restore test
* Fix one more occurrence
* Update changelog
* Combine if's
* Fix changelog wording
* Fix stray whitespace
Diffstat (limited to 'plugins/Login')
| -rw-r--r-- | plugins/Login/Controller.php | 4 | ||||
| -rw-r--r-- | plugins/Login/templates/login.twig | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/plugins/Login/Controller.php b/plugins/Login/Controller.php index b91852d41b..c933214b01 100644 --- a/plugins/Login/Controller.php +++ b/plugins/Login/Controller.php @@ -231,7 +231,7 @@ class Controller extends \Piwik\Plugin\Controller protected function getMessageExceptionNoAccess() { - $message = Piwik::translate('Login_InvalidNonceOrHeadersOrReferrer', array('<a href="?module=Proxy&action=redirect&url=' . urlencode('https://matomo.org/faq/how-to-install/#faq_98') . '" target="_blank">', '</a>')); + $message = Piwik::translate('Login_InvalidNonceOrHeadersOrReferrer', array('<a target="_blank" rel="noreferrer noopener" href="https://matomo.org/faq/how-to-install/#faq_98">', '</a>')); $message .= $this->getMessageExceptionNoAccessWhenInsecureConnectionMayBeUsed(); @@ -250,7 +250,7 @@ class Controller extends \Piwik\Plugin\Controller if(Url::isSecureConnectionAssumedByPiwikButNotForcedYet()) { $message = '<br/><br/>' . Piwik::translate('Login_InvalidNonceSSLMisconfigured', array( - '<a href="?module=Proxy&action=redirect&url=' . urlencode('<a href="https://matomo.org/faq/how-to/faq_91/">') . '">', + '<a target="_blank" rel="noreferrer noopener" href="https://matomo.org/faq/how-to/faq_91/">', '</a>', 'config/config.ini.php', '<pre>force_ssl=1</pre>', diff --git a/plugins/Login/templates/login.twig b/plugins/Login/templates/login.twig index a128236383..e12c8af5db 100644 --- a/plugins/Login/templates/login.twig +++ b/plugins/Login/templates/login.twig @@ -114,7 +114,7 @@ {% if isCustomLogo %} <p id="piwik"> - <i><a href="https://matomo.org/" rel="noreferrer" target="_blank">{{ linkTitle }}</a></i> + <i><a href="https://matomo.org/" rel="noreferrer noopener" target="_blank">{{ linkTitle }}</a></i> </p> {% endif %} |