diff options
| author | aloxe <aloxe@users.noreply.github.com> | 2021-01-01 03:24:00 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-01-01 03:24:00 +0300 |
| commit | 52c573a0572f079c99bfa3331b8ef4164e199281 (patch) | |
| tree | bfe3cfbcb75f6c84ec2ab8f30eb1c385da7f0a68 /plugins/Marketplace | |
| parent | bd58cc881492f5079e8ab3b8265daa72e4db8842 (diff) | |
add href in link in update message email (#16661)
* add href in link in update message email
* add href in link in update message email
* code review: secure host in url
Diffstat (limited to 'plugins/Marketplace')
| -rw-r--r-- | plugins/Marketplace/templates/_updateCommunicationEmail.twig | 4 | ||||
| -rw-r--r-- | plugins/Marketplace/tests/Integration/UpdateCommunicationTest.php | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/plugins/Marketplace/templates/_updateCommunicationEmail.twig b/plugins/Marketplace/templates/_updateCommunicationEmail.twig index 5c24e472db..04764a99cf 100644 --- a/plugins/Marketplace/templates/_updateCommunicationEmail.twig +++ b/plugins/Marketplace/templates/_updateCommunicationEmail.twig @@ -10,14 +10,14 @@ {% if hasThemeUpdate %} <p> {{ 'CoreUpdater_NotificationClickToUpdateThemes'|translate }}<br/> -{{ host }}index.php?module=CorePluginsAdmin&action=themes +<a href="{{ host|e('html_attr') }}index.php?module=CorePluginsAdmin&action=themes">{{ host }}index.php?module=CorePluginsAdmin&action=themes</a> </p> {% endif %} {% if hasPluginUpdate %} <p> {{ 'CoreUpdater_NotificationClickToUpdatePlugins'|translate }}<br/> -{{ host }}index.php?module=CorePluginsAdmin&action=plugins +<a href="{{ host|e('html_attr') }}index.php?module=CorePluginsAdmin&action=plugins">{{ host }}index.php?module=CorePluginsAdmin&action=plugins</a> </p> {% endif %} diff --git a/plugins/Marketplace/tests/Integration/UpdateCommunicationTest.php b/plugins/Marketplace/tests/Integration/UpdateCommunicationTest.php index fe2444423d..3f9a2d83be 100644 --- a/plugins/Marketplace/tests/Integration/UpdateCommunicationTest.php +++ b/plugins/Marketplace/tests/Integration/UpdateCommunicationTest.php @@ -130,7 +130,7 @@ class UpdateCommunicationTest extends IntegrationTestCase <p> CoreUpdater_NotificationClickToUpdatePlugins<br/> -{$rootUrl}index.php?module=CorePluginsAdmin&action=plugins +<a href=\"{$rootUrl}index.php?module=CorePluginsAdmin&action=plugins\">{$rootUrl}index.php?module=CorePluginsAdmin&action=plugins</a> </p> <p> |