Replace proxy redirect with rel=noreferrer (#12780)

* Replace proxy redirect with rel=noreferrer

* Add noopener

* Restore action=redirect for non-Matomo links

* Wrap referring URLs

* NO target on download link

* Fix Github links

* Fix whitespace

* Fix tests

* Revert change

* Revert changes

* Fix tests

* Add noreferrer shim for MSIE 10

* Remove all action=redirect links

* Restore noreferrer

* Restore test

* Fix one more occurrence

* Update changelog

* Combine if's

* Fix changelog wording

* Fix stray whitespace

10 files changed, 25 insertions, 25 deletions

diff --git a/plugins/ProfessionalServices/templates/promoBelowCampaigns.twig b/plugins/ProfessionalServices/templates/promoBelowCampaigns.twig
index 1aa00beabf..d6b1c9a5e3 100644
--- a/plugins/ProfessionalServices/templates/promoBelowCampaigns.twig
+++ b/plugins/ProfessionalServices/templates/promoBelowCampaigns.twig
@@ -1,11 +1,11 @@
 <p style="margin-top:3em" class=" alert-info alert">Did you know?
-    <br/> <a target="_blank" rel="noreferrer" href="https://matomo.org/docs/tracking-campaigns/">Campaign tracking</a> lets you measure the effectiveness of your marketing campaigns such as emails marketing, paid search, banner ads, affiliates links, etc.
-    Use the <a target="_blank" rel="noreferrer" href="https://matomo.org/docs/tracking-campaigns/">URL Builder tool</a> to create your links with new URL campaign parameters.
+    <br/> <a target="_blank" rel="noreferrer noopener" href="https://matomo.org/docs/tracking-campaigns/">Campaign tracking</a> lets you measure the effectiveness of your marketing campaigns such as emails marketing, paid search, banner ads, affiliates links, etc.
+    Use the <a target="_blank" rel="noreferrer noopener" href="https://matomo.org/docs/tracking-campaigns/">URL Builder tool</a> to create your links with new URL campaign parameters.
     {% if displayMarketingCampaignsReportingAd %}
-        <br/> Install our <a target="_blank" rel="noreferrer" href="https://plugins.matomo.org/MarketingCampaignsReporting">Marketing Campaigns Reporting plugin</a> to get even more campaigns reports and new segments for up to five marketing channels (campaign, source, medium, keyword, content).
+        <br/> Install our <a target="_blank" rel="noreferrer noopener" href="https://plugins.matomo.org/MarketingCampaignsReporting">Marketing Campaigns Reporting plugin</a> to get even more campaigns reports and new segments for up to five marketing channels (campaign, source, medium, keyword, content).
     {% endif %}
     {% if multiChannelConversionAttributionAd %}
         <br />
-        Discover how much each campaign truly contributes to your success by applying attribution models using the <a target="_blank" rel="noreferrer" href="https://plugins.piwik.org/MarketingCampaignsReporting">Multi Channel Conversion Attribution</a> premium feature.
+        Discover how much each campaign truly contributes to your success by applying attribution models using the <a target="_blank" rel="noreferrer noopener" href="https://plugins.piwik.org/MarketingCampaignsReporting">Multi Channel Conversion Attribution</a> premium feature.
     {% endif %}
-</p>
\ No newline at end of file
+</p>
diff --git a/plugins/ProfessionalServices/templates/promoBelowEvents.twig b/plugins/ProfessionalServices/templates/promoBelowEvents.twig
index ae2af80dde..5888288105 100644
--- a/plugins/ProfessionalServices/templates/promoBelowEvents.twig
+++ b/plugins/ProfessionalServices/templates/promoBelowEvents.twig
@@ -1,7 +1,7 @@
 <p style="margin-top:3em" class=" alert-info alert">Did you know?
-    <br/>Using Events you can measure any user interaction and gain amazing insights into your audience. <a target="_blank" href="?module=Proxy&action=redirect&url=https://matomo.org/docs/event-tracking/">Learn more</a>.
-    <br/> To measure blocks of content such as image galleries, listings or ads: use <a target="_blank" href="?module=Proxy&action=redirect&url=https://developer.matomo.org/guides/content-tracking">Content Tracking</a> and see exactly which content is viewed and clicked.
+    <br/>Using Events you can measure any user interaction and gain amazing insights into your audience. <a target="_blank" rel="noreferrer noopener" href="https://matomo.org/docs/event-tracking/">Learn more</a>.
+    <br/> To measure blocks of content such as image galleries, listings or ads: use <a target="_blank" rel="noreferrer noopener" href="https://developer.matomo.org/guides/content-tracking">Content Tracking</a> and see exactly which content is viewed and clicked.
     {% if displayMediaAnalyticsAd %}
-        <br/>When you publish videos or audios, <a target="_blank" rel="noreferrer" href="https://matomo.org/recommends/media-analytics-website">Media Analytics gives deep insights into your audience</a> and how they watch your videos or listens to your music.
+        <br/>When you publish videos or audios, <a target="_blank" rel="noreferrer noopener" href="https://matomo.org/recommends/media-analytics-website">Media Analytics gives deep insights into your audience</a> and how they watch your videos or listens to your music.
     {% endif %}
-</p>
\ No newline at end of file
+</p>
diff --git a/plugins/ProfessionalServices/templates/promoBelowReferrerTypes.twig b/plugins/ProfessionalServices/templates/promoBelowReferrerTypes.twig
index 673c4f4367..fdb154657d 100644
--- a/plugins/ProfessionalServices/templates/promoBelowReferrerTypes.twig
+++ b/plugins/ProfessionalServices/templates/promoBelowReferrerTypes.twig
@@ -1,3 +1,3 @@
 <p style="margin-top:3em" class=" alert-info alert">Did you know?
-    <br/>You can get advanced insights into how much each of your marking channel truly contributes to your success by applying attribution models using the <a target="_blank" rel="noreferrer" href="https://plugins.piwik.org/MultiChannelConversionAttribution">Multi Channel Conversion Attribution</a> premium feature.
-</p>
\ No newline at end of file
+    <br/>You can get advanced insights into how much each of your marking channel truly contributes to your success by applying attribution models using the <a target="_blank" rel="noreferrer noopener" href="https://plugins.piwik.org/MultiChannelConversionAttribution">Multi Channel Conversion Attribution</a> premium feature.
+</p>
diff --git a/plugins/ProfessionalServices/templates/promoCustomVariables.twig b/plugins/ProfessionalServices/templates/promoCustomVariables.twig
index 69da4dbc11..de618dfde5 100644
--- a/plugins/ProfessionalServices/templates/promoCustomVariables.twig
+++ b/plugins/ProfessionalServices/templates/promoCustomVariables.twig
@@ -1,3 +1,3 @@
 <p style="margin-top:1em" class=" alert-info alert">Did you know?
-    <br/> With the <a target="_blank" rel="noreferrer" href="https://plugins.piwik.org/CustomReports">Custom Reports</a> premium feature you can pull out the information you need in a matter of seconds.
-</p>
\ No newline at end of file
+    <br/> With the <a target="_blank" rel="noreferrer noopener" href="https://plugins.piwik.org/CustomReports">Custom Reports</a> premium feature you can pull out the information you need in a matter of seconds.
+</p>
diff --git a/plugins/ProfessionalServices/templates/promoExperiments.twig b/plugins/ProfessionalServices/templates/promoExperiments.twig
index 7c018e8e4c..f25c95e076 100644
--- a/plugins/ProfessionalServices/templates/promoExperiments.twig
+++ b/plugins/ProfessionalServices/templates/promoExperiments.twig
@@ -1,3 +1,3 @@
 <p style="margin-top:3em" class=" alert-info alert">Did you know?
-    With <a target="_blank" rel="noreferrer" href="https://matomo.org/recommends/ab-testing-learn-more/">A/B Testing for Matomo</a> you can immediately increase conversions and sales by creating different versions of a page to see which one grows your business.
-</p>
\ No newline at end of file
+    With <a target="_blank" rel="noreferrer noopener" href="https://matomo.org/recommends/ab-testing-learn-more/">A/B Testing for Matomo</a> you can immediately increase conversions and sales by creating different versions of a page to see which one grows your business.
+</p>
diff --git a/plugins/ProfessionalServices/templates/promoFunnel.twig b/plugins/ProfessionalServices/templates/promoFunnel.twig
index 30260ad27b..23e31db32d 100644
--- a/plugins/ProfessionalServices/templates/promoFunnel.twig
+++ b/plugins/ProfessionalServices/templates/promoFunnel.twig
@@ -1,5 +1,5 @@
 <p style="margin-top:3em;margin-bottom:3em" class="alert-info alert">Did you know?
     A Funnel defines a series of actions that you expect your visitors to take on their way to converting a goal.
-    <br/>With <a target="_blank" rel="noreferrer" href="https://matomo.org/recommends/conversion-funnel/">Funnels for Matomo</a>,
+    <br/>With <a target="_blank" rel="noreferrer noopener" href="https://matomo.org/recommends/conversion-funnel/">Funnels for Matomo</a>,
     you can easily determine your funnel and see where your visitors drop off and how to focus efforts to increase your conversions.
-</p>
\ No newline at end of file
+</p>
diff --git a/plugins/ProfessionalServices/templates/promoHeatmaps.twig b/plugins/ProfessionalServices/templates/promoHeatmaps.twig
index 9d49010480..0d191d9eb4 100644
--- a/plugins/ProfessionalServices/templates/promoHeatmaps.twig
+++ b/plugins/ProfessionalServices/templates/promoHeatmaps.twig
@@ -1,3 +1,3 @@
 <p style="margin-top:24px;font-size:13px;" class="alert-info alert">Did you know?
-    With <a target="_blank" rel="noreferrer" href="https://matomo.org/recommends/heatmap-session-recording-learn-more/">Heatmap & Session Recording</a> you understand your visitors much better. See where your visitors click, move the mouse, scroll, type, and more.
+    With <a target="_blank" rel="noreferrer noopener" href="https://matomo.org/recommends/heatmap-session-recording-learn-more/">Heatmap & Session Recording</a> you understand your visitors much better. See where your visitors click, move the mouse, scroll, type, and more.
 </p>
diff --git a/plugins/ProfessionalServices/templates/promoSearchKeywords.twig b/plugins/ProfessionalServices/templates/promoSearchKeywords.twig
index 6829c0f9ec..1d8ebe3263 100644
--- a/plugins/ProfessionalServices/templates/promoSearchKeywords.twig
+++ b/plugins/ProfessionalServices/templates/promoSearchKeywords.twig
@@ -1,6 +1,6 @@
 <p style="margin-top:3em;margin-bottom:3em" class=" alert-info alert">Did you know?<br/>
-    Use <a target="_blank" rel="noreferrer" href="https://matomo.org/recommends/search-keywords-performance/">Search Keywords Performance</a>
+    Use <a target="_blank" rel="noreferrer noopener" href="https://matomo.org/recommends/search-keywords-performance/">Search Keywords Performance</a>
     to see all keywords behind 'keyword not defined'.
     All keywords searched by your users on Google, Bing and other search engines will be listed
     and you can even monitor the SEO position of your website in their search results.
-</p>
\ No newline at end of file
+</p>
diff --git a/plugins/ProfessionalServices/templates/promoServicesWidget.twig b/plugins/ProfessionalServices/templates/promoServicesWidget.twig
index 29edd9358f..5bfe57952e 100644
--- a/plugins/ProfessionalServices/templates/promoServicesWidget.twig
+++ b/plugins/ProfessionalServices/templates/promoServicesWidget.twig
@@ -1,13 +1,13 @@
 <div class="promoWidget">
     <div class="promo">
-        <a href="{{ ctaLinkUrl|e('html_attr') }}" target="_blank" rel="noreferrer"><img class="icon" src="plugins/ProfessionalServices/images/promo.png"></a>
+        <a href="{{ ctaLinkUrl|e('html_attr') }}" target="_blank" rel="noreferrer noopener"><img class="icon" src="plugins/ProfessionalServices/images/promo.png"></a>
         <h2>{{ ctaTitle }}</h2>
         <p class="text">
             <span>{{ ctaText }}</span>
             <br /><br />
-            <a class="btn" href="{{ ctaLinkUrl|e('html_attr') }}" target="_blank" rel="noreferrer">
+            <a class="btn" href="{{ ctaLinkUrl|e('html_attr') }}" target="_blank" rel="noreferrer noopener">
                 {{ ctaLinkTitle }}
             </a>
         </p>
     </div>
-</div>
\ No newline at end of file
+</div>
diff --git a/plugins/ProfessionalServices/templates/promoSessionRecordings.twig b/plugins/ProfessionalServices/templates/promoSessionRecordings.twig
index 4646ff6632..d087c865be 100644
--- a/plugins/ProfessionalServices/templates/promoSessionRecordings.twig
+++ b/plugins/ProfessionalServices/templates/promoSessionRecordings.twig
@@ -1,3 +1,3 @@
 <p class="alert-info alert">Did you know?
-    With <a target="_blank" rel="noreferrer" href="https://matomo.org/recommends/heatmap-session-recording-learn-more/">Heatmap & Session Recording</a> you can record all clicks, mouse movements, scrolls and form interactions of your visitors and replay them in a video to truly understand your visitors.
-</p>
\ No newline at end of file
+    With <a target="_blank" rel="noreferrer noopener" href="https://matomo.org/recommends/heatmap-session-recording-learn-more/">Heatmap & Session Recording</a> you can record all clicks, mouse movements, scrolls and form interactions of your visitors and replay them in a video to truly understand your visitors.
+</p>