diff options
author | dizzy <diosmosis@users.noreply.github.com> | 2021-02-17 10:24:03 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-02-17 10:24:03 +0300 |
commit | 41964121548784f6e15cbe51194cf3b929be7585 (patch) | |
tree | 054f1eb616ea5d4fc96b664c5afd72497bd7209c /plugins/SegmentEditor/tests/UI | |
parent | 419699c0fd3135468e0af2268a1b564997acd037 (diff) |
properly encode segment definitions from table so the hash will be the same as from query params (#17029)
* initial fix
* when creating a Segment or getting a segment hash using a segment definition from the segment table, make sure to urlencode so the hash is the same as when we send the segment as a query parameter
* try to make segment definition change appear in tests (seems like this is just a test fix? if I undo the changes the new test changes still pass)
* add test demonstrating bug
* check access in exampleplugin
* Add missing use
* fix test
* better fix
* fix tests
* fix test
* update expected screenshots
Diffstat (limited to 'plugins/SegmentEditor/tests/UI')
-rw-r--r-- | plugins/SegmentEditor/tests/UI/expected-screenshots/UnprocessedSegmentTest_unprocessed_segment.png | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/plugins/SegmentEditor/tests/UI/expected-screenshots/UnprocessedSegmentTest_unprocessed_segment.png b/plugins/SegmentEditor/tests/UI/expected-screenshots/UnprocessedSegmentTest_unprocessed_segment.png index 7942d6c6f4..a8a2b568f3 100644 --- a/plugins/SegmentEditor/tests/UI/expected-screenshots/UnprocessedSegmentTest_unprocessed_segment.png +++ b/plugins/SegmentEditor/tests/UI/expected-screenshots/UnprocessedSegmentTest_unprocessed_segment.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:1b7a3f5c09833cdc3efa54641744465aeaaa3c0ed2f9b3952f43e2b08fa4c291 -size 95094 +oid sha256:427f83e084082ff5007e3c4540108103ec20202532329e8d7dace57c4f8e361d +size 95013 |