refs #3359 marked some (now unused) methods as deprecated; small improvements

git-svn-id: http://dev.piwik.org/svn/trunk@7590 59fd770c-687e-43c8-a1e3-f5a4ff64c105

1 files changed, 11 insertions, 24 deletions

diff --git a/plugins/UsersManager/templates/UsersManager.js b/plugins/UsersManager/templates/UsersManager.js
index 17e3ab43c0..6948af6f90 100644
--- a/plugins/UsersManager/templates/UsersManager.js
+++ b/plugins/UsersManager/templates/UsersManager.js
@@ -81,7 +81,6 @@ function sendUpdateUserAccess(login, access, successCallback)
         method: 'UsersManager.setUserAccess'
     }, 'GET');
     ajaxHandler.addParams(parameters, 'POST');
-    ajaxHandler.redirectOnSuccess();
     ajaxHandler.setCallback(successCallback);
     ajaxHandler.setLoadingElement('#ajaxLoadingUsersManagement');
     ajaxHandler.setErrorElement('#ajaxErrorUsersManagement');
@@ -119,29 +118,17 @@ function bindUpdateAccess()
 	// callback called when the ajax request Update the user permissions is successful
 	function successCallback (response)
 	{
-		piwikHelper.hideAjaxLoading();
-		// if the permission couldn't be granted
-		if(response.result == "error") 
-		{
-			piwikHelper.showAjaxError(response.message);
-		}
-		// if the permission change was successful
-		else
-		{
-			piwikHelper.hideAjaxError();
-			
-			$(self).parent().parent().find('.accessGranted')
-				.attr("src","plugins/UsersManager/images/no-access.png" )
-				.attr("class","updateAccess" )
-				.click(bindUpdateAccess)
-				;
-			$(self)
-				.attr('src',"plugins/UsersManager/images/ok.png" )
-				.attr('class',"accessGranted" )
-				;
-			$('#accessUpdated').css('display', 'inline-block');
-			hideAccessUpdated();
-		}
+        $(self).parent().parent().find('.accessGranted')
+            .attr("src","plugins/UsersManager/images/no-access.png" )
+            .attr("class","updateAccess" )
+            .click(bindUpdateAccess)
+            ;
+        $(self)
+            .attr('src',"plugins/UsersManager/images/ok.png" )
+            .attr('class',"accessGranted" )
+            ;
+        $('#accessUpdated').css('display', 'inline-block');
+        hideAccessUpdated();
 	}
 	
 	var idSite = getIdSites();