Visit by hour should show report based on first action time (#13175)

* Visit by hour should show report based on first action time

Just a suggestion. IMO it is way more important to see at what hour you acquired specific users compared to when they dropped off. Especially if you are running certain ads for example etc. We could also add another report "first" and "last action" hour but I think that not both are actually needed and keeping it simple be better.

Performance wise this shouldn't have really any impact as the index be still used in the back by the where statement.

* fixed ui tests

* update screenshots

* update some expected files

* use first action time dimension

* update expected files

* update two more screenshots

2 files changed, 3 insertions, 3 deletions

diff --git a/plugins/VisitTime/Archiver.php b/plugins/VisitTime/Archiver.php
index 30bb3dd869..da0ddb5db1 100644
--- a/plugins/VisitTime/Archiver.php
+++ b/plugins/VisitTime/Archiver.php
@@ -43,7 +43,7 @@ class Archiver extends \Piwik\Plugin\Archiver
 
     protected function aggregateByServerTime()
     {
-        $dataArray = $this->getLogAggregator()->getMetricsFromVisitByDimension(array("label" => "HOUR(log_visit.visit_last_action_time)"));
+        $dataArray = $this->getLogAggregator()->getMetricsFromVisitByDimension(array("label" => "HOUR(log_visit.visit_first_action_time)"));
         $query = $this->getLogAggregator()->queryConversionsByDimension(array("label" => "HOUR(log_conversion.server_time)"));
         if ($query === false) {
             return;
diff --git a/plugins/VisitTime/Reports/GetVisitInformationPerServerTime.php b/plugins/VisitTime/Reports/GetVisitInformationPerServerTime.php
index 2aa2c89fc5..3a2a038755 100644
--- a/plugins/VisitTime/Reports/GetVisitInformationPerServerTime.php
+++ b/plugins/VisitTime/Reports/GetVisitInformationPerServerTime.php
@@ -10,7 +10,7 @@ namespace Piwik\Plugins\VisitTime\Reports;
 
 use Piwik\Piwik;
 use Piwik\Plugin\ViewDataTable;
-use Piwik\Plugins\CoreHome\Columns\VisitLastActionTime;
+use Piwik\Plugins\CoreHome\Columns\VisitFirstActionTime;
 use Piwik\Plugins\CoreVisualizations\Visualizations\Graph;
 
 class GetVisitInformationPerServerTime extends Base
@@ -21,7 +21,7 @@ class GetVisitInformationPerServerTime extends Base
     protected function init()
     {
         parent::init();
-        $this->dimension     = new VisitLastActionTime();
+        $this->dimension     = new VisitFirstActionTime();
         $this->name          = Piwik::translate('VisitTime_ServerTime');
         $this->documentation = Piwik::translate('VisitTime_WidgetServerTimeDocumentation', array('<strong>', '</strong>'));
         $this->constantRowsCount = true;