moved some more dimensions to plugins, fixed some issues, removed some more duplicated code etc. Tests will not be green as there fixes to country detection

3 files changed, 18 insertions, 6 deletions

diff --git a/plugins/VisitorInterest/Columns/Pagespervisit.php b/plugins/VisitorInterest/Columns/Pagespervisit.php
index d16beb449b..a85b8bf71e 100644
--- a/plugins/VisitorInterest/Columns/Pagespervisit.php
+++ b/plugins/VisitorInterest/Columns/Pagespervisit.php
@@ -11,7 +11,7 @@ namespace Piwik\Plugins\VisitorInterest\Columns;
 use Piwik\Piwik;
 use Piwik\Plugin\VisitDimension;
 
-class Pagespervisit extends VisitDimension
+class PagesPerVisit extends VisitDimension
 {    
     public function getName()
     {
diff --git a/plugins/VisitorInterest/Columns/Visitduration.php b/plugins/VisitorInterest/Columns/Visitduration.php
index 6955367892..e483bc7c3a 100644
--- a/plugins/VisitorInterest/Columns/Visitduration.php
+++ b/plugins/VisitorInterest/Columns/Visitduration.php
@@ -11,7 +11,7 @@ namespace Piwik\Plugins\VisitorInterest\Columns;
 use Piwik\Piwik;
 use Piwik\Plugin\VisitDimension;
 
-class Visitduration extends VisitDimension
+class VisitDuration extends VisitDimension
 {    
     public function getName()
     {
diff --git a/plugins/VisitorInterest/Columns/Visitsbydayssincelastvisit.php b/plugins/VisitorInterest/Columns/Visitsbydayssincelastvisit.php
index 075c6e7aae..e64515181d 100644
--- a/plugins/VisitorInterest/Columns/Visitsbydayssincelastvisit.php
+++ b/plugins/VisitorInterest/Columns/Visitsbydayssincelastvisit.php
@@ -10,14 +10,26 @@ namespace Piwik\Plugins\VisitorInterest\Columns;
 
 use Piwik\Piwik;
 use Piwik\Plugin\VisitDimension;
+use Piwik\Plugins\CoreHome\Segment;
 use Piwik\Tracker\Action;
 use Piwik\Tracker\Request;
+use Piwik\Tracker\Visitor;
 
-class Visitsbydayssincelastvisit extends VisitDimension
+class VisitsByDaysSinceLastVisit extends VisitDimension
 {
     protected $fieldName = 'visitor_days_since_last';
     protected $fieldType = 'SMALLINT(5) UNSIGNED NOT NULL';
 
+    protected function init()
+    {
+        $segment = new Segment();
+        $segment->setSegment('daysSinceLastVisit');
+        $segment->setName('General_DaysSinceLastVisit');
+        $segment->setType(Segment::TYPE_METRIC);
+
+        $this->addSegment($segment);
+    }
+
     public function getName()
     {
         return Piwik::translate('VisitorInterest_VisitsByDaysSinceLast');
@@ -25,11 +37,11 @@ class Visitsbydayssincelastvisit extends VisitDimension
 
     /**
      * @param Request $request
-     * @param array   $visit
+     * @param Visitor $visitor
      * @param Action|null $action
-     * @return int
+     * @return mixed
      */
-    public function onNewVisit(Request $request, $visit, $action)
+    public function onNewVisit(Request $request, Visitor $visitor, $action)
     {
         return $request->getDaysSinceLastVisit();
     }