Better segment editor and fixes (#12040)

* column tweak

* fix install

* more tweaks

* rename column to dimension

* various fixes

* added new control expandable select

* starting to refactor segment selector

* make segment editor work again

* use translation keys

* defined some metrics

* set types

* simplify

* simplify

* fix join generator

* add possibility to use custom join table names when using query builder and it uses an inner query

* fix bug in query selector when selecting same field name from different tables twice

* more metadata

* more tweaks

* improve selector

* add possibility to use custom entity names

* also processed archived metrics

* generate sql filter, suggested values callback, and accept values automatically for columns with enums

* several tweaks

* focus search field when opening it

* various tweaks

* added missing method

* format and fix more metadata

* more fixes

* better definition

* define custom filter

* fix definition

* fix various tests

* fix more tests

* fix bug in logquery builder

* fix referrerurl segment was missing

* fix some tests

* fix more tests

* add group

* refactor for better definition

* fix a bug in log query builder when similar columns are used in archiver

* add goal metrics

* various fixes

* make datatable row more flexible

* various fixes and visualization enhancements

* simply segment editor and make it smaller

* remove trailing comma

* various fixes and added new dimension

* fix formatting of returning customer

* added missing primary key

* fixes

* various fixes and improvements

* make sure to update segment definition when selecting a value from auto complete list

* various fixes and more metrics

* more metrics

* more dimensions and fixes

* fix some tests

* fix some integration tests

* update submodule

* fix some system tests

* fix ui tests

* trigger new test run

* fix more ui tests

* fix system tests

* update submodule

* fix categories

* sort segments by category for more consistency

* add custom variables

* some translations and fixes

* add minute segment

* more segments

* added plurals

* added some docs

* fix test

* fix tests

* fix tests

* added suggested values

* fix some tests

* various fixes

* fix more tests

* allow to select segments on any site

* make sure to include file

* added doc block

* fix some system tests

* fix most system tests

* fix ui test

* fix system test

* adjust examples

* added more tests and docs

* no metrics for these dimensions

* added developer changelog and made some classes public api

* some fixes for entity names

* add possibility to set format metrics in test

* more consistency in defining the name

* get idsites only if provided

* fix integration tests

* added another segment for visit start hour and visit start minute

* more clear name for segment

* use old segment name to not break bc

* various fixes

* more test fixes

* fix no suggested values for new segment

* add event value

* for boolean dimensions only sum metric

* update available widgets when updating reporting menu

* Add new segments in developer changelog + typo

* fix system tests

* fix screenshot test

4 files changed, 8 insertions, 23 deletions

diff --git a/plugins/VisitorInterest/Columns/PagesPerVisit.php b/plugins/VisitorInterest/Columns/PagesPerVisit.php
index 0d4bbe1a18..1f52ceedb9 100644
--- a/plugins/VisitorInterest/Columns/PagesPerVisit.php
+++ b/plugins/VisitorInterest/Columns/PagesPerVisit.php
@@ -13,8 +13,5 @@ use Piwik\Piwik;
 
 class PagesPerVisit extends Dimension
 {
-    public function getName()
-    {
-        return Piwik::translate('VisitorInterest_ColumnPagesPerVisit');
-    }
+    protected $nameSingular = 'VisitorInterest_ColumnPagesPerVisit';
 }
\ No newline at end of file
diff --git a/plugins/VisitorInterest/Columns/VisitDuration.php b/plugins/VisitorInterest/Columns/VisitDuration.php
index d0286bedd2..d3f88d4926 100644
--- a/plugins/VisitorInterest/Columns/VisitDuration.php
+++ b/plugins/VisitorInterest/Columns/VisitDuration.php
@@ -13,8 +13,7 @@ use Piwik\Piwik;
 
 class VisitDuration extends Dimension
 {
-    public function getName()
-    {
-        return Piwik::translate('VisitorInterest_ColumnVisitDuration');
-    }
+
+    protected $type = self::TYPE_DURATION_S;
+    protected $nameSingular = 'VisitorInterest_ColumnVisitDuration';
 }
\ No newline at end of file
diff --git a/plugins/VisitorInterest/Columns/VisitsByDaysSinceLastVisit.php b/plugins/VisitorInterest/Columns/VisitsByDaysSinceLastVisit.php
index b83cc9d72a..5415136975 100644
--- a/plugins/VisitorInterest/Columns/VisitsByDaysSinceLastVisit.php
+++ b/plugins/VisitorInterest/Columns/VisitsByDaysSinceLastVisit.php
@@ -10,7 +10,6 @@ namespace Piwik\Plugins\VisitorInterest\Columns;
 
 use Piwik\Piwik;
 use Piwik\Plugin\Dimension\VisitDimension;
-use Piwik\Plugins\CoreHome\Segment;
 use Piwik\Tracker\Action;
 use Piwik\Tracker\Request;
 use Piwik\Tracker\Visitor;
@@ -19,16 +18,9 @@ class VisitsByDaysSinceLastVisit extends VisitDimension
 {
     protected $columnName = 'visitor_days_since_last';
     protected $columnType = 'SMALLINT(5) UNSIGNED NULL';
-
-    protected function configureSegments()
-    {
-        $segment = new Segment();
-        $segment->setSegment('daysSinceLastVisit');
-        $segment->setName('General_DaysSinceLastVisit');
-        $segment->setType(Segment::TYPE_METRIC);
-
-        $this->addSegment($segment);
-    }
+    protected $type = self::TYPE_NUMBER;
+    protected $segmentName = 'daysSinceLastVisit';
+    protected $nameSingular = 'General_DaysSinceLastVisit';
 
     public function getName()
     {
diff --git a/plugins/VisitorInterest/Columns/VisitsbyVisitNumber.php b/plugins/VisitorInterest/Columns/VisitsbyVisitNumber.php
index 7993fb1c24..9a2640af1f 100644
--- a/plugins/VisitorInterest/Columns/VisitsbyVisitNumber.php
+++ b/plugins/VisitorInterest/Columns/VisitsbyVisitNumber.php
@@ -13,8 +13,5 @@ use Piwik\Piwik;
 
 class VisitsbyVisitNumber extends Dimension
 {
-    public function getName()
-    {
-        return Piwik::translate('VisitorInterest_visitsByVisitCount');
-    }
+    protected $nameSingular = 'VisitorInterest_visitsByVisitCount';
 }
\ No newline at end of file