diff options
| author | Thomas Steur <tsteur@users.noreply.github.com> | 2015-11-29 22:21:25 +0300 |
|---|---|---|
| committer | Thomas Steur <tsteur@users.noreply.github.com> | 2015-11-29 22:21:25 +0300 |
| commit | f4a01f1182629983b6b9c29cd618b8c5f3ed3007 (patch) | |
| tree | b87ed49350c2e2078ef7ef7cc8a58d12c24e6eaf /plugins | |
| parent | d54ddc8b9f4d19bb8b4c69dd02776e3766211261 (diff) | |
refs #9299 Make sure both values are lower case when comparing the value
While debugging #9299 I noticed the check is a bit fragile. There is probably no actual issue but if one ever forgets to convert the `$information` to lowercase in referrer detection then Piwik creates many new visits.
Diffstat (limited to 'plugins')
| -rw-r--r-- | plugins/Referrers/Columns/Base.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/plugins/Referrers/Columns/Base.php b/plugins/Referrers/Columns/Base.php index df86b60e65..900c7bba63 100644 --- a/plugins/Referrers/Columns/Base.php +++ b/plugins/Referrers/Columns/Base.php @@ -449,7 +449,7 @@ abstract class Base extends VisitDimension protected function hasReferrerColumnChanged(Visitor $visitor, $information, $infoName) { - return Common::mb_strtolower($visitor->getVisitorColumn($infoName)) != $information[$infoName]; + return Common::mb_strtolower($visitor->getVisitorColumn($infoName)) != Common::mb_strtolower($information[$infoName]); } protected function doesLastActionHaveSameReferrer(Visitor $visitor, $referrerType) |