Fix bug in admin goal form, 'change' event handlers removed because iCheck initialization happened after bindGoalForm global function executed. bindGoalForm was executed after in API page since it does not use $(document).ready(). Now it does.

1 files changed, 14 insertions, 13 deletions

diff --git a/plugins/Goals/templates/_addEditGoal.twig b/plugins/Goals/templates/_addEditGoal.twig
index 94db74df41..dc217c9a66 100644
--- a/plugins/Goals/templates/_addEditGoal.twig
+++ b/plugins/Goals/templates/_addEditGoal.twig
@@ -40,20 +40,21 @@
 		<br />{{ 'General_ForExampleShort'|translate }} {{ 'Goals_IsExactly'|translate("'click'") }} \
 		<br />{{ 'General_ForExampleShort'|translate }} {{ 'Goals_MatchesExpression'|translate("'(.*)_banner'") }}"
     };
-    bindGoalForm();
-
-    {% if onlyShowAddNewGoal is not defined %}
-        piwik.goals = {{ goalsJSON|raw }};
-        bindListGoalEdit();
-
-        {% if idGoal %}
-            editGoal({{ idGoal|e('js') }});
+    $(document).ready(function () {
+        bindGoalForm();
+
+        {% if onlyShowAddNewGoal is not defined %}
+            piwik.goals = {{ goalsJSON|raw }};
+            bindListGoalEdit();
+
+            {% if idGoal %}
+                editGoal({{ idGoal|e('js') }});
+            {% else %}
+                showEditGoals();
+            {% endif %}
         {% else %}
-            showEditGoals();
+            initAndShowAddGoalForm();
         {% endif %}
-    {% else %}
-        initAndShowAddGoalForm();
-    {% endif %}
-
+    });
 
 </script>