diff options
| author | Peter Zhang <peter@innocraft.com> | 2022-06-14 06:03:29 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-14 06:03:29 +0300 |
| commit | ab5a384321903ffdc1be2addfca6364cb53bdb82 (patch) | |
| tree | 1d896812796e05d6e154a41c5aa5e5352e116f0b /plugins | |
| parent | 0d8d469dd88c6aa3009182202e5bea20d31742ac (diff) | |
[UI] goal overview conversion rate not showing correct on the graph (#19324)
* add reload after option change
add reload after option change
* built vue files
* update compute column
update compute column
* Update SeriesPicker.vue
revert changes
* built vue files
* Update test_trackGoals_oneConversionPerVisitshowAllGoalSpecificMetrics_requestedColumns__Goals.get_day.xml
update tests
Co-authored-by: peterhashair <peterhashair@users.noreply.github.com>
Diffstat (limited to 'plugins')
2 files changed, 3 insertions, 3 deletions
diff --git a/plugins/Goals/Columns/Metrics/GoalConversionRate.php b/plugins/Goals/Columns/Metrics/GoalConversionRate.php index f81d188248..d290a961c9 100644 --- a/plugins/Goals/Columns/Metrics/GoalConversionRate.php +++ b/plugins/Goals/Columns/Metrics/GoalConversionRate.php @@ -41,7 +41,7 @@ class GoalConversionRate extends GoalSpecificProcessedMetric public function getDependentMetrics() { - return array('nb_visits', Goals::makeGoalColumn($this->idGoal, 'nb_conversions')); + return array('nb_visits', Goals::makeGoalColumn($this->idGoal, 'nb_conversions'), Goals::makeGoalColumn($this->idGoal, 'nb_visits_converted')); } public function format($value, Formatter $formatter) diff --git a/plugins/Goals/tests/System/expected/test_trackGoals_oneConversionPerVisitshowAllGoalSpecificMetrics_requestedColumns__Goals.get_day.xml b/plugins/Goals/tests/System/expected/test_trackGoals_oneConversionPerVisitshowAllGoalSpecificMetrics_requestedColumns__Goals.get_day.xml index ffb10e4cc0..da38ea469d 100644 --- a/plugins/Goals/tests/System/expected/test_trackGoals_oneConversionPerVisitshowAllGoalSpecificMetrics_requestedColumns__Goals.get_day.xml +++ b/plugins/Goals/tests/System/expected/test_trackGoals_oneConversionPerVisitshowAllGoalSpecificMetrics_requestedColumns__Goals.get_day.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="utf-8" ?> <result> - <goal_1_conversion_rate>0%</goal_1_conversion_rate> - <goal_1_conversion_rate_new_visit>0%</goal_1_conversion_rate_new_visit> + <goal_1_conversion_rate>66.67%</goal_1_conversion_rate> + <goal_1_conversion_rate_new_visit>100%</goal_1_conversion_rate_new_visit> <goal_1_conversion_rate_returning_visit>0%</goal_1_conversion_rate_returning_visit> </result>
\ No newline at end of file |