avoid large amounts of notifications being added to the session (#17736)

* impose limit on notification message size when logging to notifications

* if in memory notification count exceeds max notification size in session, do not attempt to new ones it to the session

* Detect when session was too large to read and provide warning to user.

* add some tests for Notification\ManagerTest.php

* add tests for relevant DbTable members

* Change session data column type to allow larger session data values.

* update to rc3

* trigger new build?

* fix namespace

* fix test namespaces

* bump version correctly

1 files changed, 3 insertions, 0 deletions

diff --git a/tests/PHPUnit/Framework/Fixture.php b/tests/PHPUnit/Framework/Fixture.php
index bb5e33a9bd..8050865eff 100644
--- a/tests/PHPUnit/Framework/Fixture.php
+++ b/tests/PHPUnit/Framework/Fixture.php
@@ -43,6 +43,7 @@ use Piwik\Plugins\UserCountry\LocationProvider;
 use Piwik\Plugins\UsersManager\API as APIUsersManager;
 use Piwik\Plugins\UsersManager\UsersManager;
 use Piwik\ReportRenderer;
+use Piwik\Session\SaveHandler\DbTable;
 use Piwik\SettingsPiwik;
 use Piwik\SettingsServer;
 use Piwik\Singleton;
@@ -392,6 +393,7 @@ class Fixture extends \PHPUnit\Framework\Assert
 
     public static function clearInMemoryCaches($resetTranslations = true)
     {
+        DbTable::$wasSessionToLargeToRead = false;
         Date::$now = null;
         FrontController::$requestId = null;
         Cache::$cache = null;
@@ -411,6 +413,7 @@ class Fixture extends \PHPUnit\Framework\Assert
         \Piwik\Plugins\ScheduledReports\API::$cache = array();
         Singleton::clearAll();
         PluginsArchiver::$archivers = array();
+        \Piwik\Notification\Manager::cancelAllNotifications();
 
         Plugin\API::unsetAllInstances();
         $_GET = $_REQUEST = array();