Track seconds instead of days for "days since" dimensions (#15774)

* Modify dimensions and add tests.

* unfinished debugging commit

* changes to fix test, remove tracker code, add update code

* fix some tests

* fix migration issue

* fixing some tests

* fix some bugs, update some expected test files, remove _idvc from some tests

* start replacing _ects

* Finish seconds since last ecommerce order change.

* fix couple issues

* fix a couple tests

* fix some more tests

* fixing a couple more tests

* apply review feedback

* unfinished commit

* add back dimensions =

* fixing tests & removing some code

* fix some bugs + tests and remove debugging code

* fixing some tests and issues

* Some debugging code for the tracker in case of exceptions.

* debug and fix another issue when tracking visits in the past

* fix test

* update JS and fix several tests

* Fixing more tests.

* Add missing files.

* update expected test files

* Add some unit tests.

* update more expected files

* update more test files

* update more test files

* update changelog and remove _ects query param

* apply review feedback

* fix merge issue

* clearer code

* fix migration issue

* update expected files

* update expected files again

* updating tests

* fix test

* rebuilt piwik.js

* unify previous visitor properties / original visit row approach

* fixing some tests

* Add new column version entries into the option table.

* try undoing 1.5 update change

* apply review feedback

* remove more unused cookie values

* rebuilt piwik.js

* Fix test count.

* update test files

* rebuilt piwik.js

* removel log analytics submodule update

* update submodule

* update some expected screenshots

* Fix versions in omnifixture since we were probably adding to the beta update after it changed.

* update screenshots

2 files changed, 7 insertions, 6 deletions

diff --git a/tests/PHPUnit/Framework/Fixture.php b/tests/PHPUnit/Framework/Fixture.php
index b76a3b1d66..2a7cadaf95 100644
--- a/tests/PHPUnit/Framework/Fixture.php
+++ b/tests/PHPUnit/Framework/Fixture.php
@@ -684,7 +684,8 @@ class Fixture extends \PHPUnit\Framework\Assert
      *
      * @param $response
      */
-    public static function checkBulkTrackingResponse($response) {
+    public static function checkBulkTrackingResponse($response)
+    {
         $data = json_decode($response, true);
         if (!is_array($data) || empty($response)) {
             throw new Exception("Bulk tracking response (".$response.") is not an array: " . var_export($data, true) . "\n");
diff --git a/tests/PHPUnit/Framework/TestDataHelper/LogHelper.php b/tests/PHPUnit/Framework/TestDataHelper/LogHelper.php
index d8d6c5a9a1..7408290736 100644
--- a/tests/PHPUnit/Framework/TestDataHelper/LogHelper.php
+++ b/tests/PHPUnit/Framework/TestDataHelper/LogHelper.php
@@ -30,7 +30,7 @@ class LogHelper
             'location_country' => 'xx',
             'config_os' => 'xxx',
             'visit_total_events' => 0,
-            'visitor_days_since_last' => 0,
+            'visitor_seconds_since_last' => 0,
             'config_quicktime' => 0,
             'config_pdf' => 0,
             'config_realplayer' => 0,
@@ -47,8 +47,8 @@ class LogHelper
             'visit_total_time' => 123,
             'visit_entry_idaction_name' => 0,
             'visit_entry_idaction_url' => 0,
-            'visitor_days_since_order' => 0,
-            'visitor_days_since_first' => 0,
+            'visitor_seconds_since_order' => 0,
+            'visitor_seconds_since_first' => 0,
             'visit_first_action_time' => '2012-01-01 00:00:00',
             'visit_goal_buyer' => 0,
             'visit_goal_converted' => 0,
@@ -101,8 +101,8 @@ class LogHelper
             'location_country' => 'xx',
             'visitor_count_visits' => 0,
             'visitor_returning' => 0,
-            'visitor_days_since_order' => 0,
-            'visitor_days_since_first' => 0
+            'visitor_seconds_since_order' => 0,
+            'visitor_seconds_since_first' => 0
         );
 
         $properties = array_merge($defaultProperties, $properties);