diff options
author | Matthieu Aubry <matt@piwik.org> | 2016-04-19 03:18:17 +0300 |
---|---|---|
committer | Thomas Steur <tsteur@users.noreply.github.com> | 2016-04-19 03:18:17 +0300 |
commit | 823a06ac0d22ccbf14b0b5934707f0c00a6e0eec (patch) | |
tree | aae1c2a0535cc2c59a5da5d77c5bd7fc2b5d9371 /tests/PHPUnit/System/CustomEventsTest.php | |
parent | 030922c1d9e6eea83472d5819e7b88a0454d4f2d (diff) |
Trigger a Goal conversion for "Event matching goals" even when an event is tracked without a URL (#10018)
* use idGoal parameter in system tests
* Trigger a Goal conversion for "Event matching goals" even when an event is tracked without a URL
* Test files for green build
* Add new expected test file
Diffstat (limited to 'tests/PHPUnit/System/CustomEventsTest.php')
-rw-r--r-- | tests/PHPUnit/System/CustomEventsTest.php | 21 |
1 files changed, 12 insertions, 9 deletions
diff --git a/tests/PHPUnit/System/CustomEventsTest.php b/tests/PHPUnit/System/CustomEventsTest.php index 3669d5aa20..f0eef83354 100644 --- a/tests/PHPUnit/System/CustomEventsTest.php +++ b/tests/PHPUnit/System/CustomEventsTest.php @@ -18,6 +18,9 @@ use Piwik\Tests\Fixtures\TwoVisitsWithCustomEvents; */ class CustomEventsTest extends SystemTestCase { + /** + * @var TwoVisitsWithCustomEvents + */ public static $fixture = null; // initialized below class definition /** @@ -83,15 +86,15 @@ class CustomEventsTest extends SystemTestCase 'testSuffix' => '_segmentMatchesEventActionPlay') ), - // eventValue should not match any page view -// array('Actions.getPageUrls', array( -// 'idSite' => $idSite1, -// 'date' => $dateTime, -// 'periods' => $dayPeriod, -// 'segment' => "eventValue>0", -// 'setDateLastN' => false, -// 'testSuffix' => '_eventSegmentMatchNoAction') -// ), + // Goals and events + array('Goals.get', array( + 'idSite' => $idSite1, + 'date' => $dateTime, + 'periods' => $dayPeriod, + 'idGoal' => TwoVisitsWithCustomEvents::$idGoalTriggeredOnEventCategory, + 'setDateLastN' => false) + ) + ); $apiToCallProcessedReportMetadata = array( |