check for valid xml (#12247)

1 files changed, 26 insertions, 0 deletions

diff --git a/tests/PHPUnit/Framework/TestCase/SystemTestCase.php b/tests/PHPUnit/Framework/TestCase/SystemTestCase.php
index 3048352b43..125ca9ed20 100755
--- a/tests/PHPUnit/Framework/TestCase/SystemTestCase.php
+++ b/tests/PHPUnit/Framework/TestCase/SystemTestCase.php
@@ -316,6 +316,11 @@ abstract class SystemTestCase extends PHPUnit_Framework_TestCase
             $processedResponse->save($processedFilePath);
         }
 
+        $response = $processedResponse->getResponseText();
+        if (strpos($response, '<?xml') === 0) {
+            $this->assertValidXML($response);
+        }
+
         try {
             $expectedResponse = Response::loadFromFile($expectedFilePath, $options, $requestParams);
         } catch (Exception $ex) {
@@ -333,6 +338,22 @@ abstract class SystemTestCase extends PHPUnit_Framework_TestCase
         $this->printApiTestFailures();
     }
 
+    protected function assertValidXML($xml)
+    {
+        libxml_use_internal_errors(true);
+        $sxe = simplexml_load_string($xml);
+
+        if ($sxe === false) {
+            $errors = [];
+            foreach (libxml_get_errors() as $error) {
+                $errors[] = trim($error->message) . ' @' . $error->line . ':' . $error->column;
+            }
+            static::fail('Response is no valid xml: ' . implode("\n", $errors));
+        }
+
+        libxml_clear_errors();
+    }
+
     /**
      * @param $requestUrl
      * @return string
@@ -361,6 +382,11 @@ abstract class SystemTestCase extends PHPUnit_Framework_TestCase
             $processedResponse->save($processedFilePath);
         }
 
+        $response = $processedResponse->getResponseText();
+        if (strpos($response, '<?xml') === 0) {
+            $this->assertValidXML($response);
+        }
+
         $_GET = $originalGET;
 
         try {