Fixing build (#13808)

* Rename long files.

* fix test name

* Try to fix several test failures.

* Rename expected files.

* --amend

* Try to fix tests.

* Fix more system tests.

* Fix more tests.

* Add debug log.

* Update CustomAlerts submodule for test fix.

* Fix some more screenshots.

* Fixing more tests.

* Update more expected test files & screenshots.

* Last couple fixes.

* update tagmanager submodule

* update submodule

* update submodule

17 files changed, 35 insertions, 32 deletions

diff --git a/tests/UI/expected-screenshots/EmptySite_emptySiteDashboard_ignored.png b/tests/UI/expected-screenshots/EmptySite_emptySiteDashboard_ignored.png
index fb2cef1273..f702b3c476 100644
--- a/tests/UI/expected-screenshots/EmptySite_emptySiteDashboard_ignored.png
+++ b/tests/UI/expected-screenshots/EmptySite_emptySiteDashboard_ignored.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:3a4392adc20482d1aaa6e5f6c54621b7986f7a09db817e9a668626e46234df32
-size 321537
+oid sha256:76eacf84272b3f21f032d71f6d9c362f16d4555521bfa776fce4a02f7fac0c70
+size 325057
diff --git a/tests/UI/expected-screenshots/GoalsTable_goals_table_abandoned_carts.png b/tests/UI/expected-screenshots/GoalsTable_goals_table_abandoned_carts.png
index 501e21bec0..da9c3ded48 100644
--- a/tests/UI/expected-screenshots/GoalsTable_goals_table_abandoned_carts.png
+++ b/tests/UI/expected-screenshots/GoalsTable_goals_table_abandoned_carts.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:8a9eb0b3f415c945af0ab4724385d1869e4581c3bda7cd156e1ae4dc5692ec06
-size 39199
+oid sha256:587f258e4c53b324b67cf14f7313854151124aa756a23ae5d4f28425a49ffcf2
+size 39433
diff --git a/tests/UI/expected-screenshots/Theme_home.png b/tests/UI/expected-screenshots/Theme_home.png
index 43b3c74214..ce59b2f2c1 100644
--- a/tests/UI/expected-screenshots/Theme_home.png
+++ b/tests/UI/expected-screenshots/Theme_home.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:dbd1c70d53852513051986618c84ad238fcb72f390d11df4d6f46beeea735a99
-size 648280
+oid sha256:b0e7927f8542b760d23166fa7f31e083634cbf718e04b9aedcffe2e2fba76975
+size 637432
diff --git a/tests/UI/expected-screenshots/UIIntegrationTest_admin_home.png b/tests/UI/expected-screenshots/UIIntegrationTest_admin_home.png
index 38d8be92cf..30dbfc6bcb 100644
--- a/tests/UI/expected-screenshots/UIIntegrationTest_admin_home.png
+++ b/tests/UI/expected-screenshots/UIIntegrationTest_admin_home.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:9b68c1038e1b971f1fc3a20f0a099070aed8aa06e7975f6dd57f7e508ff41ae0
-size 135316
+oid sha256:6f581ef2639670db9ed114e6a3caf48828c1cacd951f9d4b2ed6fc5a71f145d3
+size 146226
diff --git a/tests/UI/expected-screenshots/UIIntegrationTest_admin_manage_tracking_code.png b/tests/UI/expected-screenshots/UIIntegrationTest_admin_manage_tracking_code.png
index 06315c1e0d..016aaf4527 100644
--- a/tests/UI/expected-screenshots/UIIntegrationTest_admin_manage_tracking_code.png
+++ b/tests/UI/expected-screenshots/UIIntegrationTest_admin_manage_tracking_code.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:f29b3b308c2cc58c52e53c74b2e382c829c427e6eeeb0349d683f08206e172c9
-size 389096
+oid sha256:0569c53e1801f40edb789530dd8bbca25ae3a4f93998e11d1a5a3158e1c3dd5e
+size 395399
diff --git a/tests/UI/expected-screenshots/UIIntegrationTest_admin_settings_general.png b/tests/UI/expected-screenshots/UIIntegrationTest_admin_settings_general.png
index 056fa0cf17..3e3d2023a1 100644
--- a/tests/UI/expected-screenshots/UIIntegrationTest_admin_settings_general.png
+++ b/tests/UI/expected-screenshots/UIIntegrationTest_admin_settings_general.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:ebd3d2cc498bf2f710fbe629f0302bdc64670dfb50556aea99c0dcdaea10be03
-size 966478
+oid sha256:4f044aa59cec672b06b3ef2d0c22242140b9e78072f66abec430b459f0b7cfb1
+size 959339
diff --git a/tests/UI/expected-screenshots/UIIntegrationTest_api_listing.png b/tests/UI/expected-screenshots/UIIntegrationTest_api_listing.png
index 8f9913d8e0..8a0ebf4d16 100644
--- a/tests/UI/expected-screenshots/UIIntegrationTest_api_listing.png
+++ b/tests/UI/expected-screenshots/UIIntegrationTest_api_listing.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:fc3c326add9d34a8f4f11f65a275b5af485542c6e4627447f123b54bccf70870
-size 5011417
+oid sha256:986c927e45c3101caeb384ae7bbcaec94f5a4e10b139dda2b7a96cb52ff8dfae
+size 5032891
diff --git a/tests/UI/expected-screenshots/UIIntegrationTest_dashboard1.png b/tests/UI/expected-screenshots/UIIntegrationTest_dashboard1.png
index 4097c1bcfa..7e7ceebf76 100644
--- a/tests/UI/expected-screenshots/UIIntegrationTest_dashboard1.png
+++ b/tests/UI/expected-screenshots/UIIntegrationTest_dashboard1.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:b7c3c9aceecf73530ab9401447c71b8a5f695c442ba22ecee69ee34ab83231fb
-size 591784
+oid sha256:04978b1b1fc3ded37d9f1c67ae9dc0f84f5859533cd3736567cd00189fddd2f7
+size 582155
diff --git a/tests/UI/expected-screenshots/UIIntegrationTest_dashboard2.png b/tests/UI/expected-screenshots/UIIntegrationTest_dashboard2.png
index 547ba75371..a1a182763f 100644
--- a/tests/UI/expected-screenshots/UIIntegrationTest_dashboard2.png
+++ b/tests/UI/expected-screenshots/UIIntegrationTest_dashboard2.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:90ee0e072293768cb4b2fa0266e9d94f59d3d32b130d10d2d75bb6dbec396d95
-size 1597892
+oid sha256:f84cd9c91525abcc494e6739926d3245d381f3d9e7d8b9c252fb70a89c51331e
+size 1592120
diff --git a/tests/UI/expected-screenshots/UIIntegrationTest_dashboard3.png b/tests/UI/expected-screenshots/UIIntegrationTest_dashboard3.png
index ba7df8488e..4a5db34553 100644
--- a/tests/UI/expected-screenshots/UIIntegrationTest_dashboard3.png
+++ b/tests/UI/expected-screenshots/UIIntegrationTest_dashboard3.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:33550a953fd5168d2d04f185539062da2995dbad8e622c785b4bf28ae987c665
-size 647044
+oid sha256:32799020646194a048391f05ebedd884ba4d84a896ca64539e01ef7f434a49dd
+size 636768
diff --git a/tests/UI/expected-screenshots/UIIntegrationTest_ecommerce_products.png b/tests/UI/expected-screenshots/UIIntegrationTest_ecommerce_products.png
index b14170bc19..441edfb026 100644
--- a/tests/UI/expected-screenshots/UIIntegrationTest_ecommerce_products.png
+++ b/tests/UI/expected-screenshots/UIIntegrationTest_ecommerce_products.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:625b8e4091be172c8c78748cff1678cac924babd1e7e5525a537c1ceb831097c
-size 48445
+oid sha256:5cbc9b055e0fd9a7a4b4e9988f4c47af751c1519f217a501cabf7c1a4408f7a5
+size 48649
diff --git a/tests/UI/expected-screenshots/UIIntegrationTest_ecommerce_sales.png b/tests/UI/expected-screenshots/UIIntegrationTest_ecommerce_sales.png
index 9331620494..4514167d26 100644
--- a/tests/UI/expected-screenshots/UIIntegrationTest_ecommerce_sales.png
+++ b/tests/UI/expected-screenshots/UIIntegrationTest_ecommerce_sales.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:12bee15c3477663d3fe31a4bcb1cf0cd4179ea7e12a8ab08139ef22b0f72b6f5
-size 88903
+oid sha256:8f68d1249f682d7e871994086177ebd4a887843180ba13d8219fdc80783ed1c9
+size 85875
diff --git a/tests/UI/expected-screenshots/UIIntegrationTest_metric_tooltip.png b/tests/UI/expected-screenshots/UIIntegrationTest_metric_tooltip.png
index 145fd3090f..9c02538f72 100644
--- a/tests/UI/expected-screenshots/UIIntegrationTest_metric_tooltip.png
+++ b/tests/UI/expected-screenshots/UIIntegrationTest_metric_tooltip.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:cf24e23f4f3748ae082da7f386e0c0bcbd526fd40a8886b9629f631eead56ff0
-size 167066
+oid sha256:7f0bd84d9dc2c50097c053318c03d0e2724d2579ea3a366da3223c8032ee5094
+size 167453
diff --git a/tests/UI/expected-screenshots/ViewDataTableTest_11_flattened.png b/tests/UI/expected-screenshots/ViewDataTableTest_11_flattened.png
index 0de08bcb2d..7f3385d419 100644
--- a/tests/UI/expected-screenshots/ViewDataTableTest_11_flattened.png
+++ b/tests/UI/expected-screenshots/ViewDataTableTest_11_flattened.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:6c78cfd16c758911ced0ab428d41b435383e1a03b2a9206c126e16ef7662df96
-size 66668
+oid sha256:7e5e34a9e291df062d6a046a6aa1dc7be9f65c6cb57f307e4af3ecd9727de5ed
+size 66508
diff --git a/tests/UI/expected-screenshots/ViewDataTableTest_related_report_click.png b/tests/UI/expected-screenshots/ViewDataTableTest_related_report_click.png
index f61ee9bc61..ebf3dff684 100644
--- a/tests/UI/expected-screenshots/ViewDataTableTest_related_report_click.png
+++ b/tests/UI/expected-screenshots/ViewDataTableTest_related_report_click.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:e729275c7870adb74cddda26eeeaa0d3d3b6de99a1973a4a1abce0d605ee5857
-size 39004
+oid sha256:3d4b44309d3fc2642d42175ef88cec53b5e43923e3cf49924c5fa446653cee1e
+size 39603
diff --git a/tests/UI/expected-screenshots/ViewDataTableTest_totals_row.png b/tests/UI/expected-screenshots/ViewDataTableTest_totals_row.png
index 6d95fae280..ecca353ef7 100644
--- a/tests/UI/expected-screenshots/ViewDataTableTest_totals_row.png
+++ b/tests/UI/expected-screenshots/ViewDataTableTest_totals_row.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:5d0ec7a07c484886af0f4e783cb4c2eeb7ac6cd908d09895008ef70c1e239b1e
-size 45754
+oid sha256:a5d44aff828bc9f6de654a0974c7aef3d88f321f0e4437be7306398b19b88183
+size 45669
diff --git a/tests/UI/specs/ViewDataTable_spec.js b/tests/UI/specs/ViewDataTable_spec.js
index e1f7a32e2c..9ee13e655f 100644
--- a/tests/UI/specs/ViewDataTable_spec.js
+++ b/tests/UI/specs/ViewDataTable_spec.js
@@ -98,6 +98,7 @@ describe("ViewDataTableTest", function () { // TODO: should remove Test suffix f
         expect.screenshot('11_flattened').to.be.capture(function (page) {
             page.click('.dropdownConfigureIcon');
             page.click('.dataTableFlatten');
+            page.mouseMove({x: -10, y: -10}); // mae sure no row is highlighted
         }, done);
     });
 
@@ -105,6 +106,7 @@ describe("ViewDataTableTest", function () { // TODO: should remove Test suffix f
         expect.screenshot('12_aggregate_shown').to.be.capture(function (page) {
             page.click('.dropdownConfigureIcon');
             page.click('.dataTableIncludeAggregateRows');
+            page.mouseMove({x: -10, y: -10}); // mae sure no row is highlighted
         }, done);
     });
 
@@ -112,6 +114,7 @@ describe("ViewDataTableTest", function () { // TODO: should remove Test suffix f
         expect.screenshot('13_make_hierarchical').to.be.capture(function (page) {
             page.click('.dropdownConfigureIcon');
             page.click('.dataTableFlatten');
+            page.mouseMove({x: -10, y: -10}); // mae sure no row is highlighted
         }, done);
     });