diff options
| author | Stefan Giehl <stefan@matomo.org> | 2022-03-04 12:48:42 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-04 12:48:42 +0300 |
| commit | da4fa4175f7cef7cd93d600487fadad34330468a (patch) | |
| tree | b5a3537af23e61b72378f5e0a5083ba43fadf63c /tests/UI | |
| parent | 2aa54fd73a48b72231f4b5a18d6e2fbe25c04866 (diff) | |
Fix comparison for conversion reports (#18875)
* Ensure goal parameters are forwarded when comparing tables
* add / update UI tests
Diffstat (limited to 'tests/UI')
| -rw-r--r-- | tests/UI/expected-screenshots/Comparison_goals_table.png | 4 | ||||
| -rw-r--r-- | tests/UI/expected-screenshots/Comparison_goals_table_specific.png | 3 | ||||
| -rw-r--r-- | tests/UI/specs/Comparison_spec.js | 8 |
3 files changed, 12 insertions, 3 deletions
diff --git a/tests/UI/expected-screenshots/Comparison_goals_table.png b/tests/UI/expected-screenshots/Comparison_goals_table.png index c25d31e99a..e96ec9a9da 100644 --- a/tests/UI/expected-screenshots/Comparison_goals_table.png +++ b/tests/UI/expected-screenshots/Comparison_goals_table.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:205c3a5c96bd29a40a3d9b3e8770db001effe5578765d55290a89567d8d71dd2 -size 144169 +oid sha256:05f877c6c566eb09aad6ac404d4a0f272703d1c731a40dd77b2649c7ec43b9ec +size 147925 diff --git a/tests/UI/expected-screenshots/Comparison_goals_table_specific.png b/tests/UI/expected-screenshots/Comparison_goals_table_specific.png new file mode 100644 index 0000000000..0f48f1b14b --- /dev/null +++ b/tests/UI/expected-screenshots/Comparison_goals_table_specific.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:522d360bfec1df54f6eafa68cb389f3a580c265b86a95fc78d4abaaf37da3596 +size 167427 diff --git a/tests/UI/specs/Comparison_spec.js b/tests/UI/specs/Comparison_spec.js index ef2989f3f7..39bd8e0e58 100644 --- a/tests/UI/specs/Comparison_spec.js +++ b/tests/UI/specs/Comparison_spec.js @@ -241,12 +241,18 @@ describe("Comparison", function () { expect(await dialog.screenshot()).to.matchImage('segmented_visitorlog'); }); - it('should show the goals table correctly when comparing segments and period', async () => { + it('should show the goals overview table correctly when comparing segments and period', async () => { await page.goto(goalsTableUrl); await page.waitForNetworkIdle(); expect(await page.screenshot({ fullPage: true })).to.matchImage('goals_table'); }); + it('should show a specific goals table correctly when comparing segments and period', async () => { + await page.goto(goalsTableUrl + '&idGoal=1'); + await page.waitForNetworkIdle(); + expect(await page.screenshot({ fullPage: true })).to.matchImage('goals_table_specific'); + }); + it('should load a widgetized sparklines visualization correctly', async () => { await page.goto(visitOverviewWidget); await page.waitForNetworkIdle(); |
