diff options
author | Peter Zhang <peter@innocraft.com> | 2021-10-14 06:43:46 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-10-14 06:43:46 +0300 |
commit | 22f2889e184c4edb3cace946c633821f637d46b6 (patch) | |
tree | 26521bc3bcf4e20a5d3db0d8fa4d8c4ed8a7a2b9 /tests | |
parent | 39fb369f8107d24c96480bfdeea8d9bf2237080a (diff) |
remove remain customer variables and provider unit test (#18148)
Diffstat (limited to 'tests')
4 files changed, 7 insertions, 27 deletions
diff --git a/tests/PHPUnit/Integration/ReleaseCheckListTest.php b/tests/PHPUnit/Integration/ReleaseCheckListTest.php index 7b74515589..2fce4bb392 100644 --- a/tests/PHPUnit/Integration/ReleaseCheckListTest.php +++ b/tests/PHPUnit/Integration/ReleaseCheckListTest.php @@ -40,27 +40,7 @@ class ReleaseCheckListTest extends \PHPUnit\Framework\TestCase parent::setUp(); } - - public function test_CustomVariablesAndProviderPluginCanBeUninstalledOnceNoLongerIncludedInPackage() - { - $pluginsToTest = ['CustomVariables', 'Provider']; - - $pluginManager = Plugin\Manager::getInstance(); - - $package = Http::sendHttpRequest('https://raw.githubusercontent.com/matomo-org/matomo-package/master/scripts/build-package.sh', 20); - - foreach ($pluginsToTest as $pluginToTest) { - $isPluginBundledWithCore = $pluginManager->isPluginBundledWithCore($pluginToTest); - $isPluginIncludedInBuildZip = strpos($package, 'plugins/' . $pluginToTest) !== false; - - if ($isPluginBundledWithCore xor $isPluginIncludedInBuildZip) { - throw new Exception('Expected that when plugin can be uninstalled (is not included in core), then the plugin is also included in the build-package.sh so it is included in the release zip. Once we no longer include this plugin in build.zip then we need to allow uninstalling these plugins by changing isPluginBundledWithCore method. Plugin is ' . $pluginToTest); - } - } - - $this->assertNotEmpty($isPluginBundledWithCore, 'We expect at least one plugin to be checked in this test, otherwise we can remove this test once they are no longer included in core'); - } - + public function test_TestCaseHasSetGroupsMethod() { // refs https://github.com/matomo-org/matomo/pull/16615 ensures setGroups method still exists in phpunit diff --git a/tests/UI/expected-screenshots/UIIntegrationTest_admin_plugins.png b/tests/UI/expected-screenshots/UIIntegrationTest_admin_plugins.png index 7817363f3c..4d13415ed1 100644 --- a/tests/UI/expected-screenshots/UIIntegrationTest_admin_plugins.png +++ b/tests/UI/expected-screenshots/UIIntegrationTest_admin_plugins.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:fb43042a43b151a3ef2102a5314f13216a681e97721d417d892e1047822c1dcd -size 1096783 +oid sha256:25c280086c11c4c73f5d9b348a4500acdb12e52d31e60deb86d625253192fdbd +size 1097487 diff --git a/tests/UI/expected-screenshots/UIIntegrationTest_admin_plugins_no_internet.png b/tests/UI/expected-screenshots/UIIntegrationTest_admin_plugins_no_internet.png index 8e7849e27d..f84d8bd5f2 100644 --- a/tests/UI/expected-screenshots/UIIntegrationTest_admin_plugins_no_internet.png +++ b/tests/UI/expected-screenshots/UIIntegrationTest_admin_plugins_no_internet.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:dfc1006cde299c3f6b4c90fe6f810cdd4cc9d70ca61d8a88d19566bd3af30efc -size 1109309 +oid sha256:00060a907efba2018668c4b777bf4bbe8e567c7e7bbcc0c167c44be707efca61 +size 1109924 diff --git a/tests/UI/expected-screenshots/UIIntegrationTest_fatal_error_safemode.png b/tests/UI/expected-screenshots/UIIntegrationTest_fatal_error_safemode.png index 27effae25d..c403f1ad07 100644 --- a/tests/UI/expected-screenshots/UIIntegrationTest_fatal_error_safemode.png +++ b/tests/UI/expected-screenshots/UIIntegrationTest_fatal_error_safemode.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:6de324d3bb129e788006e48004b194709f6d57a9b428ed574807f38956206009 -size 167828 +oid sha256:85bcb31c09f82578a1c101c79e53e224e55b4b2b4409f3d406922c6b10f88bcd +size 174072 |