Better fetching of saved report parameters by report ID (#11983)

* Better report parameter fetching

* prefer a unique report id

* add method to get id

* removed code that is supposed to be in different PR

1 files changed, 11 insertions, 0 deletions

diff --git a/tests/PHPUnit/Integration/ReportTest.php b/tests/PHPUnit/Integration/ReportTest.php
index 2aed43693b..adfd973c73 100644
--- a/tests/PHPUnit/Integration/ReportTest.php
+++ b/tests/PHPUnit/Integration/ReportTest.php
@@ -329,6 +329,17 @@ class ReportTest extends IntegrationTestCase
         $this->assertEquals($action, $report->getAction());
     }
 
+    public function test_getId_ShouldReturnOnlyReturnModuleAndActionWhenNoParametersSet()
+    {
+        $report = new GetExampleReport();
+        $this->assertEquals('ExampleReport.getExampleReport', $report->getId());
+    }
+
+    public function test_getId_ShouldReturnIncludeParamsIfSet()
+    {
+        $this->assertEquals('TestPlugin.getAdvancedReport_idGoal--1', $this->advancedReport->getId());
+    }
+
     public function test_getSubtableDimension_ShouldReturnNullIfNoSubtableActionExists()
     {
         $report = new GetExampleReport();