Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/matomo-org/matomo.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-06-07[UI]update invalid archive notification (#19126)Peter Zhang
* update archive notification update archive notification * update condition update condition * update condition on message update condition on message * update error update error * Update _unprocessedSegmentMessage.twig update unprocessed * update screenshot update screenshot * update tests and some parts update tests and some parts * update phpcs error update phpcs * update tests update tests * update phpcs update phpcs * update screen shots update screen shots * Update plugins/SegmentEditor/lang/en.json Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/SegmentEditor/templates/_unprocessedSegmentMessage.twig Co-authored-by: Stefan Giehl <stefan@matomo.org> * built vue files * update tests ui screenshot update tests ui screenshot * update tests update tests * Update UnprocessedSegment_spec.js update ui tests * update tests update tests * update tests update tests * update tests update tests * Update UnprocessedSegment_spec.js update tests * Update UnprocessedSegment_spec.js update tests * set full config set full config * update screenshots update screenshots * update screeenshots update screeenshots * Rerun tests Co-authored-by: Stefan Giehl <stefan@matomo.org> Co-authored-by: peterhashair <peterhashair@users.noreply.github.com> Co-authored-by: Ben <ben.burgess@innocraft.com>
2022-05-30Ensure refresh button is only shown where needed (#19292)Stefan Giehl
* Ensure refresh button is only shown where needed * fix some deprecated method calls * improve css * updates expected UI files * fix css * updates expected UI files
2022-05-30[Tests] Fix the UI and lang on pr #19261 (#19286)Peter Zhang
* feat: adds a refresh button this commit introduces a refresh button to every page in the CoreHome module. When the user clicks the button, the data of the current page is refreshed without reloading the page. Refs #11047 * Update _headerMessage.twig update icon and some css * revert de lang revert de lang * update screenshots update screenshots * update screenshots update screenshots Co-authored-by: Andre <aeckardt@outlook.com>
2022-05-30[Vue] reset segment state before update:modelValue… (#19276)dizzy
* reset segment state before update:modelValue so the parent component can decide to let the change go through * fix test (make sure to wait after each individual change for vue logic to execute completely) * fix another multiple input val change in UI test
2022-05-24Show sparkline evolution figures for visits, goals and ecommerce overviews ↵Ben Burgess
(#19057) * Add evolution to sparklines on the visits overview and the goals overview * Add evolution to sparklines on the ecommerce overview * Updated UI test screenshots * Update submodule * Fix for tooltip date formatting, improved translation lookup and callback method extra parameter documentation * Sparklines API calls modified to return unformatted values, formatting added to the sparkline visualization and overview reports * update submodule * Updated inherited method signature * Code improvements, added forcedParams parameter to ViewDataTable / Visualization loadDataTableFromAPI methods * Revert change to loadDataTableFromAPI method signature in ViewDataTable and Visualization classes * Remove incorrectly added file * Improve international handling of plus symbol in ecommerce overview template * Always use gigabytes when formatting byte values for evolution charts * update sumbodule * built vue files * System test updates * UI test screenshot updates * Update submodule * Test fix * Test fixes * Update system tests * Rerun tests * Fix for unformatted metrics when comparing * Update UI test screenshots for sparkline comparisons * apply some fixes * Update submodule Co-authored-by: sgiehl <stefan@matomo.org> Co-authored-by: sgiehl <sgiehl@users.noreply.github.com>
2022-03-31[Vue] migrate segment generator directive to Vue (#18993)dizzy
* start migrating segment generator directive * get to build * remove some TODO * rebuilt * get UI tests to pass * fix ng-model handling * remote todo * built vue files
2022-03-17Knowledge base discoverability improvements (#18944)Justin Velluppillai
* kb discoverability improvements * Made search placeholder translatable * Updated expected test * restore dist files * built vue files * Updated expected test * Update expected tests * More contrast in placeholder * updated UI tests Co-authored-by: justinvelluppillai <justinvelluppillai@users.noreply.github.com>
2022-01-20enable case insensitive on segment search (#18643)Peter Zhang
* Update FieldExpandableSelect.vue enable case insentive * shorter the function shorter the function * built vue files * Update FieldExpandableSelect.vue use toLowerCase * built vue files * add test for auto complete add test for auto complete * Update SegmentSelectorEditor_spec.js use type * Update SegmentSelectorEditor_spec.js update tests * Update SegmentSelectorEditor_spec.js update selector * Update SegmentSelectorEditor_spec.js update selector * Update SegmentSelectorEditor_spec.js update click * Update SegmentSelectorEditor_spec.js update tests * update screenshot update screenshot * update tests update tests * add click before typo add click before typo * Revert "add click before typo" This reverts commit d57771916e60836b7340b7f2ee0c8be4e3434a57. * update tests update tests * Update SegmentSelectorEditor_spec.js update tests * Update SegmentSelectorEditor_spec.js update tests selector * Update SegmentSelectorEditor_spec.js * update tests update tests * Update SegmentSelectorEditor_spec.js update tests * update screenshot update screenshot * Update SegmentSelectorEditorTest_autocomplete_capitalized.png update screen shot Co-authored-by: sgiehl <sgiehl@users.noreply.github.com> Co-authored-by: peterhashair <peterhashair@users.noreply.github.com>
2021-12-22Show a summary of new features (#18065)Ben Burgess
* Added "What is new" notification display, populated by a new event * Removed test example event hook * Added support for applying a link attribute to menu items, fixes layout issue for mobile with html menu items * Updated UI test screenshots * Revert accidental edit * Hide the "What's new" icon if there are no new features to show * Changed to use changes.json, track user last viewed, added ui test * Fix UserManager unit tests broken by new ts_changes_viewed user field * Moved getChanges to separate helper class, added unit test, added user view access check * Updated to add new changes table and populate only on plugin update/install * Added missing fixture class, updated UI screenshots * Updated matomo font to add ringing bell and new releases icons * Fix for integration test * Reworked class structure, removed unnecessary angular directive, merged templates, other tidy ups * built vue files * built vue files * Added null user check, missing table exception handling, show plugin name in change title, better handling of missing change fields * Added sample changes file, moved UserChanges db code to changes model, added return type hints, better db error code handling, various other improvements * Revert accidental UI screenshot commit * Fix for incorrect link name parameter in sample changes, switched back to using $db->query for INSERT IGNORE * Integration test fix, UI screenshot updates * Test fix * Added link styling, show CoreHome changes without plugin prefix in title * Update UI test screenshot * Added styles to the popover, added event for filtering changes * Test fix * UI test screenshot updates Co-authored-by: sgiehl <stefan@matomo.org> Co-authored-by: bx80 <bx80@users.noreply.github.com>
2021-11-16Improvements to the in-app feature rating mechanism (#18280)Ben Burgess
* Changes to in-app feedback mechanism * Fix for dialog close issue * Update plugins/Feedback/API.php Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/Feedback/lang/en.json Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/Feedback/lang/en.json Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/Feedback/lang/en.json Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/Feedback/lang/en.json Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/Feedback/lang/en.json Co-authored-by: Stefan Giehl <stefan@matomo.org> * Added UI tests * UI improvements, shorter questions text, autofocus text field * Layout tweaks * Added custom questions for like choices * Fix for UI tests, added UI screenshot * Updated UI test screenshots * Updated UI test screenshots * Build vue * built vue files * Update plugins/Feedback/lang/en.json Co-authored-by: Stefan Giehl <stefan@matomo.org> * Tidied message validation, text fixes, added privacy policy link * built vue files * Update plugins/Feedback/API.php * Update plugins/Feedback/API.php * built vue files * Added missing selection.json * Restored deleted ReviewLinks which is to be displayed after a positive Rate Feature * built vue files * Added null check for javascript focus call * built vue files * Remove unnecessary inline test check for rate feature feedback mail * Updated UI test screenshot Co-authored-by: Stefan Giehl <stefan@matomo.org> Co-authored-by: bx80 <bx80@users.noreply.github.com> Co-authored-by: sgiehl <sgiehl@users.noreply.github.com>
2021-10-26Updated ui screenshots (#18217)Justin Velluppillai
2021-10-19Fix segment creation fails when enable_create_realtime_segments = 0 (#18181)Stefan Giehl
2021-10-04JavaScript tracker exclude query parameters (#18031)Ben Burgess
Adds a new option to the JavaScript tracker to exclude query parameters from the tracked URL. Co-authored-by: bx80 <bx80@users.noreply.github.com> Co-authored-by: sgiehl <stefan@matomo.org>
2021-09-29Remove "add new segment" selector in segment editor (#17998)Peter Zhang
* simple approach, hide segment by css. complete solution needs to alter the entire js. * UI tests: Fixed UI test failure caused by remove segment selcetor in segment widgets * update html inline style to less, remove UI test for segemtn selector * update mobile view and remove the js test related * remove segment selector related test * trigger js build * fix IE 11 css fix IE 11 * add migration 4.5.0-b2 mysql row format dynamic mysql row format dynamic updates * revert wrong branch change revert wrong branch change * update grid to inline-block update grid to inline-block * update some css update some css * update new screenshot update new screenshot * update one more image update one more image * uploaded the wrong ui uploaded the wrong ui * remove image fix css remove image fix css * update screen shot because of the layout change update screen shot because of the layout change * add no wrap to the display add no wrap to the display * fix the UI on different device fix the UI on different device * update images update images * update segment selector test update segment selector test * update image update image * update segment test update segment test * update js test update js test * update segment screen and test update segment screen and test * update test update test * updates expected screenshots * cleanup css Co-authored-by: Peter Zhang <matomo@Peters-MacBook-Pro.local> Co-authored-by: sgiehl <stefan@matomo.org>
2021-09-08Fix failing UI tests (#17970)Stefan Giehl
2021-09-01Use newer version of Puppeteer for UI tests (#17880)Stefan Giehl
* Use latest version of Puppeteer for UI tests * use newer node on travis * test * use waitForTimeout / waitForSelector instead of waitFor * Handle BC for removed waitFor method * Updates expected UI test files * update submodules * improve/fix some UI tests * Updates expected UI test files * improve/fix some UI tests * update url-parse dependency * simplify some UI tests * update screenshot * avoid using merged assets that are broken * fix expected compare exit code * don't use merged assets for TwoFactorAuth UI tests it seems due to too many requests to login, logout and other pages merging the CoreJS assets somehow fails, and results in returning an empty file. Even the reload fails to serve the correct content, so maybe the file, the content should be written to, is somehow locked. Disabling the merged assets seems to fix this issue for this tests. Locally the tests are also running correctly with merged assets. * improve handling of automatic css / js reloading in UI tests * increase timeouts of TwoFactorAuth UI tests * fix 2fa ui test * revert change * update new screenshot * updates UI screenshots * submodule updates
2021-08-26hide segmented reports are pre-processed (#17882)Tim-Hinnerk Heuer
* hide segmented reports are pre-processed when enable_create_realtime_segments = 0 fixes #15036 * ensure static method because static call fixes #15036 * refactor to use SegmentEditor::isCreateRealtimeSegmentsEnabled() #15036 * hide segmented reports are pre-processed when enable_create_realtime_segments = 0 fixes #15036 * ensure static method because static call fixes #15036 * update ui test for hidden segmented report text #15036 * add ui-test screenshot #15036 * wait for network #15036 * download processed screenshot #15036
2021-02-28delete default in new segment type name (#17277)Zoltan Flamis
* delete default in new segment type name * fix segment selector ui tests
2021-02-17properly encode segment definitions from table so the hash will be the same ↵dizzy
as from query params (#17029) * initial fix * when creating a Segment or getting a segment hash using a segment definition from the segment table, make sure to urlencode so the hash is the same as when we send the segment as a query parameter * try to make segment definition change appear in tests (seems like this is just a test fix? if I undo the changes the new test changes still pass) * add test demonstrating bug * check access in exampleplugin * Add missing use * fix test * better fix * fix tests * fix test * update expected screenshots
2020-11-10Move performance reports to a new page / category (#16673)Stefan Giehl
* Move performance reports to new category * fix tooltips * updates UI test * updates expected test files * updates expected screenshots * Move Performance category after transitions * Make page reports wider * adds nonce to language selector in updater / installation * updates expected test files * Update getLanguagesSelector.twig * change report title to page urls * Hide performance viz on normal page reports (not in widgets) * update tests * updates submodules * fix ui tests Co-authored-by: Thomas Steur <tsteur@users.noreply.github.com>
2020-11-06Fix UnprocessedSegment UI tests (#16676)Stefan Giehl
2020-10-19Adds measuarable settings to disable visits log and visitor profile (#16561)Stefan Giehl
* Adds measuarable settings to disable visits log and visitor profile * updates expected test files * Adds some UI tests to check deactivating visitor log / profile works * code improvements * more ui tests * Adds global system settings to disable visits log / profile * adds UI tests for system setting * updates expected screenshots * code improvement * improve tests * reset custom logo usage after test * updates expected screenshots * use transient cache
2020-10-15Fix icon align of outlinks in datatables (#16492)Stefan Giehl
* Fix icon align of outlinks in datatables * improve styling * Move datatable icons to matomo font * replace icon in multisites report * improve css * improve css so it looks good on all os/browser * small adjustments * Adjust multisites data table * updates expected screenshots * move plus/minus icon one pixel down * move outlink icon one pixel down * updates expected screenshots * improve icon css * increase size of plus/minus icon * updates expected screenshots * updates submodules * fix ui test
2020-07-28Use category display name for segment metadata (#16242)Stefan Giehl
* use category display name for segment metadata * update tests
2020-06-18updates expected UI filessgiehl
2020-06-08Minor npm updates & ui test fixes (#16034)Stefan Giehl
* minor npm updates * fix ui test * submodule update * updates expected UI files
2020-06-08Switch from bower to npm and update JS libraries (#14082)diosmosis
* Starting to replace bower with npm: use updated jquery-ui from npm. * Use jquery from npm./ * Use angular from npm. * Add more angular libraries. * Use chroma-js from npm. * Remove html5shiv, does not appear to be used. * Use iframe resizer library from npm. * Add jquery-mousewheel * Add jquery.dotdotdot from npm. * Get jquery.scrollto from npm. * Get jscrollpane from npm. * Get materialize-css from npm. * Get mousetrap from npm. * Remove ngDialog, as it is no longer used. * Install qrcode.js from npm. * Get sprintf-js from npm. * Get visibillityjs from npm. * Remove bower.json. * Getting parts of matomo to work w/ new versions of libraries installed by npm. * Ignore node_modules subfolders in node_modules since we only use npm for frontend dependencies + fix a test. * Fix button padding. * Fix series picker checkboxes. * Fix karma conf. * Fix CSS in right place. * Fixing more css/less issues. * More test fixes. * Limit selection style fix. * Fix more tests + materializecss issues. * Fix a couple more tests. * Fix annotation styling. * remove error * add ng-dialog files * try to fix some tests * Fix several UI tests. * fixing more build issues * Fix several more tests and issues. * fixing more tests * split ui tests into 3 groups * fix several more issues and tests * Fix some console warnings on chrome. * Updating more test files. * fix some tests * yet more fixes * couple more fixes * another form fix * Fix some tests. * update screenshot * update more expected files * Fix two more form issues. * test commit (travis is not fetching submodules for some reason...) * remove scripts removed in merge * three travis builds * split UIIntegrationTest into multiple suites * lets try this again * updae several expected screenshots * fix some more tests * fix plugin details material select and tabs initiaialization * update screenshots + css fix * re-initialize materialize tabs since we load jquery-ui afterwards for datepicker which unsets materialize tabs * update more screenshots and fix couple more issues * update more screenshots + tweak to test * more fixes and screenshot updates * fix some issues and update more screenshots * update submodules * more fixes + more updated screenshots * more css fixes and test fixes * couple fixes & updated screenshots * update screenshots * fix random failure * Map old bower_component files to new ones in AssetManager. * Remove node_modules from PR and ignore node_modules in .gitignore and remove libs/jquery (adding new required libs). * Update .travis.yml. * update screenshots * fixing some more issues * fix copy pasta * update screenshots * fix more modal issues * Update css & screenshots. * correct close modal calls * fixing more issues * data-target instead of data-activates * fix more tests * trigger build that works? * fix more tests * update submodule * debugging travis * more debugging * try to fix test * fix modal no button click in test * update more screenshots * couple more test fixes * some more fixes and updated screenshots * update screenshots * apply some review feedback * Fix modal centering and initial top position. * apply some more pr feedback * another pr fix * update submodule * remove style * fix color of checkbox mark * Fix centering the popover Note: centering the popover relative to body doesn't work poperly anymore, maybe because of the fixed position of the widget overlay. Using the ui-widget-overlay to position the dialog centered seems to work * ignore line endings check for node modules * updates expected UI files * submodule updates * use minified file of jquery.browser.js * updates expected test files * ensure to hide parent tooltips when row action tooltips are shown * tweak less for datatable navigation * style is only useful for dashboard * update some screenshots * update submodules Co-authored-by: sgiehl <stefan@matomo.org>
2020-04-19Run tests on bionic distribution & run AllTests with PHP 7.4 (#15720)Stefan Giehl
* run tests on php 7.4 / xenial * composer update * fix lfs check * adjust travis.yml * adds distribution param * update submodule * update travis.yml * fix icon tests * Fix array access error on PHP 7.4 * fix test * avoid usage of deprecated assertArraySubset * convert expectedException annotations * avoid error on php 7.4 * Use assertion instead of conditional expection * add separat expected test result asserialize output changed for PHP7.4 * updates expected ui files * fix ui test * run UI tests on xenial dist * updates expected ui files * Update core/DataTable/Renderer.php * updates expected UI files * submodule update
2020-04-17New page performance reports (#15736)Stefan Giehl
* Adds various new performance metrics and dimensions * Adds tracking for new performance values * track performance metrics only for page views * Archive new performance metrics * move everything into a new plugin * fix archiving of overall metrics * Adds new overview reports * show performance metric on some more reports * adds new page performance icon * Adds new row action to view page performance evolution for pages * Adds new stacked bar visualization for page performance evolutions * show total value in stacked bar chart tooltips * [TEMP] use php tracker package branch * Adds some simple System tests * Adds some UI tests * remove performance metrics from action reports that don't support it * move calculation to api * mark as tracker plugin * improve calculation of maximum value in bar evolution chart * enrich existing tests with performance metrics * updates expected test files * send performance metrics with the next request after they are available this might not be the pageview it self but any request after it, like a ping, goal, ... * Adds request processor to process performance metrics not sent directly with the page view * rebuilt js * Add metric decriptions to evolution chart documentation * fix convertion of microseconds part * Ensure average page load time is displayed in evolution graph in scheduled reports * fix some more tests * move page performance overview to visitors overview * Adds new table with performance metrics visualization * Adds some additional information to page performance evolution overlay * update omnifixture * updates expected UI files * Use mediumints for new dimensions * Adds additional permission check * Encode label in page performance overlay title * Improve updating performance metrics in later requests * Adds some integration tests * improves metric documentations * Send already available performance data with page view request * update tests * updates expected UI test screenshots * updates expected test files * improves archiving * show page generation time in performance metrics table if matomo was installed before 4.0 * Hide page generation time in ui reports if Matomo was installed after 4.0 * Fix removal of unavailable columns from being displayed that was done too early in the process causing to be overwritten again by the reports configureView * do not track automatically calculated generation time any more * split latency into network and server time * [TEMP] update php tracker * rebuilt piwik.js * Ensure to count zero values as hits * updates Omnifixture * updates expected test files * remove possibility to set generation time * rebuilt piwik.js * adjust tests * update php tracker * update test logs * submodule * update Omnifixture * show page load time in action tooltip and visitor summary instead of generation time * updates expected ui files * mark page generation time metric as deprecated * fix tests * [TEMP] use submodule branches * ensure lower metric values are shown as better * use 4.x-dev branch of php-tracker * update submodules
2020-04-02use latest puppeteer for screenshot testing (#15767)Stefan Giehl
* use latest puppeteer for screenshot testing * updates expected UI screenshots
2020-03-24Regenerates Omnifixture (#15520)Stefan Giehl
* updates Omnifixture * fix some namespaces * updates some outdated urls * use correct method * update expected UI files * ensure popover param is not sanitized * try to fix one click update ui test until 4.x stable release * fix jstracker ui test * set now timestamp for realtime test * replace some changing ids to avoid changes on omnifixture update * ui files
2020-03-23Remove user alias from DB (#15714)Thomas Steur
* Remove alias * fix more tests * fix more system tests * fix ui tests * add to developer changelog * fix typo
2020-03-09By default a segment should be visible to all users (#15649)Thomas Steur
* By default a segment should be visible to all users @mattab any thoughts? Got this feedback yesterday on a call and I think it makes sense to share segments across the teams as mostly they will be wanting to use the same segments and it avoids everyone creating their own/similar segments. * fix ui tests
2019-12-24ProxySite related changes to let comparisons work properly (#15265)diosmosis
* Make sure ProxySite will disable post processor in Visualization where API Proxy is called directly. * Use Request::process so events are used. * Remove disable_datatable_post_processing, since it will propagate. * Only disable for root API request. * Move nestedApiInvocationCount increment to top of method. * Directly filter referrer type labels since there are a small number of them (helps comparison & proxysite). * Fix regression. * Update expected test files. * Another regression fixed. * Try to fix build again. * fix tests
2019-12-21Make sure unprocessed segment notification is still shown and include ↵diosmosis
notifications in UI test. (#15296)
2019-12-09remove unnecessary number format in visit summary (#15218)Stefan Giehl
* remove unnecessary number format in visit summary * updates UI tests
2019-11-08Rename "Clicked URL" dimension to "Clicked Outlink" (#15088)Kate Butler
* Rename Clicked URL to Clicked Outlink * Fix system and UI tests * Update screenshots
2019-10-07Add "test" button to segment editor (#14884)Kate Butler
* Take user to the visitors log after adding new segment from segmented visitors log * Apply segment when displaying visitor log while creating new segment * Add the test segment button * Fix JS error * Remove debugger statements * Display test visitor log in popover when user clicks Test Segment button * Update test screenshots * Hide datatable controls on popover visitor log; prevent Esc key from closing segment editor when popover is open * Close "test" popover when user presses escape key * Close the PiwikPopover when user clicks away from it
2019-10-02Proper encoding of segment values for Actions reports. (#13481)diosmosis
2019-09-30Compare segments and periods (in API and UI) (#14365)diosmosis
* Allow row metadata to be datatables in API output. * Fill out initial DataComparisonFilter. * fixing some issues * couple more fixes * couple more fixes + initial system test * more fixes * Finish up segment comparison system test and get to pass. * Soft limit for number of segments/periods. * Add supportsComparison method. * Add UX code for adding/removing/seeing data comparisons + code to forward query parameters in AJAX requests + allow broadcast to handle multi-value query param values. * Start showing comparison tables in html tables. * Adding all comparison rows to html table visualization and adding "all visits" segment translation and add currently selected segment to comparisons table. * Show totals ratio for comparison rows. * finished poc html table visualization support for comparison * start working on comparisons support in graph visualizations * Some UX tweaks to htmltable and add comparisons to bar/pie graphs. * Getting comparisons to work in evolution graphs. * Get row evolution to work properly in comparison table. * Get segmented visitor log to work in comparison tables. * Fix regression in comparisons in evolution graph. * Get comparisons to work in actions datatable, fix twig issue that results in 100% cpu usage (when reading dataTable param w/ many rows & comparison tables), get overlay/transitions icons to appear, overlay should work properly. * Get transitions and overlay to work in comparison rows. * Fixing some datatable API output issues, fixing tests, support comparisons in subtables by forcing idSubtables of comparisons to be sent in request (makes UI work, but not pracitcal for API). * Remove typo. * apply original change * Allow All Visits default segment to be compared. * working on disabling currently compared segments. * Get currently compared segments code to work. * starting on refactoring datacomparisonfilter * Most of refactor done. * Get tests to pass and fix a bunch of datatable metadata consistency issues. * Modify evolution graph to modify compare parameters and show some sort of accurate comparison line graphs. * Set xaxis labels correctly in tooltips and make sure series data for comparisons is set correctly. * more fixes to displaying evolution comparisons where compared date ranges vary in length + make sure normal reports w/ no data display the no data message even when comparing * Show period type in comparison card. * Unsanitize compare segments. * Get correct period count. * Couple more fixes to evolution graph series labels, but still wonky. * Include comparison series label in comparison output so evolution graph has an easier time of building series data. * For multi period vs multi period show correct compareDate/comparePeriod for child tables. * Redesign period selector comparison section and get to work. * Allow plugins to disable comparisons for specific pages. * Start supporting comparison in sparkline visualization. * Get sparkline points & lengths to work correctly when comparing. * Fix comparison enabling check. * Pick series and shade colors. * Rewriting comparison card to show individual serieses. * Rewrite comparisons cards to only show segments as cards and individual serieses inside the cards. * Use comparison colors and shades in evolution graph + fix a couple bugs. * Tweak series colors and fix a couple regressions to comparison totals calculation. * Add ratio tooltip suffix explaining comparison percent. * fix typo * Forward comparison params in report export. * tweak series colors again + add tooltip with visitssummary metrics to comparison rows + fix a bug in using array query params in piwik-api + fix bug in formatting of comparison table metrics * Tooltip fixes, start on sparklines supporting comparison, modify comparison filter to only calculate change metrics against periods since they are time related. * Sparkline comparison support. * Tweak line thickness and set metric index properly in jqplot data generator. * In sparklines comparison, show evolution for compared period, rewrite top tooltip to be better, fix tooltip issues when multiple metrics used in evolution graph, and get comparison to previous period to work. * Update submodule * Make things look ok w/ a very long segment name, add numbers to compared datatable row labels, fix pie chart colors + a couple other regressions. * more bug fixes * Fix query param retrieval issue. * Do not throw if no comparison params specified, just do nothing. * try to fix a couple warnings * Another query param get fix. * Do not save comparison parameters. * pass by reference * fix JS error * DO not set compare params if not set in URL for dashboard widgets. * Fix comparison table styling in dashboard. * Expand bar graph if there are too many bars when comparing. * tweak comparison bar graph sizing * make sure flatten works w/ comparison * Apply compute processed metrics to comparison tables. * Hack to get Goals.get to be formatted during comparison. * Fix ordering of yunits in evolution graph. * If rows are selected, incorporate into comparison series names. * Format revenue properly in goals comparison sparklines. * First working attempt at adding Referrers.get method for use w/ Sparklines visualization. * get referrers sparklines to work w/ comparison * Finish using new referrers API method and get referrers sparklines/evolution graph to play well w/ each other in comparison mode. * Simplify table comparison view if only comparing periods, no segments. * Take into account visible rows when calculating series metric index. * Get comparison to work when totals rows are added to tables. * Show series color in evolution graph tooltip. * Fix error when loading row evolution/segmented visitor log for compared ranges. * fix regression in normal subtable loading * Fix row style * Forward comparisonIdSubtables parameter if present so it is used when changing limit/offset * Initialize the row index prefix to the filter offset. * Do not show period header if only segments compared in table. * Add UI tests and fix issues so they pass locally. * quick tweak * Fix PHP error * Updating screenshots * Fixing several bugs and updating expected screenshots. * Fix comparison tests and clear some TODO. * Prefix referrers metrics. * Revert "apply original change" This reverts commit 8f6ceb0430e5c7306a777498199ad7db21fd7175. * Show period label if comparing two periods of same type. * segment sanitization fixes * More segment fixes. * Another fix to the tooltip. * Fix related reports when comparing + make totals tooltip clearer + store segment + pretty title in datatable metadata so it does not have to be looked up every time. * Allow disabling comparisons for individual uses of visualizations. * Remove limit on hover for actions tables + fix subtable expansion for normal actions tables. * Make sure parameters are arrays. * Stricter check for empty parameters. * Allow first compared segment to be "removed". * several more fixes * Fixing table cell alignment and width and everything else that broke while making changes (hopefully). * Several fixes, including xss fixes and test fixes and bug fixes for comparisons. * more table css tweaks * Correct workings of previous period/year comparison + always convert periods to ranges when comparing in evolution graph. * Correct workings of previous period/year comparison + always convert periods to ranges when comparing in evolution graph + more css tweaks. * fix more test regressions * Forgot to add file * fix several TODO as well ass get comparison sparklines to have right colors in widgets. * Use DataTable metadata instead of getting available segments. * When comparing periods that do not uniformly support unique visitors, do not display unique visitors metric. * Small refactor and make sure sparklines shows over period w/o using lastN. * more refactoring and fixes * some more refactoring * Move comparison index math to helper methods. * Use piwikUrl.getSearchParam * Process comparison tables like normal tables in API.getProcessedReport. * remove some code redundancy * use new format date method * Add first working unit test for comparisons service. * Finish writing unit test for comparison service. * refactor comparisons service and fix a couple regressions * Fix more TODO items and refactoring. * Fill out more TODO. * Remove more TODO. * Fixing some tests. * another test fix * FIx some more tests. * More test fixes and regression fixes. * Do not add segments to summary rows in actions reports. * more test fixes * fix more tests * more test fixes * Fixing more tests. * Fixing more tests + debugging failing one. * Fix twig loop issue * Make sure empty compare params are not used in URL. * Remove cached request array. * Support comparison rows in multirow evolution popover and LabelFilter. * Tweak placement of some icons. * Forward current segment in reporting menu links. * Fix for split dimension view. * tweak css * Add more tests. * Add year to xlabels in evolution graph (but not xaxis tick). * applying review feedback * Apply more PR feedback * remove debugging code * tweak event docs * Fix test. * fix some test * fix a test and regression * updating tes files + fixing test * Fix regression * Fix dropdown z-index issue (or workaround really). * Fixing tests again. * Update screenshots * Fix bug and remove some debugging code * Apply review feedback. * Make sure ratio tooltips show in widgetized mode. * Fix some UI tests. * Fix tests * Fix a couple more tests.
2019-09-13Update shown logo in the app (#14860)Thomas Steur
* start changing the logo * update logo * improve position of logo * position link instead of logo * seems margin is not allowed, try using padding * fix some tests
2019-08-20Show series picker in evolution chart always on the left (#14783)Stefan Giehl
* Show series picker always on the left * updates expected UI files
2019-08-17Show marketplace in reporting menu (#14738)Thomas Steur
* show marketplace in reporting menu * also include other widgets * show more pages in the reporting menu * fix tests * fix screenshots * Update screenshot files and try to fix random failure. * fix test
2019-08-14Freeze left-hand column of data table (#14594)Kate Butler
* Freeze left-hand column of data table * Freeze left-hand column of datatable * Don't use position-absolute on first th as it messes with column placement. * Use a spacer column to prevent label column from overlapping with first value column * Set margin of second td * Use position:sticky * Fix missing border in Safari/Firefox * Cross-browser fixes * Increase space available for first data column * Don't put dataTableScroller around non-HTML table vizs * Only apply negative margin/width to datatables in widgets * Reduce border radius to adjust for border-collapse: separate * Updated reference screenshots * UI test fixes * Don't let live widget overflow dashboard card * Updated reference images * Reduce left margin to make data action icons visible on smaller screens * Update reference images * Back out change to TestSetupFixture (should not have been committed on this branch) to avoid merge conflicts * Update UI screenshots
2019-07-25Updates npm dependencies for screenshot testing (#14680)Stefan Giehl
* Updates npm dependencies for screenshot testing * updates expected screenshots * improve some randomly failing tests * avoid feedback popup in tests * fix integration test * updates screenshot
2019-07-16Keep top level nb_visits_converted metric (#14253)diosmosis
* Do not remove nb_visits_converted when archiving goal reports since it should differ from sum of conversions. * If metric is not available, compute dynamically by using max nb_visits_converted. * Ignore abandoned cart conversions when calculating visit converted. * In case goals column is empty. * remove processed metric code since it is not correct * do not remove visits converted metric for overview * fix tests * Fixing test * fix test * update test files * update submodules * Update expected screenshots & try to fix some random failures. * Update expected UI test export results. * two ui test fixes * Fix couple UI test failures. * fix random php test failure
2019-05-09Switch UI tests from phantomjs to chrome headless (#14421)Thomas Steur
* Make sure xss entries is always an array. * Update expected test files and submodule. * Regenerate broken omnifixture dump. * poc conversion to chrome headless for UI tests, single test works locally * Get single test to pass on travis & local w/ headless chrome. * Remove old diff viewer generation, and get output to look the same as before when there is a failure. * Add global timeout & get ViewDataTableTest to pass. * Convert BarGraph_spec.js. * Convert EmptySite_spec. * Update EvolutionGraph spec for chrome headless. * Convert GoalsTable test & find/replace for common changes. * Convert MeasurableManager. * Another find & replace. * Get Menus/OptOutForm to pass w/ chrome headless * Convert PeriodSelector, PieGraph & PivotByDimension UI tests. * undo unrelated debugging change * Convert QuickAccess UI tests * Converts ActionsDataTable UI tests * reset viewport after each testsuite * Converts RowEvolution UI tests * Converts Theme UI tests * Converts SiteSelector UI tests * Converts CustomVariables UI test * Converts DBStats UI test * Ignore empty responses when calling api/controller * Converts Dashboard UI tests * Converts Live UI tests * Converts SimpleUI tests * Converts Installation UI tests * Converts ImageGraph UI tests * Converts Login UI tests * Converts Marketplace UI tests * Converts Insights UI tests * Converts ReportExporting UI tests * Converts UIIntegration tests * Updates ViewDataTable UI tests * Converts CoreUpdater UI tests * Converts UsersManager UI tests * Converts Morpheus UI tests * Converts MultiSites UI tests * Fix testEnvironment.callApi handling of array parameters * Converts Overlay UI tests * Converts PrivacyManager UI tests * Converts ScheduledReports UI tests * Converts SegmentEditor UI tests * compare pixel difference in images * Converts PeriodSelector UI tests * allow a pixel difference * Converts SingleMetricView UI tests * Converts SitesManager UI tests * Converts Transitions UI tests * Converts MeasurableManager UI tests * Move Mouse out of screen after each test suite * Converts PieGraph UI tests * Ensure cursor is not shown in focused input elements * Converts VisitorMap UI tests * Converts CustomLogo UI tests * Converts BarGraph UI tests * Converts EvolutionGraph UI tests * Converts IntranetMeasurable UI tests * Converts TrackingFailures UI tests * Converts CampaignBuilder UI tests * Converts TagManagerTeaser UI tests * fix request url rewrite for changed port * Converts TwoFactorAuth UI tests * do not print full responses in logs, but size instead * improve additional style injection * use submodule branches * fix request interception * update dependencies * [TEMP] disable dangerous link checks * [TEMP] limit tests * Use puppeteer@next and make sure diffs get uploaded properly. * Use correct fs function. * Allow timeout to be specified on command line for UI tests and debug console logs. * timeout option tweak * Setup diff dir once before running tests not before each suite. * fix last commit * Update screenshots and fix some specs. * Convert some tests that were not converted during merge. * updating screenshots * Updating screenshots and fixing some tests. * more test fixes * couple more test fixes * More test fixes and plugin updates. * wait for jquery * Fix some screenshots and tests. * more test fixes * debug travis test failure * remove .only * more test fixes and updated expected files * another test fixing iteration * typo * another quick test change * more tests updates * Test fixes and & more debugging. * more debugging and test fixes * more fixes and debugging. * remove .only * Another round of fixed tests. * more debugging & fixes * more test changes * more debugging and fixes * Fixing more tests + some bug fixes. * Couple more fixes. * Couple more fixes. * Fixing tracking failures test * more fixes * Last couple fixes hopefully. * couple more test fixes * more fixes, bug fix in usersmanager, some test updates * Some more test fixes/changes. * more and more fixes * hoping for a green build * Do not compare against existing files in dashboard_spec. * more fixes, re-enabling travis * really re-enable travis * Install puppeteer on travis-ci. * more fixes * try to fix random failues * remove return * Convert some login tests I forgot and update UsersManager expected file * Fix test for primary key update * Update AddPrimaryKey.php * More test fixes + implement synchronous comparison threshold (so no resemblejs) * More wait fixes + reset token detection fix. * couple more fixes * Fix login/overlay screenshot issue & magick command running issue. * identify is the executable on travis (hopefully) + fix some random failures * Another run. * Last fix. * two more tweaks * typo
2019-02-23Updates plugin submodules (#14131)Stefan Giehl
* updates plugin submodules * update UI tests * update submodule
2019-01-22Add UI test for complex segment + fix couple bugs to get test to pass. (#13909)diosmosis
* Add UI test for complex segment + fix couple bugs to get test to pass. * fix test
2018-11-14Fix build which fails with new theme (#13713)Thomas Steur
* fix some tests * fix more tests * fix more tests