From 2ed6ba170115bd1b159b834cc7ea6586f82dc144 Mon Sep 17 00:00:00 2001 From: mattab Date: Mon, 14 Mar 2016 14:39:44 +1300 Subject: Refs #9842 Add Unit test showcasing the issue --- tests/PHPUnit/Unit/UrlHelperTest.php | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tests/PHPUnit/Unit/UrlHelperTest.php b/tests/PHPUnit/Unit/UrlHelperTest.php index cc15d6eeb1..4a009d90d1 100644 --- a/tests/PHPUnit/Unit/UrlHelperTest.php +++ b/tests/PHPUnit/Unit/UrlHelperTest.php @@ -224,6 +224,15 @@ class UrlHelperTest extends \PHPUnit_Framework_TestCase $this->assertEquals('segment=pageTitle!@%40Hello%20World;pageTitle!@Peace%20Love%20', UrlHelper::getQueryFromUrl('/?segment=pageTitle!@%40Hello%20World;pageTitle!@Peace%20Love%20', array())); } + public function test_getQueryFromUrl_whenUrlParameterIsDuplicatedInQueryString_returnsLastFoundValue() + { + // Currently when the same parameter is used several times in the query string, + // only the last set value is returned by UrlHelper::getParameterFromQueryString + // refs https://github.com/piwik/piwik/issues/9842#issue-136043409 + $this->assertEquals('blue', UrlHelper::getParameterFromQueryString('selected_colors=red&selected_colors=blue&par3=1', 'selected_colors')); + $this->assertEquals('selected_colors=red&selected_colors=blue&par3=1', UrlHelper::getQueryFromUrl('http:/mydomain.com?selected_colors=red&selected_colors=blue&par3=1', array())); + } + /** * @group Core */ -- cgit v1.2.3