From 57b33215b7c5b455468da65f370fefd2d13beed2 Mon Sep 17 00:00:00 2001
From: Stefan Giehl <stefan@matomo.org>
Date: Wed, 9 Nov 2022 02:44:15 +0100
Subject: Avoid double formatting of conversion rate in comparison mode
 (#19970)

---
 plugins/Goals/Reports/Get.php | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/plugins/Goals/Reports/Get.php b/plugins/Goals/Reports/Get.php
index 9e73143cea..5a57c1d3d8 100644
--- a/plugins/Goals/Reports/Get.php
+++ b/plugins/Goals/Reports/Get.php
@@ -140,15 +140,18 @@ class Get extends Base
             ]);
 
             // Adding conversion rate as extra processed metrics ensures it will be formatted
-            $view->config->filters[] = function (DataTable $t) {
-                $extraProcessedMetrics = $t->getMetadata(DataTable::EXTRA_PROCESSED_METRICS_METADATA_NAME);
+            // This is not done when comparing, as comparison does its own formatting
+            if (!$view->isComparing()) {
+                $view->config->filters[] = function (DataTable $t) {
+                    $extraProcessedMetrics = $t->getMetadata(DataTable::EXTRA_PROCESSED_METRICS_METADATA_NAME);
 
-                if (empty($extraProcessedMetrics)) {
-                    $extraProcessedMetrics = [];
-                }
-                $extraProcessedMetrics[] = new ConversionRate();
-                $t->setMetadata(DataTable::EXTRA_PROCESSED_METRICS_METADATA_NAME, $extraProcessedMetrics);
-            };
+                    if (empty($extraProcessedMetrics)) {
+                        $extraProcessedMetrics = [];
+                    }
+                    $extraProcessedMetrics[] = new ConversionRate();
+                    $t->setMetadata(DataTable::EXTRA_PROCESSED_METRICS_METADATA_NAME, $extraProcessedMetrics);
+                };
+            }
 
             $allowMultiple = Common::getRequestVar('allow_multiple', 0, 'int');
 
-- 
cgit v1.2.3