From 19c46aaaf366edad3454c0c8e717cfef057f0136 Mon Sep 17 00:00:00 2001 From: diosmosis Date: Sat, 18 Apr 2015 23:50:21 -0700 Subject: Fix TrackerTest.php (includes fix to RequestCommand due to cache use in UrlHelper::getArrayFromQueryString). --- core/UrlHelper.php | 3 +++ 1 file changed, 3 insertions(+) (limited to 'core/UrlHelper.php') diff --git a/core/UrlHelper.php b/core/UrlHelper.php index 20501515f2..bcea3c979f 100644 --- a/core/UrlHelper.php +++ b/core/UrlHelper.php @@ -156,6 +156,9 @@ class UrlHelper return array(); } + // TODO: this method should not use a cache. callers should instead have their own cache, configured through DI. + // one undesirable side effect of using a cache here, is that this method can now init the StaticContainer, which makes setting + // test environment for RequestCommand more complicated. $cache = Cache::getTransientCache(); $cacheKey = 'arrayFromQuery' . $urlQuery; -- cgit v1.2.3