From 1d1a5acaf20d3f8f25c99386261731a42ef7b36f Mon Sep 17 00:00:00 2001 From: Thomas Steur Date: Fri, 5 Jun 2020 09:03:27 +1200 Subject: Do not generate crossdomain link when cookies are disabled (#16017) --- js/piwik.js | 6 +++++- js/piwik.min.js | 8 ++++---- 2 files changed, 9 insertions(+), 5 deletions(-) (limited to 'js') diff --git a/js/piwik.js b/js/piwik.js index 1ba2d01853..4783eba905 100644 --- a/js/piwik.js +++ b/js/piwik.js @@ -4371,7 +4371,7 @@ if (typeof window.Piwik !== 'object') { function getCrossDomainVisitorId() { - var visitorId = getValuesFromVisitorIdCookie().uuid; + var visitorId = trackerInstance.getVisitorId(); var deviceId = makeCrossDomainDeviceId(); return visitorId + deviceId; } @@ -4392,6 +4392,10 @@ if (typeof window.Piwik !== 'object') { return; } + if (!trackerInstance.getVisitorId()) { + return; // cookies are disabled. + } + // we need to remove the parameter and add it again if needed to make sure we have latest timestamp // and visitorId (eg userId might be set etc) link = removeUrlParameter(link, configVisitorIdUrlParameter); diff --git a/js/piwik.min.js b/js/piwik.min.js index cbb26ab437..73bf10e1b9 100644 --- a/js/piwik.min.js +++ b/js/piwik.min.js @@ -46,10 +46,10 @@ if(dk){for(dl=0;dl0){dm=parseInt(dm,10);dq(dm)}})}var bC={enabled:true,requests:[],timeout:null,interval:2500,sendRequests:function(){var di=this.requests;this.requests=[];if(di.length===1){bF(di[0],bJ) -}else{de(di,bJ)}},canQueue:function(){return !m&&this.enabled},pushMultiple:function(dj){if(!this.canQueue()){de(dj,bJ);return}var di;for(di=0;di0){dm=parseInt(dm,10);dq(dm)}})}var bC={enabled:true,requests:[],timeout:null,interval:2500,sendRequests:function(){var di=this.requests; +this.requests=[];if(di.length===1){bF(di[0],bJ)}else{de(di,bJ)}},canQueue:function(){return !m&&this.enabled},pushMultiple:function(dj){if(!this.canQueue()){de(dj,bJ);return}var di;for(di=0;di0){if(!J(dj)){dj=""}if(!w(dj)){dj=String(dj)}bm[di]=dj}};this.getCustomDimension=function(di){di=parseInt(di,10);if(di>0&&Object.prototype.hasOwnProperty.call(bm,di)){return bm[di] }};this.deleteCustomDimension=function(di){di=parseInt(di,10);if(di>0){delete bm[di]}};this.setCustomVariable=function(dj,di,dm,dk){var dl;if(!J(dk)){dk="visit"}if(!J(di)){return}if(!J(dm)){dm=""}if(dj>0){di=!w(di)?String(di):di;dm=!w(dm)?String(dm):dm;dl=[di.slice(0,bt),dm.slice(0,bt)];if(dk==="visit"||dk===2){cE();aQ[dj]=dl}else{if(dk==="page"||dk===3){bW[dj]=dl}else{if(dk==="event"){cm[dj]=dl}}}}};this.getCustomVariable=function(dj,dk){var di;if(!J(dk)){dk="visit"}if(dk==="page"||dk===3){di=bW[dj]}else{if(dk==="event"){di=cm[dj]}else{if(dk==="visit"||dk===2){cE();di=aQ[dj]}}}if(!J(di)||(di&&di[0]==="")){return false}return di};this.deleteCustomVariable=function(di,dj){if(this.getCustomVariable(di,dj)){this.setCustomVariable(di,"","",dj)}};this.deleteCustomVariables=function(di){if(di==="page"||di===3){bW={}}else{if(di==="event"){cm={}}else{if(di==="visit"||di===2){aQ={}}}}};this.storeCustomVariablesInCookie=function(){bQ=true};this.setLinkTrackingTimer=function(di){bJ=di};this.getLinkTrackingTimer=function(){return bJ };this.setDownloadExtensions=function(di){if(w(di)){di=di.split("|")}c5=di};this.addDownloadExtensions=function(dj){var di;if(w(dj)){dj=dj.split("|")}for(di=0;di